AlgoWeb\ModelViews\Database\Connection

Complexity

Total Complexity

9

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	2
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	RegisterTableToProvide()	0	13	2
A	selectOne()	0	5	1
A	select()	0	9	1
A	ProcessSQL()	0	3	1
A	getSQL()	0	14	4

<?php
namespace AlgoWeb\ModelViews\Database;

use Illuminate\Database\Connection as BaseConnection;
use Illuminate\Database\Eloquent\Model;

class Connection extends BaseConnection

The property $information_schema is not named in camelCase.

{
    protected static $classes = [];

    protected static $information_schema = [];

$information_schema does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    public static function RegisterTableToProvide($ModelOfTable)

function RegisterTableToProvide() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

$ModelOfTable does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The parameter $ModelOfTable is not named in camelCase.

This method is not in camel caps format.

    {
        self::$classes[] = $ModelOfTable;

$ModelOfTable does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $currentISchemaTables = 0;
        if(array_key_exists("tables",self::$information_schema)){

The string literal tables does not require double quotes, as per coding-style, please use single quotes.

            $currentISchemaTables = count(self::$information_schema["tables"]);

The string literal tables does not require double quotes, as per coding-style, please use single quotes.

        } else {
            self::$information_schema["tables"] = [];

The string literal tables does not require double quotes, as per coding-style, please use single quotes.

        }
        self::$information_schema["tables"][$currentISchemaTables]["Model"] = $ModelOfTable;

$ModelOfTable does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The string literal tables does not require double quotes, as per coding-style, please use single quotes.

The string literal Model does not require double quotes, as per coding-style, please use single quotes.

        self::$information_schema["tables"][$currentISchemaTables]["TABLE_NAME"] = $ModelOfTable::getTableName();  

$ModelOfTable does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The string literal tables does not require double quotes, as per coding-style, please use single quotes.

The string literal TABLE_NAME does not require double quotes, as per coding-style, please use single quotes.

        self::$information_schema["tables"][$currentISchemaTables]["TABLE_SCHEMA"] = \Config::get('database.connections.'.\Config::get('database.default').'.database');

The string literal tables does not require double quotes, as per coding-style, please use single quotes.

The string literal TABLE_SCHEMA does not require double quotes, as per coding-style, please use single quotes.

This line exceeds maximum limit of 120 characters; contains 168 characters

    }

    protected $normalizer;
    /**
     * Run a select statement and return a single result.
     *
     * @param  string $query
     * @param  array  $bindings
     * @return mixed
     */
    public function selectOne($query, $bindings = array())
    {
        $records = parent::select($query, $bindings);

It seems like you call parent on a different method (select() instead of selectOne()). Are you sure this is correct? If so, you might want to change this to $this->select().

        return $records;
    }
    /**
     * Run a select statement against the database.
     *
     * @param  string                                  $query
     * @param  array                                   $bindings
     * @return \Stidges\LaravelDbNormalizer\Collection

Should the return type not be array? Also, consider making the array more specific, something like array<String>, or String[].

     */
    public function select($query, $bindings = array())
    {

//dd(self::$information_schema);

86% of this comment could be valid code. Did you maybe forget this after debugging?

dd(self::getSQL($query,$bindings));
        $records = parent::select($query, $bindings);
dd($records);
        return $records;
    }

    private function ProcessSQL($query,$results){

function ProcessSQL() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

The parameter $query is not used and could be removed.

The parameter $results is not used and could be removed.

This method is not in camel caps format.

    
    }

    private static function getSQL($sql, $bindings)
    {
        $needle = '?';
        foreach ($bindings as $replace){
            $pos = strpos($sql, $needle);
            if ($pos !== false) {
                if (gettype($replace) === "string") {

The string literal string does not require double quotes, as per coding-style, please use single quotes.

                     $replace = ' "'.addslashes($replace).'" ';
                }
                $sql = substr_replace($sql, $replace, $pos, strlen($needle));

Consider using a different name than the parameter $sql. This often makes code more readable.

            }
        }
        return $sql;
    }
}