Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types = 1); |
||
8 | class Expression |
||
9 | { |
||
10 | /** @var array */ |
||
11 | private $filters; |
||
12 | |||
13 | /** |
||
14 | * Expression constructor. |
||
15 | */ |
||
16 | 16 | public function __construct() |
|
20 | |||
21 | /** |
||
22 | * @param array|Expression $expression |
||
23 | * |
||
24 | * @return $this |
||
25 | */ |
||
26 | View Code Duplication | public function and($expression) |
|
37 | |||
38 | /** |
||
39 | * @param array|Expression $expression |
||
40 | * |
||
41 | * @return $this |
||
42 | */ |
||
43 | View Code Duplication | public function or($expression) |
|
54 | |||
55 | /** |
||
56 | * @param string $field |
||
57 | * @param string|Expression $expression |
||
58 | * |
||
59 | 2 | * @return $this |
|
60 | */ |
||
61 | 2 | public function equal(string $field, $expression) |
|
69 | |||
70 | /** |
||
71 | * @param string $field |
||
72 | 16 | * @param string|Expression $expression |
|
73 | * |
||
74 | 16 | * @return $this |
|
75 | */ |
||
76 | public function notEqual(string $field, $expression) |
||
84 | |||
85 | 11 | /** |
|
86 | * @return array |
||
87 | */ |
||
88 | public function getExpressionFilters(): array |
||
92 | 9 | ||
93 | /** |
||
94 | 9 | * @param string $operator |
|
95 | */ |
||
96 | 9 | private function prepareFilterIndex(string $operator) |
|
102 | |||
103 | /** |
||
104 | * @param $expressions |
||
105 | * |
||
106 | * @return array |
||
107 | */ |
||
108 | 2 | private function mapExpressions($expressions): array |
|
117 | |||
118 | /** |
||
119 | * @param string $operation |
||
120 | * @param string|Expression $expression |
||
121 | * |
||
122 | * @return array |
||
123 | */ |
||
124 | private function operationExpression(string $operation, $expression): array |
||
130 | } |
||
131 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.