Query::__construct() - Code Metrics - Inspection of "some fix and some tests" - Algatux/mongodb-querybuilder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a05d3f...d1e32c )

by Alessandro

created 2016-12-23 22:16 UTC

Query::__construct() A

↳ Parent: Query

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	4
crap	1

<?php declare(strict_types = 1);

namespace Algatux\QueryBuilder;

use MongoDB\Collection;
use MongoDB\Driver\Cursor;

/**
 * Class Query
 */
class Query
{
    const TYPE_FIND            = 1;
    const TYPE_FIND_AND_UPDATE = 2;
    const TYPE_FIND_AND_REMOVE = 3;
    const TYPE_INSERT          = 4;
    const TYPE_UPDATE          = 5;
    const TYPE_REMOVE          = 6;
    const TYPE_GROUP           = 7;
    const TYPE_MAP_REDUCE      = 8;
    const TYPE_DISTINCT        = 9;
    const TYPE_GEO_NEAR        = 10;
    const TYPE_COUNT           = 11;

    /** @var Collection */
    private $collection;
    /** @var array  */
    private $filters;
    /** @var array  */
    private $options;
    /** @var int */
    private $type;

    /**
     * Query constructor.
     *
     * @param Collection $collection
     * @param int        $type
     * @param array      $filters
     * @param array      $options
     */
    public function __construct(Collection $collection, int $type=self::TYPE_FIND, array $filters=[], array $options=[])
    {
        $this->collection = $collection;
        $this->filters = $filters;
        $this->options = $options;
        $this->type = $type;
    }

    /**
     * @return mixed
     *
     * @throws \Exception
     */
    public function execute()
    {
        switch($this->type) {
            case self::TYPE_FIND:
                    return $this->collection->find($this->filters, $this->options);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case self::TYPE_COUNT:
                    return $this->collection->count($this->filters, $this->options);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                throw new \Exception('Unsupported query type ... I\'m sorry');
        }
    }

    /**
     * @return array
     */
    public function getFilters(): array
    {
        return $this->filters;
    }

    /**
     * @return array
     */
    public function getOptions(): array
    {
        return $this->options;
    }
}


1		<?php declare(strict_types = 1);
2
3		namespace Algatux\QueryBuilder;
4
5		use MongoDB\Collection;
6		use MongoDB\Driver\Cursor;
7
8		/**
9		* Class Query
10		*/
11		class Query
12		{
13		const TYPE_FIND = 1;
14		const TYPE_FIND_AND_UPDATE = 2;
15		const TYPE_FIND_AND_REMOVE = 3;
16		const TYPE_INSERT = 4;
17		const TYPE_UPDATE = 5;
18		const TYPE_REMOVE = 6;
19		const TYPE_GROUP = 7;
20		const TYPE_MAP_REDUCE = 8;
21		const TYPE_DISTINCT = 9;
22		const TYPE_GEO_NEAR = 10;
23		const TYPE_COUNT = 11;
24
25		/** @var Collection */
26		private $collection;
27		/** @var array */
28		private $filters;
29		/** @var array */
30		private $options;
31		/** @var int */
32		private $type;
33
34		/**
35		* Query constructor.
36		*
37		* @param Collection $collection
38		* @param int $type
39		* @param array $filters
40		* @param array $options
41		*/
42	9	public function __construct(Collection $collection, int $type=self::TYPE_FIND, array $filters=[], array $options=[])
43		{
44	9	$this->collection = $collection;
45	9	$this->filters = $filters;
46	9	$this->options = $options;
47	9	$this->type = $type;
48	9	}
49
50		/**
51		* @return mixed
52		*
53		* @throws \Exception
54		*/
55	2	public function execute()
56		{
57	2	switch($this->type) {
58	2	case self::TYPE_FIND:
59	1	return $this->collection->find($this->filters, $this->options);
60		break;
		0 ignored issues – show Unused Code introduced 2016-12-22 23:12 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
61	1	case self::TYPE_COUNT:
62	1	return $this->collection->count($this->filters, $this->options);
63		break;
		0 ignored issues – show Unused Code introduced 2016-12-23 22:07 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
64		default:
65		throw new \Exception('Unsupported query type ... I\'m sorry');
66		}
67		}
68
69		/**
70		* @return array
71		*/
72	7	public function getFilters(): array
73		{
74	7	return $this->filters;
75		}
76
77		/**
78		* @return array
79		*/
80	4	public function getOptions(): array
81		{
82	4	return $this->options;
83		}
84		}
85

Algatux / mongodb-querybuilder

Push — master ( a05d3f...d1e32c )

Query::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like