Expression::or() - Code Metrics - Inspection of "Builder and Expression with and & or" - Algatux/mongodb-querybuilder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2f2a87...25acd6 )

by Alessandro

created 2016-12-23 15:54 UTC

Expression::or() A

↳ Parent: Expression

Complexity

Conditions	2
Paths	1

Size

Total Lines	16
Code Lines	9

Duplication

Lines	16
Ratio	100 %

Importance

Changes

Metric	Value
dl	16
loc	16
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	1
nop	1

<?php declare(strict_types = 1);

namespace Algatux\QueryBuilder;

/**
 * Class Expression.
 */
class Expression
{
    /** @var array */
    private $queryPartial;

    /**
     * Expression constructor.
     */
    public function __construct()
    {
        $this->queryPartial = [];
    }

    /**
     * @param array|Expression $expression
     *
     * @return $this
     */
    public function and($expression)

    {
        $this->prepareOperator('$and');

        $this->queryPartial['$and'] = array_merge(
            $this->queryPartial['$and'],
            array_map(
                function ($expression) {
                    return $expression instanceof Expression ? $expression->getQueryPartial() : $expression;
                },
                func_get_args()
            )
        );

        return $this;
    }

    /**
     * @param array|Expression $expression
     *
     * @return $this
     */
    public function or($expression)

    {
        $this->prepareOperator('$or');

        $this->queryPartial['$or'] = array_merge(
            $this->queryPartial['$or'],
            array_map(
                function ($expression) {
                    return $expression instanceof Expression ? $expression->getQueryPartial() : $expression;
                },
                func_get_args()
            )
        );

        return $this;
    }

    /**
     * @return array
     */
    public function getQueryPartial(): array
    {
        return $this->queryPartial;
    }

    /**
     * @param string $operator
     */
    private function prepareOperator(string $operator)
    {
        if (!isset($this->queryPartial[$operator])) {
            $this->queryPartial[$operator] = [];
        }
    }
}


1		<?php declare(strict_types = 1);
2
3		namespace Algatux\QueryBuilder;
4
5		/**
6		* Class Expression.
7		*/
8		class Expression
9		{
10		/** @var array */
11		private $queryPartial;
12
13		/**
14		* Expression constructor.
15		*/
16		public function __construct()
17		{
18		$this->queryPartial = [];
19		}
20
21		/**
22		* @param array\|Expression $expression
23		*
24		* @return $this
25		*/
26	View Code Duplication	public function and($expression)
		0 ignored issues – show Unused Code introduced 2016-12-23 15:55 UTC by Report Bug Copy Issue Report The parameter `$expression` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2016-12-23 15:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$this->prepareOperator('$and');
29
30		$this->queryPartial['$and'] = array_merge(
31		$this->queryPartial['$and'],
32		array_map(
33		function ($expression) {
34		return $expression instanceof Expression ? $expression->getQueryPartial() : $expression;
35		},
36		func_get_args()
37		)
38		);
39
40		return $this;
41		}
42
43		/**
44		* @param array\|Expression $expression
45		*
46		* @return $this
47		*/
48	View Code Duplication	public function or($expression)
		0 ignored issues – show Unused Code introduced 2016-12-23 15:55 UTC by Report Bug Copy Issue Report The parameter `$expression` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2016-12-23 15:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		{
50		$this->prepareOperator('$or');
51
52		$this->queryPartial['$or'] = array_merge(
53		$this->queryPartial['$or'],
54		array_map(
55		function ($expression) {
56		return $expression instanceof Expression ? $expression->getQueryPartial() : $expression;
57		},
58		func_get_args()
59		)
60		);
61
62		return $this;
63		}
64
65		/**
66		* @return array
67		*/
68		public function getQueryPartial(): array
69		{
70		return $this->queryPartial;
71		}
72
73		/**
74		* @param string $operator
75		*/
76		private function prepareOperator(string $operator)
77		{
78		if (!isset($this->queryPartial[$operator])) {
79		$this->queryPartial[$operator] = [];
80		}
81		}
82		}
83

Algatux / mongodb-querybuilder

Push — master ( 2f2a87...25acd6 )

Expression::or() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like