Expression::or() - Code Metrics - Inspection of "added some builder methods, prepared basic query f..." - Algatux/mongodb-querybuilder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5a434d...bba42e )

by Alessandro

created 2016-12-23 22:05 UTC

Expression::or() A

↳ Parent: Expression

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	1

<?php declare(strict_types = 1);

namespace Algatux\QueryBuilder;

/**
 * Class Expression.
 */
class Expression
{
    /** @var array */
    private $filters;

    /**
     * Expression constructor.
     */
    public function __construct()
    {
        $this->filters = [];
    }

    /**
     * @param array|Expression $expression
     *
     * @return $this
     */
    public function and($expression)

    {
        $this->prepareOperator('$and');

        $this->filters['$and'] = array_merge(
            $this->filters['$and'],
            $this->mapExpressions(...func_get_args())
        );

        return $this;
    }

    /**
     * @param array|Expression $expression
     *
     * @return $this
     */
    public function or($expression)

    {
        $this->prepareOperator('$or');

        $this->filters['$or'] = array_merge(
            $this->filters['$or'],
            $this->mapExpressions(...func_get_args())
        );

        return $this;
    }

    /**
     * @return array
     */
    public function getExpressionFilters(): array
    {
        return $this->filters;
    }

    /**
     * @param string $operator
     */
    private function prepareOperator(string $operator)
    {
        if (!isset($this->filters[$operator])) {
            $this->filters[$operator] = [];
        }
    }

    /**
     * @param $expressions
     *
     * @return array
     */
    private function mapExpressions($expressions): array

    {
        return array_map(
            function ($expression) {
                return $expression instanceof Expression ? $expression->getExpressionFilters() : $expression;
            },
            func_get_args()
        );
    }
}


1		<?php declare(strict_types = 1);
2
3		namespace Algatux\QueryBuilder;
4
5		/**
6		* Class Expression.
7		*/
8		class Expression
9		{
10		/** @var array */
11		private $filters;
12
13		/**
14		* Expression constructor.
15		*/
16		public function __construct()
17		{
18		$this->filters = [];
19		}
20
21		/**
22		* @param array\|Expression $expression
23		*
24		* @return $this
25		*/
26	View Code Duplication	public function and($expression)
		0 ignored issues – show Unused Code introduced 2016-12-23 15:55 UTC by Report Bug Copy Issue Report The parameter `$expression` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2016-12-23 15:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$this->prepareOperator('$and');
29
30		$this->filters['$and'] = array_merge(
31		$this->filters['$and'],
32		$this->mapExpressions(...func_get_args())
33		);
34
35		return $this;
36		}
37
38		/**
39		* @param array\|Expression $expression
40		*
41		* @return $this
42		*/
43	View Code Duplication	public function or($expression)
		0 ignored issues – show Unused Code introduced 2016-12-23 15:55 UTC by Report Bug Copy Issue Report The parameter `$expression` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2016-12-23 15:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$this->prepareOperator('$or');
46
47		$this->filters['$or'] = array_merge(
48		$this->filters['$or'],
49		$this->mapExpressions(...func_get_args())
50		);
51
52		return $this;
53		}
54
55		/**
56		* @return array
57		*/
58		public function getExpressionFilters(): array
59		{
60		return $this->filters;
61		}
62
63		/**
64		* @param string $operator
65		*/
66		private function prepareOperator(string $operator)
67		{
68		if (!isset($this->filters[$operator])) {
69		$this->filters[$operator] = [];
70		}
71		}
72
73		/**
74		* @param $expressions
75		*
76		* @return array
77		*/
78		private function mapExpressions($expressions): array
		0 ignored issues – show Unused Code introduced 2016-12-23 16:03 UTC by Report Bug Copy Issue Report The parameter `$expressions` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
79		{
80		return array_map(
81		function ($expression) {
82		return $expression instanceof Expression ? $expression->getExpressionFilters() : $expression;
83		},
84		func_get_args()
85		);
86		}
87		}
88

Algatux / mongodb-querybuilder

Push — master ( 5a434d...bba42e )

Expression::or() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like