Query - Code Metrics - Inspection of "Query class basic structure" - Algatux/mongodb-querybuilder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( db1c89...2f2a87 )

by Alessandro

created 2016-12-22 23:10 UTC

Query A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	1
dl	0
loc	70
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	__construct()	7	1
A	execute()	10	2
A	getQuery()	4	1
A	getOptions()	4	1

<?php declare(strict_types = 1);

namespace Algatux\QueryBuilder;

use MongoDB\Collection;

/**
 * Class Query
 */
class Query
{
    const TYPE_FIND            = 1;
    const TYPE_FIND_AND_UPDATE = 2;
    const TYPE_FIND_AND_REMOVE = 3;
    const TYPE_INSERT          = 4;
    const TYPE_UPDATE          = 5;
    const TYPE_REMOVE          = 6;
    const TYPE_GROUP           = 7;
    const TYPE_MAP_REDUCE      = 8;
    const TYPE_DISTINCT        = 9;
    const TYPE_GEO_NEAR        = 10;
    const TYPE_COUNT           = 11;

    /** @var Collection */
    private $collection;
    /** @var array  */
    private $query;
    /** @var array  */
    private $options;
    /** @var int */
    private $type;

    /**
     * Query constructor.
     *
     * @param Collection $collection
     * @param array      $query
     * @param array      $options
     */
    public function __construct(Collection $collection, array $query = [], array $options = [])
    {
        $this->collection = $collection;
        $this->query = $query;
        $this->options = $options;
        $this->type = $query['type'] ?? self::TYPE_FIND;
    }

    /**
     * @return mixed
     *
     * @throws \Exception
     */
    public function execute()
    {
        switch($this->type) {
            case self::TYPE_FIND:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    return $this->collection->find($this->query, $this->options);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
switch ($expr) {
    default: { //wrong
        doSomething();
        break;
    }
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
                throw new \Exception('Unsupported query type ... I\'m sorry');
        }
    }

    /**
     * @return array
     */
    public function getQuery(): array
    {
        return $this->query;
    }

    /**
     * @return array
     */
    public function getOptions(): array
    {
        return $this->options;
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Algatux\QueryBuilder;
4
5			use MongoDB\Collection;
6
7			/**
8			* Class Query
9			*/
10			class Query
11			{
12			const TYPE_FIND = 1;
13			const TYPE_FIND_AND_UPDATE = 2;
14			const TYPE_FIND_AND_REMOVE = 3;
15			const TYPE_INSERT = 4;
16			const TYPE_UPDATE = 5;
17			const TYPE_REMOVE = 6;
18			const TYPE_GROUP = 7;
19			const TYPE_MAP_REDUCE = 8;
20			const TYPE_DISTINCT = 9;
21			const TYPE_GEO_NEAR = 10;
22			const TYPE_COUNT = 11;
23
24			/** @var Collection */
25			private $collection;
26			/** @var array */
27			private $query;
28			/** @var array */
29			private $options;
30			/** @var int */
31			private $type;
32
33			/**
34			* Query constructor.
35			*
36			* @param Collection $collection
37			* @param array $query
38			* @param array $options
39			*/
40			public function __construct(Collection $collection, array $query = [], array $options = [])
41			{
42			$this->collection = $collection;
43			$this->query = $query;
44			$this->options = $options;
45			$this->type = $query['type'] ?? self::TYPE_FIND;
46			}
47
48			/**
49			* @return mixed
50			*
51			* @throws \Exception
52			*/
53			public function execute()
54			{
55			switch($this->type) {
56			case self::TYPE_FIND:
			0 ignored issues – show Coding Style introduced 2016-12-22 23:12 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
57			return $this->collection->find($this->query, $this->options);
58			break;
			0 ignored issues – show Unused Code introduced 2016-12-22 23:12 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
59			default:
			0 ignored issues – show Coding Style introduced 2016-12-22 23:12 UTC by Report Bug Copy Issue Report DEFAULT statements must be defined using a colon As per the PSR-2 coding standard, default statements should not be wrapped in curly braces. switch ($expr) { default: { //wrong doSomething(); break; } } switch ($expr) { default: //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
60			throw new \Exception('Unsupported query type ... I\'m sorry');
61			}
62			}
63
64			/**
65			* @return array
66			*/
67			public function getQuery(): array
68			{
69			return $this->query;
70			}
71
72			/**
73			* @return array
74			*/
75			public function getOptions(): array
76			{
77			return $this->options;
78			}
79			}
80

Algatux / mongodb-querybuilder

Push — master ( db1c89...2f2a87 )

Query A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like