Algatux /
influxdb-bundle
| Conditions | 4 |
| Paths | 4 |
| Total Lines | 20 |
| Code Lines | 10 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 8 |
| CRAP Score | 4.128 |
| 1 | <?php |
||
| 32 | 2 | public function onInfluxDbEventDispatched(InfluxDbEvent $event): bool |
|
| 33 | { |
||
| 34 | |||
| 35 | 2 | if ($event->isPropagationStopped()) { |
|
| 36 | return false; |
||
| 37 | } |
||
| 38 | |||
| 39 | 2 | if ($event->getWriteClient() === ClientInterface::UDP_CLIENT) { |
|
| 40 | 1 | $this->udpWriter->write($event->getPoints(), ClientInterface::UDP_CLIENT); |
|
| 41 | 1 | return true; |
|
| 42 | } |
||
| 43 | |||
| 44 | 1 | if ($event->getWriteClient() === ClientInterface::HTTP_CLIENT) { |
|
| 45 | 1 | $this->httpWriter->write($event->getPoints(), ClientInterface::HTTP_CLIENT); |
|
| 46 | 1 | return true; |
|
| 47 | } |
||
| 48 | |||
| 49 | return false; |
||
| 50 | |||
| 51 | } |
||
| 52 | |||
| 54 |
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.