Algatux\InfluxDbBundle\Events\Listeners\InfluxDbEventListener

Complexity

Total Complexity

13

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	onPointsCollected()	0	16	2
A	onKernelTerminate()	0	11	3
A	writePoints()	0	10	3
A	initCollection()	0	10	3
A	mergeCollections()	0	12	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 15 and the first side effect is on line 2.

declare(strict_types=1);
namespace Algatux\InfluxDbBundle\Events\Listeners;
use Algatux\InfluxDbBundle\Events\DeferredInfluxDbEvent;
use Algatux\InfluxDbBundle\Events\InfluxDbEvent;
use Algatux\InfluxDbBundle\Model\PointsCollection;
use Algatux\InfluxDbBundle\Services\Clients\Contracts\ClientInterface;
use Algatux\InfluxDbBundle\Services\Clients\WriterClient;
use Symfony\Component\EventDispatcher\Event;

/**
 * Class InfluxDbEventListener
 * @package Algatux\InfluxDbBundle\Events\Listeners
 */
class InfluxDbEventListener
{

    /** @var WriterClient  */
    private $httpWriter;

    /** @var WriterClient  */
    private $udpWriter;

    /** @var \SplQueue  */
    private $pointCollections;

    /**
     * InfluxDbEventListener constructor.
     * @param WriterClient $httpWriter
     * @param WriterClient $udpWriter
     */
    public function __construct(WriterClient $httpWriter, WriterClient $udpWriter)
    {
        $this->httpWriter = $httpWriter;
        $this->udpWriter = $udpWriter;
        $this->pointCollections = null;
    }

    public function onPointsCollected(InfluxDbEvent $event): bool
    {
        $points = $event->getPoints();

        if ($event instanceof DeferredInfluxDbEvent) {

            $this->initCollection($event->getWriteMode(),$points->getPrecision());
            $this->mergeCollections($event->getWriteMode(), $points);

            return true;
        }

        $this->writePoints($event->getWriteMode(), $points);

        return true;
    }

    /**
     * @param Event $event
     * @return bool
     */
    public function onKernelTerminate(Event $event): bool

The parameter $event is not used and could be removed.

    {
        foreach ($this->pointCollections as $writeMode => $precisionGroup) {
            /** @var PointsCollection $pointsCollection */
            foreach ($precisionGroup as $precision => $pointsCollection) {
                $this->writePoints($writeMode, $pointsCollection);
            }
        }

        return true;
    }

    /**
     * @param string $writemode
     * @param $points
     */
    private function writePoints(string $writemode, $points)
    {
        if ($writemode === ClientInterface::UDP_CLIENT) {
            $this->udpWriter->write($points);
        }

        if ($writemode === ClientInterface::HTTP_CLIENT) {
            $this->httpWriter->write($points);
        }
    }

    /**
     * @param string $getWriteMode
     * @param string $getPrecision
     */
    private function initCollection(string $getWriteMode, string $getPrecision)
    {
        if (! isset($this->pointCollections[$getWriteMode])) {
            $this->pointCollections[$getWriteMode] = null;
        }

        if (!isset($this->pointCollections[$getWriteMode][$getPrecision])) {
            $this->pointCollections[$getWriteMode][$getPrecision] = new PointsCollection([], $getPrecision);
        }
    }

    /**
     * @param string $writemode
     * @param PointsCollection $points
     * @internal param InfluxDbEvent $event
     */
    private function mergeCollections(string $writemode, PointsCollection $points)
    {
        /** @var PointsCollection $actualCollection */
        $actualCollection = $this->pointCollections[$writemode][$points->getPrecision()];

        $mergedCollection = new PointsCollection(array_merge(
            $actualCollection->toArray(),
            $points->toArray()
        ), $points->getPrecision());

        $this->pointCollections[$writemode][$points->getPrecision()] = $mergedCollection;
    }

}