Issues in Encoder.php (master) - Issues in master - AlexMasterov/msgpack.php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (80)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Encoder.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);

namespace MessagePack;

use MessagePack\{
    Exception\UnsupportedType,
    Ext
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
};
use const MessagePack\CHR;
use function array_values;
use function count;
use function is_array;
use function is_bool;
use function is_float;
use function is_int;
use function is_string;
use function pack;
use function strlen;

final class Encoder
{
    public const FORCE_AUTO = 0b00;
    public const FORCE_ARR = 0b01;
    public const FORCE_MAP = 0b10;

    /** @var int */
    private $typeDetectionMode = self::FORCE_AUTO;

    public function __construct(int $typeDetectionMode = null)
    {
        if (null !== $typeDetectionMode) {
            $this->typeDetectionMode |= $typeDetectionMode;
        }
    }

    public function encode($value): string
    {
        if (is_int($value)) {
            return $this->encodeInt($value);
        }
        if (is_string($value)) {
            return $this->encodeStr($value);
        }
        if (is_array($value)) {
            if ($this->typeDetectionMode ^ self::FORCE_AUTO) {
                return $this->typeDetectionMode & self::FORCE_MAP
                    ? $this->encodeMap($value)
                    : $this->encodeArray($value);
            }
            return array_values($value) === $value
                ? $this->encodeArray($value)
                : $this->encodeMap($value);
        }
        if (is_float($value)) {
            return $this->encodeFloat($value);
        }
        if (is_bool($value)) {
            return $value ? "\xc3" : "\xc2";
        }
        if (null === $value) {
            return "\xc0";
        }
        if ($value instanceof Ext) {
            return $this->encodeExt($value);
        }

        throw UnsupportedType::withValue($value);
    }

    public function encodeNil(): string
    {
        return "\xc0";
    }

    public function encodeBool(bool $value): string
    {
        return $value ? "\xc3" : "\xc2";
    }

    public function encodeFloat(float $num): string
    {
        $b1 = pack('E', $num);

        return "\xcb${b1}";
    }

    public function encodeInt(int $num): string
    {
        if ($num >= 0) {
            // positive fixint
            if ($num <= 0x7f) {
                return CHR[$num];
            }
            // uint 8
            if ($num <= 0xff) {
                $b1 = CHR[$num];
                return "\xcc${b1}";
            }
            // uint 16
            if ($num <= 0xffff) {
                $b1 = CHR[$num >> 8];
                $b2 = CHR[$num & 0xff];
                return "\xcd${b1}${b2}";
            }
            // uint 32
            if ($num <= 0xffffffff) {
                $b1 = CHR[$num >> 24];
                $b2 = CHR[$num >> 16 & 0xff];
                $b3 = CHR[$num >> 8 & 0xff];
                $b4 = CHR[$num & 0xff];
                return "\xce${b1}${b2}${b3}${b4}";
            }
            // uint 64
            $hi = ($num & 0xffffffff00000000) >> 32;
            $lo = $num & 0x00000000ffffffff;

            $b1 = CHR[$hi >> 24 & 0xff];
            $b2 = CHR[$hi >> 16 & 0xff];
            $b3 = CHR[$hi >> 8 & 0xff];
            $b4 = CHR[$hi & 0xff];
            $b5 = CHR[$lo >> 24 & 0xff];
            $b6 = CHR[$lo >> 16 & 0xff];
            $b7 = CHR[$lo >> 8 & 0xff];
            $b8 = CHR[$lo & 0xff];
            return "\xcf${b1}${b2}${b3}${b4}${b5}${b6}${b7}${b8}";
        }
        // negative fixint
        if ($num >= -0x20) {
            return CHR[$num & 0xff];
        }
        // int 8
        if ($num >= -0x80) {
            $b1 = CHR[$num & 0xff];
            return "\xd0${b1}";
        }
        // int 16
        if ($num >= -0x8000) {
            $b1 = CHR[$num >> 8 & 0xff];
            $b2 = CHR[$num & 0xff];
            return "\xd1${b1}${b2}";
        }
        // int 32
        if ($num >= -0x80000000) {
            $num |= 0x100000000;
            $b1 = CHR[$num >> 24 & 0xff];
            $b2 = CHR[$num >> 16 & 0xff];
            $b3 = CHR[$num >> 8 & 0xff];
            $b4 = CHR[$num & 0xff];
            return "\xd2${b1}${b2}${b3}${b4}";
        }
        // int 64
        $hi = ($num & 0xffffffff00000000) >> 32;
        $lo = $num & 0x00000000ffffffff;

        $b1 = CHR[$hi >> 24 & 0xff];
        $b2 = CHR[$hi >> 16 & 0xff];
        $b3 = CHR[$hi >> 8 & 0xff];
        $b4 = CHR[$hi & 0xff];
        $b5 = CHR[$lo >> 24 & 0xff];
        $b6 = CHR[$lo >> 16 & 0xff];
        $b7 = CHR[$lo >> 8 & 0xff];
        $b8 = CHR[$lo & 0xff];
        return "\xd3${b1}${b2}${b3}${b4}${b5}${b6}${b7}${b8}";
    }

    public function encodeStr(string $str): string
    {
        $len = strlen($str);
        // fixstr
        if ($len < 0x20) {
            $b0 = CHR[0xa0 | $len];
            return "${b0}${str}";
        }
        // str 8
        if ($len <= 0xff) {
            $b1 = CHR[$len];
            return "\xd9${b1}${str}";
        }
        // str 16
        if ($len <= 0xffff) {
            $b1 = CHR[$len >> 8];
            $b2 = CHR[$len & 0xff];
            return "\xda${b1}${b2}${str}";
        }
        // str 32
        $b1 = CHR[$len >> 24];
        $b2 = CHR[$len >> 16];
        $b3 = CHR[$len >> 8];
        $b4 = CHR[$len & 0xff];
        return "\xdb${b1}${b2}${b3}${b4}${str}";
    }

    public function encodeArray(array $array): string
    {
        $size = count($array);

        if ($size <= 0xf) { // fixarray
            $data = CHR[0x90 | $size];
        } elseif ($size <= 0xffff) { // array 16
            $b1 = CHR[$size >> 8];
            $b2 = CHR[$size & 0xff];
            $data = "\xdc${b1}${b2}";
        } else { // array 32
            $b1 = CHR[$size >> 24];
            $b2 = CHR[$size >> 16];
            $b3 = CHR[$size >> 8];
            $b4 = CHR[$size & 0xff];
            $data = "\xdd${b1}${b2}${b3}${b4}";
        }

        foreach ($array as $value) {
            $data .= $this->encode($value);
        }

        return $data;
    }

    public function encodeMap(array $map): string
    {
        $size = count($map);

        if ($size <= 0xf) { // fixmap
            $data = CHR[0x80 | $size];
        } elseif ($size <= 0xffff) { // map 16
            $b1 = CHR[$size >> 8];
            $b2 = CHR[$size & 0xff];
            $data = "\xde${b1}${b2}";
        } else { // map 32
            $b1 = CHR[$size >> 24];
            $b2 = CHR[$size >> 16];
            $b3 = CHR[$size >> 8];
            $b4 = CHR[$size & 0xff];
            $data = "\xdf${b1}${b2}${b3}${b4}";
        }

        foreach ($map as $key => $value) {
            $data .= "{$this->encode($key)}{$this->encode($value)}";
        }

        return $data;
    }

    public function encodeExt(Ext $ext): string
    {
        $type = CHR[$ext->type() & 0x7f];
        $data = $ext->data();

        $len = strlen($data);

        // fixext 1/2/4/8/16
        switch ($len) {
            case 1: return "\xd4${type}${data}";
            case 2: return "\xd5${type}${data}";
            case 4: return "\xd6${type}${data}";
            case 8: return "\xd7${type}${data}";
            case 16: return "\xd8${type}${data}";
        }
        // ext 8
        if ($len <= 0xff) {
            $b1 = CHR[$len];
            return "\xc7${b1}${type}${data}";
        }
        // ext 16
        if ($len <= 0xffff) {
            $b1 = CHR[$len >> 8];
            $b2 = CHR[$len & 0xff];
            return "\xc8${b1}${b2}${type}${data}";
        }
        // ext 32
        $b1 = CHR[$len >> 24 & 0xff];
        $b2 = CHR[$len >> 16 & 0xff];
        $b3 = CHR[$len >> 8 & 0xff];
        $b4 = CHR[$len & 0xff];
        return "\xc9${b1}${b2}${b3}${b4}${type}${data}";
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace MessagePack;
5
6		use MessagePack\{
7		Exception\UnsupportedType,
8		Ext
		0 ignored issues – show Bug introduced 2018-03-13 07:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `MessagePack\Ext`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
9		};
10		use const MessagePack\CHR;
11		use function array_values;
12		use function count;
13		use function is_array;
14		use function is_bool;
15		use function is_float;
16		use function is_int;
17		use function is_string;
18		use function pack;
19		use function strlen;
20
21		final class Encoder
22		{
23		public const FORCE_AUTO = 0b00;
24		public const FORCE_ARR = 0b01;
25		public const FORCE_MAP = 0b10;
26
27		/** @var int */
28		private $typeDetectionMode = self::FORCE_AUTO;
29
30	71	public function __construct(int $typeDetectionMode = null)
31		{
32	71	if (null !== $typeDetectionMode) {
33	5	$this->typeDetectionMode \|= $typeDetectionMode;
34		}
35	71	}
36
37	71	public function encode($value): string
38		{
39	71	if (is_int($value)) {
40	41	return $this->encodeInt($value);
41		}
42	45	if (is_string($value)) {
43	7	return $this->encodeStr($value);
44		}
45	38	if (is_array($value)) {
46	16	if ($this->typeDetectionMode ^ self::FORCE_AUTO) {
47	3	return $this->typeDetectionMode & self::FORCE_MAP
48	2	? $this->encodeMap($value)
49	3	: $this->encodeArray($value);
50		}
51	13	return array_values($value) === $value
52	8	? $this->encodeArray($value)
53	13	: $this->encodeMap($value);
54		}
55	22	if (is_float($value)) {
56	6	return $this->encodeFloat($value);
57		}
58	16	if (is_bool($value)) {
59	3	return $value ? "\xc3" : "\xc2";
60		}
61	13	if (null === $value) {
62	1	return "\xc0";
63		}
64	12	if ($value instanceof Ext) {
65	9	return $this->encodeExt($value);
66		}
67
68	3	throw UnsupportedType::withValue($value);
69		}
70
71		public function encodeNil(): string
72		{
73		return "\xc0";
74		}
75
76		public function encodeBool(bool $value): string
77		{
78		return $value ? "\xc3" : "\xc2";
79		}
80
81	6	public function encodeFloat(float $num): string
82		{
83	6	$b1 = pack('E', $num);
84
85	6	return "\xcb${b1}";
86		}
87
88		public function encodeInt(int $num): string
89		{
90	41	if ($num >= 0) {
91		// positive fixint
92	25	if ($num <= 0x7f) {
93	17	return CHR[$num];
94		}
95		// uint 8
96	10	if ($num <= 0xff) {
97	4	$b1 = CHR[$num];
98	4	return "\xcc${b1}";
99		}
100		// uint 16
101	8	if ($num <= 0xffff) {
102	4	$b1 = CHR[$num >> 8];
103	4	$b2 = CHR[$num & 0xff];
104	4	return "\xcd${b1}${b2}";
105		}
106		// uint 32
107	5	if ($num <= 0xffffffff) {
108	3	$b1 = CHR[$num >> 24];
109	3	$b2 = CHR[$num >> 16 & 0xff];
110	3	$b3 = CHR[$num >> 8 & 0xff];
111	3	$b4 = CHR[$num & 0xff];
112	3	return "\xce${b1}${b2}${b3}${b4}";
113		}
114		// uint 64
115	2	$hi = ($num & 0xffffffff00000000) >> 32;
116	2	$lo = $num & 0x00000000ffffffff;
117
118	2	$b1 = CHR[$hi >> 24 & 0xff];
119	2	$b2 = CHR[$hi >> 16 & 0xff];
120	2	$b3 = CHR[$hi >> 8 & 0xff];
121	2	$b4 = CHR[$hi & 0xff];
122	2	$b5 = CHR[$lo >> 24 & 0xff];
123	2	$b6 = CHR[$lo >> 16 & 0xff];
124	2	$b7 = CHR[$lo >> 8 & 0xff];
125	2	$b8 = CHR[$lo & 0xff];
126	2	return "\xcf${b1}${b2}${b3}${b4}${b5}${b6}${b7}${b8}";
127		}
128		// negative fixint
129	16	if ($num >= -0x20) {
130	2	return CHR[$num & 0xff];
131		}
132		// int 8
133	14	if ($num >= -0x80) {
134	2	$b1 = CHR[$num & 0xff];
135	2	return "\xd0${b1}";
136		}
137		// int 16
138	12	if ($num >= -0x8000) {
139	2	$b1 = CHR[$num >> 8 & 0xff];
140	2	$b2 = CHR[$num & 0xff];
141	2	return "\xd1${b1}${b2}";
142		}
143		// int 32
144	10	if ($num >= -0x80000000) {
145	2	$num \|= 0x100000000;
146	2	$b1 = CHR[$num >> 24 & 0xff];
147	2	$b2 = CHR[$num >> 16 & 0xff];
148	2	$b3 = CHR[$num >> 8 & 0xff];
149	2	$b4 = CHR[$num & 0xff];
150	2	return "\xd2${b1}${b2}${b3}${b4}";
151		}
152		// int 64
153	8	$hi = ($num & 0xffffffff00000000) >> 32;
154	8	$lo = $num & 0x00000000ffffffff;
155
156	8	$b1 = CHR[$hi >> 24 & 0xff];
157	8	$b2 = CHR[$hi >> 16 & 0xff];
158	8	$b3 = CHR[$hi >> 8 & 0xff];
159	8	$b4 = CHR[$hi & 0xff];
160	8	$b5 = CHR[$lo >> 24 & 0xff];
161	8	$b6 = CHR[$lo >> 16 & 0xff];
162	8	$b7 = CHR[$lo >> 8 & 0xff];
163	8	$b8 = CHR[$lo & 0xff];
164	8	return "\xd3${b1}${b2}${b3}${b4}${b5}${b6}${b7}${b8}";
165		}
166
167		public function encodeStr(string $str): string
168		{
169	7	$len = strlen($str);
170		// fixstr
171	7	if ($len < 0x20) {
172	2	$b0 = CHR[0xa0 \| $len];
173	2	return "${b0}${str}";
174		}
175		// str 8
176	5	if ($len <= 0xff) {
177	2	$b1 = CHR[$len];
178	2	return "\xd9${b1}${str}";
179		}
180		// str 16
181	3	if ($len <= 0xffff) {
182	2	$b1 = CHR[$len >> 8];
183	2	$b2 = CHR[$len & 0xff];
184	2	return "\xda${b1}${b2}${str}";
185		}
186		// str 32
187	1	$b1 = CHR[$len >> 24];
188	1	$b2 = CHR[$len >> 16];
189	1	$b3 = CHR[$len >> 8];
190	1	$b4 = CHR[$len & 0xff];
191	1	return "\xdb${b1}${b2}${b3}${b4}${str}";
192		}
193
194		public function encodeArray(array $array): string
195		{
196	9	$size = count($array);
197
198	9	if ($size <= 0xf) { // fixarray
199	6	$data = CHR[0x90 \| $size];
200	3	} elseif ($size <= 0xffff) { // array 16
201	2	$b1 = CHR[$size >> 8];
202	2	$b2 = CHR[$size & 0xff];
203	2	$data = "\xdc${b1}${b2}";
204		} else { // array 32
205	1	$b1 = CHR[$size >> 24];
206	1	$b2 = CHR[$size >> 16];
207	1	$b3 = CHR[$size >> 8];
208	1	$b4 = CHR[$size & 0xff];
209	1	$data = "\xdd${b1}${b2}${b3}${b4}";
210		}
211
212	9	foreach ($array as $value) {
213	8	$data .= $this->encode($value);
214		}
215
216	9	return $data;
217		}
218
219		public function encodeMap(array $map): string
220		{
221	7	$size = count($map);
222
223	7	if ($size <= 0xf) { // fixmap
224	4	$data = CHR[0x80 \| $size];
225	3	} elseif ($size <= 0xffff) { // map 16
226	2	$b1 = CHR[$size >> 8];
227	2	$b2 = CHR[$size & 0xff];
228	2	$data = "\xde${b1}${b2}";
229		} else { // map 32
230	1	$b1 = CHR[$size >> 24];
231	1	$b2 = CHR[$size >> 16];
232	1	$b3 = CHR[$size >> 8];
233	1	$b4 = CHR[$size & 0xff];
234	1	$data = "\xdf${b1}${b2}${b3}${b4}";
235		}
236
237	7	foreach ($map as $key => $value) {
238	7	$data .= "{$this->encode($key)}{$this->encode($value)}";
239		}
240
241	7	return $data;
242		}
243
244		public function encodeExt(Ext $ext): string
245		{
246	9	$type = CHR[$ext->type() & 0x7f];
247	9	$data = $ext->data();
248
249	9	$len = strlen($data);
250
251		// fixext 1/2/4/8/16
252	9	switch ($len) {
253	9	case 1: return "\xd4${type}${data}";
254	8	case 2: return "\xd5${type}${data}";
255	7	case 4: return "\xd6${type}${data}";
256	6	case 8: return "\xd7${type}${data}";
257	5	case 16: return "\xd8${type}${data}";
258		}
259		// ext 8
260	4	if ($len <= 0xff) {
261	1	$b1 = CHR[$len];
262	1	return "\xc7${b1}${type}${data}";
263		}
264		// ext 16
265	3	if ($len <= 0xffff) {
266	2	$b1 = CHR[$len >> 8];
267	2	$b2 = CHR[$len & 0xff];
268	2	return "\xc8${b1}${b2}${type}${data}";
269		}
270		// ext 32
271	1	$b1 = CHR[$len >> 24 & 0xff];
272	1	$b2 = CHR[$len >> 16 & 0xff];
273	1	$b3 = CHR[$len >> 8 & 0xff];
274	1	$b4 = CHR[$len & 0xff];
275	1	return "\xc9${b1}${b2}${b3}${b4}${type}${data}";
276		}
277		}
278

AlexMasterov / msgpack.php

Issues (80)

Security Analysis no request data

src/Encoder.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like