Tests\CycleTimeCalculatorTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	107
Duplicated Lines	52.34 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	5	1
A	testCalculateFromCardHistoryWithEmptyData()	0	8	1
A	testCalculateFromCardHistory()	28	28	1
A	testCalculateWithStaticFromAndTo()	28	28	1
A	testCalculateWithStaticFromAndToNull()	0	28	1

<?php

namespace Tests;

use PHPUnit\Framework\TestCase;
use TrelloCycleTime\Collection\HistoryCards;
use TrelloCycleTime\CycleTimeCalculator;
use TrelloCycleTime\ValueObject\HistoryCard;
use TrelloCycleTime\ValueObject\TimeCard;

class CycleTimeCalculatorTest extends TestCase
{
    private $historyCards;
    private $cycleTimeCalculator;

    public function setUp()
    {
        $this->historyCards = $this->prophesize(HistoryCards::class);
        $this->cycleTimeCalculator = new CycleTimeCalculator([], $this->historyCards->reveal());
    }

    public function testCalculateFromCardHistoryWithEmptyData()
    {
        $historyCard = $this->prophesize(HistoryCard::class);
        $this->historyCards->getCardHistories()->willReturn([]);
        $this->cycleTimeCalculator->calculateFromCardHistory($historyCard->reveal());

The call to CycleTimeCalculator::calculateFromCardHistory() has too many arguments starting with $historyCard->reveal().

        $this->assertEquals([], $this->cycleTimeCalculator->getTimeCards());
    }

    public function testCalculateFromCardHistory()

This method seems to be duplicated in your project.

    {
        $cardId = 1;
        $fromKey = 'from';
        $toKey = 'to';
        $fromDate = '2019-05-25 00:00:00';
        $toDate = '2019-05-26 00:00:00';

        $historyCard = $this->prophesize(HistoryCard::class);
        $historyCard->getId()->willReturn($cardId);
        $historyCard->getFrom()->willReturn($fromKey);
        $historyCard->getTo()->willReturn($toKey);

        $timeCard = $this->prophesize(TimeCard::class);
        $timeCard->getId()->willReturn($cardId);
        $timeCard->calculateDayDifferenceBetweenColumns($fromKey, $fromDate, $toKey, $toDate)->shouldBeCalled();

        $this->historyCards->getCardHistories()->willReturn([$historyCard->reveal()]);
        $this->historyCards->getByCardIdAndTo($cardId, $fromKey)->willReturn($fromDate);
        $this->historyCards->getByCardIdAndTo($cardId, $toKey)->willReturn($toDate);

        $timeCardsCollection = [
            $timeCard->reveal()
        ];

        $this->cycleTimeCalculator = new CycleTimeCalculator($timeCardsCollection, $this->historyCards->reveal());
        $this->cycleTimeCalculator->calculateFromCardHistory();
    }

    public function testCalculateWithStaticFromAndTo()

This method seems to be duplicated in your project.

    {
        $cardId = 1;
        $fromKey = 'from';
        $toKey = 'to';
        $fromDate = '2019-05-25 00:00:00';
        $toDate = '2019-05-26 00:00:00';

        $historyCard = $this->prophesize(HistoryCard::class);
        $historyCard->getId()->willReturn($cardId);
        $historyCard->getFrom()->willReturn($fromKey);
        $historyCard->getTo()->willReturn($toKey);

        $timeCard = $this->prophesize(TimeCard::class);
        $timeCard->getId()->willReturn($cardId);
        $timeCard->calculateDayDifferenceBetweenColumns($fromKey, $fromDate, $toKey, $toDate)->shouldBeCalled();

        $this->historyCards->getCardHistories()->willReturn([$historyCard->reveal()]);
        $this->historyCards->getByCardIdAndTo($cardId, $fromKey)->willReturn($fromDate);
        $this->historyCards->getByCardIdAndTo($cardId, $toKey)->willReturn($toDate);

        $timeCardsCollection = [
            $timeCard->reveal()
        ];

        $this->cycleTimeCalculator = new CycleTimeCalculator($timeCardsCollection, $this->historyCards->reveal());
        $this->cycleTimeCalculator->calculateWithStaticFromAndTo($fromKey, $toKey);
    }

    public function testCalculateWithStaticFromAndToNull()
    {
        $cardId = 1;
        $fromKey = null;
        $toKey = null;
        $fromDate = '2019-05-25 00:00:00';
        $toDate = '2019-05-26 00:00:00';

        $historyCard = $this->prophesize(HistoryCard::class);
        $historyCard->getId()->willReturn($cardId);
        $historyCard->getFrom()->willReturn($fromKey);
        $historyCard->getTo()->willReturn($toKey);

        $timeCard = $this->prophesize(TimeCard::class);
        $timeCard->getId()->willReturn($cardId);
        $timeCard->calculateDayDifferenceBetweenColumns($fromKey, $fromDate, $toKey, $toDate)->shouldNotBeCalled();

        $this->historyCards->getCardHistories()->willReturn([$historyCard->reveal()]);
        $this->historyCards->getByCardIdAndTo($cardId, $fromKey)->willReturn($fromDate);
        $this->historyCards->getByCardIdAndTo($cardId, $toKey)->willReturn($toDate);

        $timeCardsCollection = [
            $timeCard->reveal()
        ];

        $this->cycleTimeCalculator = new CycleTimeCalculator($timeCardsCollection, $this->historyCards->reveal());
        $this->cycleTimeCalculator->calculateWithStaticFromAndTo($fromKey, $toKey);
    }
}