TrelloCycleTime\ValueObject\CycleTime

Complexity

Total Complexity

9

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

93.33%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	createFromCardHistory()	0	9	1
A	getFrom()	0	4	1
A	getTo()	0	4	1
A	getName()	0	4	1
A	jsonSerialize()	0	9	1
A	createWithDays()	0	6	1
A	getDays()	0	4	1
A	setDays()	0	4	1

<?php

declare(strict_types=1);

namespace TrelloCycleTime\ValueObject;


class CycleTime implements \JsonSerializable
{
    /**
     * @var string
     */
    private $from;
    /**
     * @var string
     */
    private $to;
    /**
     * @var float
     */
    private $days;
    /**
     * @var string
     */
    private $name;

    private function __construct(string $from, string $to, ?float $days, string $name)
    {
        $this->from = $from;
        $this->to = $to;
        $this->days = $days;
        $this->name = $name;
    }

    public static function createFromCardHistory(HistoryCard $cardHistory): CycleTime
    {
        $from = $cardHistory->getFrom();
        $to = $cardHistory->getTo();
        $name = $from . '_' . $to;
        $days = null;

        return new self($from, $to, $days, $name);
    }

    public static function createWithDays(string $from, string $to, float $days): CycleTime
    {
        $name = $from . '_' . $to;

        return new self($from, $to, $days, $name);
    }

    /**
     * @return string
     */
    public function getFrom(): string
    {
        return $this->from;
    }

    /**
     * @return string
     */
    public function getTo(): string
    {
        return $this->to;
    }

    /**
     * @return float
     */
    public function getDays(): ?float
    {
        return $this->days;
    }

    public function setDays(string $days)
    {
        return $this->days = $days;

The property $days was declared of type double, but $days is of type string. Maybe add a type cast?

    }

    /**
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    /**
     * Specify data which should be serialized to JSON
     * @link https://php.net/manual/en/jsonserializable.jsonserialize.php
     * @return mixed data which can be serialized by <b>json_encode</b>,
     * which is a value of any type other than a resource.
     * @since 5.4.0
     */
    public function jsonSerialize()
    {
        return [
            'from' => $this->from,
            'to' => $this->to,
            'days' => $this->days,
            'name' => $this->name
        ];
    }
}