CurrencyConverter::convert() - Code Metrics - Inspection of "improved covergae (#10)" - AlessandroMinoccheri/currency-converter - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 48c775...23192d )

by Alessandro

created 2019-04-16 21:12 UTC

CurrencyConverter::convert() A

↳ Parent: CurrencyConverter

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	5
cts	5
cp	1
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	3
crap	1

<?php

namespace CurrencyConverter;

class CurrencyConverter
{
    private $fromCurrency;

    private $toCurrency;

    private $apiKey;

    private $apiCaller;

    private $rates;

    public function __construct(string $apiKey)
    {
        $this->apiKey = $apiKey;
        $this->apiCaller = new ApiCaller($apiKey);
        $this->rates = new Rates($this->apiCaller);
    }

    public function convert(string $fromCurrency, string $toCurrency, $amount) :float
    {
        $this->fromCurrency = $fromCurrency;
        $this->toCurrency = $toCurrency;

        $rate = $this->rates->getRates($fromCurrency, $toCurrency);

        return $this->calculateValue($rate, $amount);
    }

    public function getRates(string $fromCurrency, string $toCurrency) :float
    {
        return $this->rates->getRates($fromCurrency, $toCurrency);
    }

    private function calculateValue($rate, $amount) :float
    {
        $value = (double)$rate * (double)$amount;

        return number_format((double)$value, 2, '.', '');
    }

    public function setApiCaller(ApiCaller $apiCaller)
    {
        $this->apiCaller = $apiCaller;
    }

    public function setRates(Rates $rates)
    {
        $this->rates = $rates;
    }

    public function getApiCaller() :ApiCaller
    {
        return $this->apiCaller;
    }
}


1		<?php
2
3		namespace CurrencyConverter;
4
5		class CurrencyConverter
6		{
7		private $fromCurrency;
8
9		private $toCurrency;
10
11		private $apiKey;
12
13		private $apiCaller;
14
15		private $rates;
16
17	4	public function __construct(string $apiKey)
18		{
19	4	$this->apiKey = $apiKey;
20	4	$this->apiCaller = new ApiCaller($apiKey);
21	4	$this->rates = new Rates($this->apiCaller);
22	4	}
23
24	3	public function convert(string $fromCurrency, string $toCurrency, $amount) :float
25		{
26	3	$this->fromCurrency = $fromCurrency;
27	3	$this->toCurrency = $toCurrency;
28
29	3	$rate = $this->rates->getRates($fromCurrency, $toCurrency);
30
31	2	return $this->calculateValue($rate, $amount);
32		}
33
34	1	public function getRates(string $fromCurrency, string $toCurrency) :float
35		{
36	1	return $this->rates->getRates($fromCurrency, $toCurrency);
37		}
38
39	2	private function calculateValue($rate, $amount) :float
40		{
41	2	$value = (double)$rate * (double)$amount;
42
43	2	return number_format((double)$value, 2, '.', '');
44		}
45
46		public function setApiCaller(ApiCaller $apiCaller)
47		{
48		$this->apiCaller = $apiCaller;
49		}
50
51	3	public function setRates(Rates $rates)
52		{
53	3	$this->rates = $rates;
54	3	}
55
56		public function getApiCaller() :ApiCaller
57		{
58		return $this->apiCaller;
59		}
60		}
61

AlessandroMinoccheri / currency-converter

Push — master ( 48c775...23192d )

CurrencyConverter::convert() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like