ApiCaller::convert() - Code Metrics - AlessandroMinoccheri/currency-converter - Measure and Improve Code Quality continuously with Scrutinizer

ApiCaller::convert() A
last analyzed 2019-04-16 21:22 UTC

↳ Parent: ApiCaller

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3.1105

Importance

Changes

Metric	Value
dl	0
loc	26
ccs	10
cts	13
cp	0.7692
rs	9.504
c	0
b	0
f	0
cc	3
nc	3
nop	2
crap	3.1105

<?php

namespace CurrencyConverter;

class ApiCaller
{
    private $response;

    private $apiKey;

    public function __construct(string $apiKey)
    {
        $this->apiKey = $apiKey;
    }

    public function convert($from, $to)
    {
        $url = 'https://free.currencyconverterapi.com'
            . '/api/v5/convert'
            . '?q=' . $from . '_' . $to
            . '&compact=ultra'
            . '&apiKey=' . $this->apiKey;


        if ($handle = @fopen($url, 'r')) {
            $this->response = fgets($handle, 4096);

            fclose($handle);

            return;
        }

        $errorMessage = 'Error on convert rates';

        $errors = error_get_last();
        if (isset ($errors['message'])) {
            $errorMessage = $errors['message'];
        }

        throw new \Exception($errorMessage);
    }

    public function isLastCallEmpty(): bool
    {
        return $this->response == null;
    }

    public function getLastResponse(): ?string
    {
        return $this->response;
    }
}


1		<?php
2
3		namespace CurrencyConverter;
4
5		class ApiCaller
6		{
7		private $response;
8
9		private $apiKey;
10
11	7	public function __construct(string $apiKey)
12		{
13	7	$this->apiKey = $apiKey;
14	7	}
15
16	2	public function convert($from, $to)
17		{
18		$url = 'https://free.currencyconverterapi.com'
19		. '/api/v5/convert'
20	2	. '?q=' . $from . '_' . $to
21	2	. '&compact=ultra'
22	2	. '&apiKey=' . $this->apiKey;
23
24
25	2	if ($handle = @fopen($url, 'r')) {
26		$this->response = fgets($handle, 4096);
27
28		fclose($handle);
29
30		return;
31		}
32
33	2	$errorMessage = 'Error on convert rates';
34
35	2	$errors = error_get_last();
36	2	if (isset ($errors['message'])) {
37	2	$errorMessage = $errors['message'];
38		}
39
40	2	throw new \Exception($errorMessage);
41		}
42
43	1	public function isLastCallEmpty(): bool
44		{
45	1	return $this->response == null;
46		}
47
48	1	public function getLastResponse(): ?string
49		{
50	1	return $this->response;
51		}
52		}
53

AlessandroMinoccheri / currency-converter

ApiCaller::convert() A last analyzed 2019-04-16 21:22 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ApiCaller::convert() A
last analyzed 2019-04-16 21:22 UTC