CurrencyConverter\Controller\Component\CurrencyConverterComponent

Complexity

Total Complexity

24

Size/Duplication

Total Lines	198
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

85.29%

Importance

Changes	6
Bugs	3	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	fixFromToCurrency()	0	10	3
A	insertIntoDatabase()	0	15	1
B	saveIntoDatabase()	0	26	4
A	updateDatabase()	0	15	1
B	ensureNeedToUpdateDatabase()	0	10	5
B	convert()	0	38	3
A	getRates()	0	20	4
A	ensureIfExistTable()	0	21	2
A	calculateValue()	0	5	1

<?php

namespace CurrencyConverter\Controller\Component;

use Cake\Controller\Component;
use Cake\Datasource\ConnectionManager;
use Cake\ORM\TableRegistry;
use Cake\Database\Schema\TableSchema;

class CurrencyConverterComponent extends Component
{
    private $fromCurrency;

    private $toCurrency;

    private $amount;

    private $hourDifference;

    private $saveIntoDb;

    private $dataSource;

    private $rate;

    private $currencyTable;

    /**
     * Convertion function
     *
     * @param string $fromCurrency the starting currency that user wants to convert to.
     * @param string $toCurrency the ending currency that user wants to convert to.
     * @param float $amount the amount to convert.
     * @param boolean $saveIntoDb if develop wants to store convertion rate for use it without resending data to yahoo service.
     * @param int $hourDifference the hour difference to check if the last convertion is passed, if yes make a new call to yahoo finance api.
     * @param string $dataSource which dataSOurce need to use
     * @return float the total amount converted into the new currency
     */
    public function convert(
        $fromCurrency, 
        $toCurrency, 
        $amount, 
        $saveIntoDb = true, 
        $hourDifference = 1, 
        $dataSource = 'default'
    ) {
        $this->fromCurrency = $fromCurrency;
        $this->toCurrency = $toCurrency;
        $this->amount = $amount;
        $this->saveIntoDb = $saveIntoDb;
        $this->hourDifference = $hourDifference;
        $this->dataSource = $dataSource;
        $this->rate = 0;

        if($this->fromCurrency != $this->toCurrency){
            $this->fixFromToCurrency();
            
            if($this->saveIntoDb == true){

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

                $this->currencyTable = TableRegistry::get('CurrencyConverter', [
                    'className' => 'CurrencyConverter\Model\Table\CurrencyConvertersTable',
                    'table' => 'currency_converter'
                ]);

                $this->ensureIfExistTable();
                $this->saveIntoDatabase();

                return $this->calculateValue();
            }
            
            $this->rate = $this->getRates($this->fromCurrency, $this->toCurrency);

The call to CurrencyConverterComponent::getRates() has too many arguments starting with $this->fromCurrency.

            return $this->calculateValue();
        }
        
        return number_format((double)$this->amount, 2, '.', '');
    }

    private function fixFromToCurrency()
    {
        if ($this->fromCurrency == "PDS"){
            $this->fromCurrency = "GBP";
        }

        if ($this->toCurrency == "PDS"){
            $this->toCurrency = "GBP";
        }
    }

    private function saveIntoDatabase()
    {
        $query = $this->currencyTable->find('all')
            ->where(['fromCurrency' => $this->fromCurrency, 'toCurrency' => $this->toCurrency ]);

        $query->hydrate(false);

The method Cake\ORM\Query::hydrate() has been deprecated with message: 3.4.0 Use enableHydration()/isHydrationEnabled() instead.

        $result =  $query->toArray();

        foreach ($result as $row){
            $lastUpdated = $row['modified'];

            $now = date('Y-m-d H:i:s');
            $dStart = new \DateTime($now);
            $diff = $dStart->diff($lastUpdated);

            if ($this->ensureNeedToUpdateDatabase($diff, $row)) {
                $this->updateDatabase($row);
            } else {
                $this->rate = $row['rates'];
            }
        }

        if (count($result) <= 0) {
            $this->insertIntoDatabase();
        }
    }

    private function updateDatabase($row)
    {
        $this->rate = $this->getRates($this->fromCurrency, $this->toCurrency);

The call to CurrencyConverterComponent::getRates() has too many arguments starting with $this->fromCurrency.

        $data = [
            'fromCurrency'=> $this->fromCurrency,
            'toCurrency'  => $this->toCurrency,
            'rates'       => $this->rate,
            'modified'    => date('Y-m-d H:i:s'),
        ];

        $entity = $this->currencyTable->get($row['id']); 
        $this->currencyTable->patchEntity($entity, $data);
        $this->currencyTable->save($entity);
    }

    private function insertIntoDatabase()
    {
        $this->rate = $this->getRates();

        $data = [
            'fromCurrency' => $this->fromCurrency,
            'toCurrency'   => $this->toCurrency,
            'rates'        => $this->rate,
            'created'      => date('Y-m-d H:i:s'),
            'modified'     => date('Y-m-d H:i:s'),
        ];

        $entity = $this->currencyTable->newEntity($data);
        $this->currencyTable->save($entity);
    }

    private function ensureNeedToUpdateDatabase($diff, $row)
    {
        return (
            ((int)$diff->y >= 1) || 
            ((int)$diff->m >= 1) || 
            ((int)$diff->d >= 1) || 
            ((int)$diff->h >= $this->hourDifference) || 
            ((double)$row['rates'] == 0)
        );
    }

    private function getRates(){
        $url = 'http://api.fixer.io/latest?base=' . $this->fromCurrency . '&symbols=' . $this->toCurrency;

        $handle = @fopen($url, 'r');

        if ($handle) {
            $result = fgets($handle, 4096);
            fclose($handle);
        }

        if (isset($result)) {
            $conversion = json_decode($result, true);

            if (isset($conversion['rates'][$this->toCurrency])) {
                return $conversion['rates'][$this->toCurrency];
            }
        }
        
        return $this->rate = 0;
    }

    private function ensureIfExistTable(){
        $autoIncrement = 'AUTO_INCREMENT';

        $db = ConnectionManager::get($this->dataSource);
        $config = $db->config();

        if (strpos($config['dsn'], 'sqlite') !== false) {
            $autoIncrement = 'AUTOINCREMENT';
        }

        $sql = 'CREATE TABLE IF NOT EXISTS `currency_converters` (
          `id` integer PRIMARY KEY ' . $autoIncrement . ',
          `fromCurrency` varchar(5) NOT NULL,
          `toCurrency` varchar(5) NOT NULL,
          `rates` varchar(10) NOT NULL,
          `created` datetime NOT NULL,
          `modified` datetime NOT NULL
        );';

        return $db->query($sql);
    }

    private function calculateValue()
    {
        $value = (double)$this->rate * (double)$this->amount;
        return number_format((double)$value, 2, '.', '');
    }
}