CurrencyratesTable::validationDefault() - Code Metrics - Inspection of "Refactoring, Add Helper, change convert method par..." - AlessandroMinoccheri/cakephp-currency-converter - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#14)

unknown

created 2018-11-01 19:32 UTC

CurrencyratesTable::validationDefault() A

↳ Parent: CurrencyratesTable

Complexity

Conditions	1
Paths	1

Size

Total Lines	22
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	16
nc	1
nop	1
dl	0
loc	22
ccs	13
cts	13
cp	1
crap	1
rs	9.7333
c	0
b	0
f	0

<?php

namespace CurrencyConverter\Model\Table;

use Cake\ORM\Query;
use Cake\ORM\RulesChecker;
use Cake\ORM\Table;
use Cake\ORM\Behavior\TimestampBehavior;
use Cake\Validation\Validator;

class CurrencyratesTable extends Table
{

    /**
     * Initialize method
     *
     * @param array $config The configuration for the Table.
     * @return void
     */
    public function initialize(array $config)
    {
        parent::initialize($config);

        $this->setTable('currencyrates');
        $this->setPrimaryKey('id');

        $this->addBehavior('Timestamp');
    }

    /**
     * Default validation rules.
     *
     * @param \Cake\Validation\Validator $validator Validator instance.
     * @return \Cake\Validation\Validator
     */
    public function validationDefault(Validator $validator)
    {
        $validator
            ->integer('id')
            ->allowEmpty('id', 'create');

        $validator
            ->scalar('from')
            ->maxLength('from', 5)
            ->notEmpty('from');

    	$validator
            ->scalar('to')
            ->maxLength('to', 5)
            ->notEmpty('to');

    	$validator
            ->scalar('rate')
            ->maxLength('rate', 10)
            ->notEmpty('rate');

        return $validator;
    }
}


1		<?php
2
3		namespace CurrencyConverter\Model\Table;
4
5		use Cake\ORM\Query;
6		use Cake\ORM\RulesChecker;
7		use Cake\ORM\Table;
8		use Cake\ORM\Behavior\TimestampBehavior;
9		use Cake\Validation\Validator;
10
11		class CurrencyratesTable extends Table
12		{
13
14		/**
15		* Initialize method
16		*
17		* @param array $config The configuration for the Table.
18		* @return void
19		*/
20	32	public function initialize(array $config)
21		{
22	32	parent::initialize($config);
23
24	32	$this->setTable('currencyrates');
25	32	$this->setPrimaryKey('id');
26
27	32	$this->addBehavior('Timestamp');
28	32	}
29
30		/**
31		* Default validation rules.
32		*
33		* @param \Cake\Validation\Validator $validator Validator instance.
34		* @return \Cake\Validation\Validator
35		*/
36	4	public function validationDefault(Validator $validator)
37		{
38		$validator
39	4	->integer('id')
40	4	->allowEmpty('id', 'create');
41
42		$validator
43	4	->scalar('from')
44	4	->maxLength('from', 5)
45	4	->notEmpty('from');
46
47		$validator
48	4	->scalar('to')
49	4	->maxLength('to', 5)
50	4	->notEmpty('to');
51
52		$validator
53	4	->scalar('rate')
54	4	->maxLength('rate', 10)
55	4	->notEmpty('rate');
56
57	4	return $validator;
58		}
59		}
60

AlessandroMinoccheri / cakephp-currency-converter

Pull Request — master (#14)

CurrencyratesTable::validationDefault() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like