App::__construct() - Code Metrics - Inspection of "Added some basic stuff" - Albert221/blog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1b2525...eaa10a )

by Albert

created 2016-05-09 20:34 UTC

App::__construct() A

↳ Parent: App

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	13
rs	9.4285
cc	1
eloc	8
nc	1
nop	0

<?php

namespace Albert221\Blog;

use Albert221\Blog\Controller\PostController;
use Albert221\Blog\ServiceProvider\HttpServiceProvider;
use Albert221\Blog\ServiceProvider\TwigServiceProvider;
use League\Container\Container;
use League\Container\ReflectionContainer;
use League\Route\RouteCollection;
use Zend\Diactoros\Request;
use Zend\Diactoros\Response;
use Zend\Diactoros\Response\SapiEmitter;
use Zend\Diactoros\ServerRequest;

class App
{
    /**
     * @var Container
     */
    protected $container;

    public function __construct()
    {
        $this->container = new Container;
        $this->container->delegate(new ReflectionContainer);

        $this->container->add('baseDir', dirname(__DIR__));
        
        $this->container->addServiceProvider(new HttpServiceProvider);
        $this->container->addServiceProvider(new TwigServiceProvider);

        $this->container->add(PostController::class)
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->withMethodCall('setTwig', ['twig']);
    }

    /**
     * Sends response.
     */
    public function run()
    {
        /** @var RouteCollection $route */
        $route = $this->container->get('route');
        /** @var ServerRequest $request */
        $request = $this->container->get('request');
        /** @var Response $response */
        $response = $this->container->get('response');
        /** @var SapiEmitter $emitter */
        $emitter = $this->container->get('emitter');

        $response = $route->dispatch($request, $response);

        $emitter->emit($response);
    }
}

1			<?php
2
3			namespace Albert221\Blog;
4
5			use Albert221\Blog\Controller\PostController;
6			use Albert221\Blog\ServiceProvider\HttpServiceProvider;
7			use Albert221\Blog\ServiceProvider\TwigServiceProvider;
8			use League\Container\Container;
9			use League\Container\ReflectionContainer;
10			use League\Route\RouteCollection;
11			use Zend\Diactoros\Request;
12			use Zend\Diactoros\Response;
13			use Zend\Diactoros\Response\SapiEmitter;
14			use Zend\Diactoros\ServerRequest;
15
16			class App
17			{
18			/**
19			* @var Container
20			*/
21			protected $container;
22
23			public function __construct()
24			{
25			$this->container = new Container;
26			$this->container->delegate(new ReflectionContainer);
27
28			$this->container->add('baseDir', dirname(__DIR__));
29
30			$this->container->addServiceProvider(new HttpServiceProvider);
31			$this->container->addServiceProvider(new TwigServiceProvider);
32
33			$this->container->add(PostController::class)
			0 ignored issues – show Bug introduced 2016-05-09 20:45 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `League\Container\Definition\DefinitionInterface` as the method `withMethodCall()` does only exist in the following implementations of said interface: `League\Container\Definition\ClassDefinition`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
34			->withMethodCall('setTwig', ['twig']);
35			}
36
37			/**
38			* Sends response.
39			*/
40			public function run()
41			{
42			/** @var RouteCollection $route */
43			$route = $this->container->get('route');
44			/** @var ServerRequest $request */
45			$request = $this->container->get('request');
46			/** @var Response $response */
47			$response = $this->container->get('response');
48			/** @var SapiEmitter $emitter */
49			$emitter = $this->container->get('emitter');
50
51			$response = $route->dispatch($request, $response);
52
53			$emitter->emit($response);
54			}
55			}

Albert221 / blog

Push — master ( 1b2525...eaa10a )

App::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like