Issues in Events.php (master) - Issues in master - Aggrego/EventConsumer - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2)

src/Shared/Events.php (1 issue)

Labels

Bug 1

Severity

Major 1

<?php
/**
 *
 * This file is part of the Aggrego.
 * (c) Tomasz Kunicki <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 */

declare(strict_types = 1);

namespace Aggrego\EventConsumer\Shared;

use Aggrego\EventConsumer\Event;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use ArrayIterator;
use Iterator;
use IteratorAggregate;

class Events implements IteratorAggregate
{
    /**
     * @var array
     */
    private $list;

    public function __construct()
    {
        $this->list = [];
    }

    public function add(Event $event)
    {
        $this->list[] = $event;
    }

    public function getIterator(): Iterator
    {
        return new ArrayIterator($this->list);
    }
}


1			<?php
2			/**
3			*
4			* This file is part of the Aggrego.
5			* (c) Tomasz Kunicki <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*
10			*/
11
12			declare(strict_types = 1);
13
14			namespace Aggrego\EventConsumer\Shared;
15
16			use Aggrego\EventConsumer\Event;
			0 ignored issues – show Bug introduced 2018-12-20 15:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Aggrego\EventConsumer\Shared\Event`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
17			use ArrayIterator;
18			use Iterator;
19			use IteratorAggregate;
20
21			class Events implements IteratorAggregate
22			{
23			/**
24			* @var array
25			*/
26			private $list;
27
28			public function __construct()
29			{
30			$this->list = [];
31			}
32
33			public function add(Event $event)
34			{
35			$this->list[] = $event;
36			}
37
38			public function getIterator(): Iterator
39			{
40			return new ArrayIterator($this->list);
41			}
42			}
43

Aggrego / EventConsumer

Issues (2)

src/Shared/Events.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like