Collection::replace() - Code Metrics - Inspection of "partial refactor - change concept" - Aggrego/Domain - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2ee0d1...1e8995 )

by Tomasz

created 2018-08-08 19:14 UTC

Collection::replace() A

↳ Parent: Collection

Complexity

Conditions	5
Paths	4

Size

Total Lines	23
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	16
nc	4
nop	1
dl	0
loc	23
rs	9.4222
c	0
b	0
f	0

<?php

declare(strict_types = 1);

namespace Aggrego\Domain\Model\ProgressiveBoard\Shard;

use Aggrego\Domain\Model\ProgressiveBoard\Exception\InvalidUuidComparisonOnReplaceException;
use Assert\Assertion;
use Countable;

class Collection implements Countable
{
    /** @var Item[] */
    private $list;

    public function __construct(array $list)
    {
        Assertion::allIsInstanceOf($list, InitialItem::class);
    }

    public function replace(FinalItem $finalShard): void
    {
        /** @var Item $shard */
        $list = $this->list;
        $listUuid = [];
        foreach ($list as $key => $shard) {
            if ($shard instanceof FinalItem) {
                continue;
            }
            $listUuid[] = $shard->getUuid()->getValue();
            if ($shard->getUuid()->equal($finalShard->getUuid())
                && $shard->getProfile()->equal($finalShard->getProfile())) {
                $list[$key] = $finalShard;
                $this->list = $list;
                return;
            }
        }

        throw new InvalidUuidComparisonOnReplaceException(
            sprintf(
                'Could not find initial shard by uuid %s in given collection: %s',
                $finalShard->getUuid()->getValue(),
                join(',', $listUuid)
            )
        );
    }

    public function count(): int
    {
        return count($this->list);
    }

    public function isAllShardsFinishedProgress(): bool
    {
        foreach ($this as $shard) {
            if ($shard instanceof InitialItem) {
                return false;
            }
        }
        return true;
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			namespace Aggrego\Domain\Model\ProgressiveBoard\Shard;
6
7			use Aggrego\Domain\Model\ProgressiveBoard\Exception\InvalidUuidComparisonOnReplaceException;
8			use Assert\Assertion;
9			use Countable;
10
11			class Collection implements Countable
12			{
13			/** @var Item[] */
14			private $list;
15
16			public function __construct(array $list)
17			{
18			Assertion::allIsInstanceOf($list, InitialItem::class);
19			}
20
21			public function replace(FinalItem $finalShard): void
22			{
23			/** @var Item $shard */
24			$list = $this->list;
25			$listUuid = [];
26			foreach ($list as $key => $shard) {
27			if ($shard instanceof FinalItem) {
28			continue;
29			}
30			$listUuid[] = $shard->getUuid()->getValue();
31			if ($shard->getUuid()->equal($finalShard->getUuid())
32			&& $shard->getProfile()->equal($finalShard->getProfile())) {
33			$list[$key] = $finalShard;
34			$this->list = $list;
35			return;
36			}
37			}
38
39			throw new InvalidUuidComparisonOnReplaceException(
40			sprintf(
41			'Could not find initial shard by uuid %s in given collection: %s',
42			$finalShard->getUuid()->getValue(),
43			join(',', $listUuid)
44			)
45			);
46			}
47
48			public function count(): int
49			{
50			return count($this->list);
51			}
52
53			public function isAllShardsFinishedProgress(): bool
54			{
55			foreach ($this as $shard) {
56			if ($shard instanceof InitialItem) {
57			return false;
58			}
59			}
60			return true;
61			}
62			}
63

Aggrego / Domain

Push — master ( 2ee0d1...1e8995 )

Collection::replace() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like