DocLister\Tests\ModxAbstract

Complexity

Total Complexity

3

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	mockMODX()	0	60	1
A	mockDBAPI()	0	19	1
A	setUp()	0	5	1

<?php namespace DocLister\Tests;


abstract class ModxAbstract extends TestAbstract

{

    protected $modx = null;


    public function setUp()

    {

        $this->modx = $this->mockMODX();

        $this->assertTrue($this->modx instanceof \DocumentParser);

        $this->assertTrue($this->modx->db instanceof \DBAPI);

Accessing db on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

The type DBAPI was not found. Maybe you did not declare it correctly or list all dependencies?

    }


    protected function mockDBAPI()

    {

        $DBAPI = $this->getMockBuilder('DBAPI')

            ->setMethods(array('query', 'makeArray', 'escape', 'getValue'))

            ->getMock();


        $DBAPI->expects($this->any())

            ->method('makeArray')

            ->will($this->returnValue(array()));


        $DBAPI->expects($this->any())

            ->method('escape')

            ->will($this->returnArgument(0));


        $DBAPI->expects($this->any())

            ->method('getValue')

            ->will($this->returnValue('db_value'));


        return $DBAPI;

    }


    protected function mockMODX(array $config = array())

    {

        $modx = $this->getMockBuilder('DocumentParser')

            ->setMethods(array('getFullTableName'))

            ->getMock();


        $modx->expects($this->any())

            ->method('getFullTableName')

            ->will($this->returnArgument(0));


        $modx->db = $this->mockDBAPI();

Accessing db on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $modx->documentObject = array(

Accessing documentObject on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

            'id'              => 1,

            'type'            => 'document',

            'contentType'     => 'text/html',

            'pagetitle'       => 'New document',

            'longtitle'       => '',

            'description'     => '',

            'alias'           => '',

            'link_attributes' => '',

            'published'       => 1,

            'pub_date'        => 0,

            'unpub_date'      => 0,

            'parent'          => 0,

            'isfolder'        => 0,

            'introtext'       => '',

            'content'         => '',

            'richtext'        => 1,

            'template'        => 0,

            'menuindex'       => 0,

            'searchable'      => 1,

            'cacheable'       => 1,

            'createdon'       => 0,

            'createdby'       => 0,

            'editedon'        => 0,

            'editedby'        => 0,

            'deleted'         => 0,

            'deletedon'       => 0,

            'deletedby'       => 0,

            'publishedon'     => 0,

            'publishedby'     => 0,

            'menutitle'       => '',

            'donthit'         => 0,

            'haskeywords'     => 0,

            'hasmetatags'     => 0,

            'privateweb'      => 0,

            'privatemgr'      => 0,

            'content_dispo'   => 0,

            'hidemenu'        => 0,

            'alias_visible'   => 1

        );

        $modx->documentIdentifier = 1;

Accessing documentIdentifier on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $modx->config = array_merge(array(

Accessing config on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

            'manager_language' => 'russian-UTF8',

            'site_start'       => 1,

            'site_url'         => 'http://example.com/',

        ), $config);


        return $modx;


    }

}