site_contentDocLister::getChildrenCount()

Complexity

Conditions	22
Paths	8450

Size

Total Lines	86
Code Lines	63

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	52
CRAP Score	27.4325

Importance

Changes	9
Bugs	3	Features	0

<?php
    public function getChildrenCount()

Function's nesting level (7) exceeds allowed maximum of 6

    {
        $out = $this->extCache->load('childrenCount');

The method load() does not exist on null.

The method load() does not exist on xNop. Since you implemented __call, consider adding a @method annotation.

        if ($out === false) {

The condition $out === false is always false.

            $out = 0;
            $sanitarInIDs = $this->sanitarIn($this->IDs);
            if ($sanitarInIDs != "''" || $this->getCFGDef('ignoreEmpty', '0')) {
                $q_true = $this->getCFGDef('ignoreEmpty', '0');
                $q_true = $q_true ? $q_true : $this->getCFGDef('idType', 'parents') == 'parents';
                $where = $this->getCFGDef('addWhereList', '');
                $where = sqlHelper::trimLogicalOp($where);
                $where = ($where ? $where . ' AND ' : '') . $this->_filters['where'];
                if ($where != '' && $this->_filters['where'] != '') {
                    $where .= " AND ";
                }
                $where = sqlHelper::trimLogicalOp($where);

                $where = "WHERE {$where}";
                $whereArr = array();
                if (!$this->getCFGDef('showNoPublish', 0)) {

Expected 1 space after NOT operator; 0 found

                    $whereArr[] = "c.deleted=0 AND c.published=1";
                } else {
                    $q_true = 1;
                }

                $tbl_site_content = $this->getTable('site_content', 'c');

                if ($sanitarInIDs != "''") {
                    switch ($this->getCFGDef('idType', 'parents')) {
                        case 'parents':
                            switch ($this->getCFGDef('showParent', '0')) {
                                case '-1':
                                    $tmpWhere = "c.parent IN (" . $sanitarInIDs . ")";
                                    break;
                                case 0:
                                    $tmpWhere = "c.parent IN ({$sanitarInIDs}) AND c.id NOT IN({$sanitarInIDs})";
                                    break;
                                case 1:
                                default:
                                    $tmpWhere = "(c.parent IN ({$sanitarInIDs}) OR c.id IN({$sanitarInIDs}))";
                                    break;
                            }
                            if (($addDocs = $this->getCFGDef('documents', '')) != '') {
                                $addDocs = $this->sanitarIn($this->cleanIDs($addDocs));
                                $whereArr[] = "((" . $tmpWhere . ") OR c.id IN({$addDocs}))";
                            } else {
                                $whereArr[] = $tmpWhere;
                            }

                            break;
                        case 'documents':
                            $whereArr[] = "c.id IN({$sanitarInIDs})";
                            break;
                    }
                }
                $from = $tbl_site_content . " " . $this->_filters['join'];
                $where = sqlHelper::trimLogicalOp($where);

                $q_true = $q_true ? $q_true : trim($where) != 'WHERE';

                if (trim($where) != 'WHERE') {
                    $where .= " AND ";
                }

                $where .= implode(" AND ", $whereArr);
                $where = sqlHelper::trimLogicalOp($where);

                if (trim($where) == 'WHERE') {
                    $where = '';
                }
                $group = $this->getGroupSQL($this->getCFGDef('groupBy', $this->getPK()));

                $q_true = $q_true ? $q_true : $group != '';
                if ($q_true) {
                    $maxDocs = $this->getCFGDef('maxDocs', 0);
                    $limit = $maxDocs > 0 ? $this->LimitSQL($this->getCFGDef('maxDocs', 0)) : '';
                    $rs = $this->dbQuery("SELECT count(*) FROM (SELECT count(*) FROM {$from} {$where} {$group} {$limit}) as `tmp`");
                    $out = $this->modx->db->getValue($rs);
                } else {
                    $out = count($this->IDs);
                }
            }
            $this->extCache->save($out, 'childrenCount');
        }

        return $out;

The expression return $out returns the type string which is incompatible with the return type mandated by DocLister::getChildrenCount() of integer.

    }