save - Code Metrics - Inspection of "0.9.13.1" - AesopInteractive/lasso - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c43eec...2d99df )

unknown

created 2016-12-27 18:23 UTC

save A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	160
Duplicated Lines	30 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
dl	48
loc	160
rs	10
c	1
b	1
f	0
wmc	12
lcom	1
cbo	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	content()	25	25	3
A	publish_content()	23	23	3
A	params()	0	13	1
A	auth_callbacks()	0	10	1
A	save_to_post_disables()	0	6	1
A	replace_rendered_shortcodes()	0	18	2
A	remove_comments()	0	3	1

How to fix Duplicated Code

<?php
/**
 * Main class responsible for saving the post object
 *
 * @since 1.0
 */
namespace lasso\process;

use lasso\internal_api\api_action;

class save implements api_action {
	
	/**
	 * Process the post save
	 *
	 * @since 0.9.2
	 *
	 * @param array $data Sanitized data to use for saving.
	 *
	 * @return bool Always returns true.
	 */
	public function content( $data ) {


		$save_to_post_disabled = $this->save_to_post_disables();

		$postid = (int) $data[ 'post_id' ];
		$content = $this->replace_rendered_shortcodes( $data[ 'content' ] );
		$content = $this->remove_comments( $content );

		if ( 'off' == $save_to_post_disabled || empty( $save_to_post_disabled ) ) {

			$args = array(
				'ID'           => (int) $postid,
				'post_content' => $content
			);

			wp_update_post( apply_filters( 'lasso_object_save_args', $args ) );

		}

		// run save action
		do_action( 'lasso_post_saved', $postid, $content, get_current_user_ID() );

		return true;

	}

	/**
	 * Process the post save
	 *
	 * @since 0.9.2
	 *
	 * @param array $data Sanitized data to use for saving.
	 *
	 * @return bool Always returns true.
	 */
	public function publish_content( $data ) {

		$save_to_post_disabled = $this->save_to_post_disables();

		$postid = (int) $data[ 'post_id' ];
		$content = $this->replace_rendered_shortcodes( $data[ 'content' ] );
		$content = $this->remove_comments( $content );

		if ( 'off' == $save_to_post_disabled || empty( $save_to_post_disabled ) ) {

			$args = array (
				'ID'           	=> $postid,
				'post_content' 	=> $content,
				'post_status' 	=> 'publish'
			);
			wp_update_post( apply_filters( 'lasso_object_publish_args', $args ) );

		}

		do_action( 'lasso_post_published', $postid, $content, get_current_user_ID() );

		return true;

	}

	/**
	 * The keys required for the actions of this class.
	 *
	 * @since     0.9.2
	 *
	 * @return array Array of keys to pull from $_POST per action and their sanitization callback
	 */
	public static function params(){
		$params[ 'process_save_content' ] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'post_id' => 'absint',
			'content' => 'wp_kses_post'
		);

		$params[ 'process_save_publish_content' ] = array(
			'post_id' => 'absint',
			'content' => 'wp_kses_post'
		);

		return $params;
	}

	/**
	 * Additional auth callbacks to check.
	 *
	 * @since     0.9.2
	 *
	 * @return array Array of additional functions to use to authorize action.
	 */
	public static function auth_callbacks() {
		$params[ 'process_save_content' ] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'lasso_user_can'
		);

		$params[ 'process_save_publish_content' ] = array();

		return $params;

	}

	/**
	 * Check if saving post is disabled.
	 *
	 * @since 0.9.2
	 *
	 * @access protected
	 *
	 * @return bool
	 */
	protected function save_to_post_disables() {
		$save_to_post_disabled = lasso_editor_get_option( 'post_save_disabled', 'lasso_editor' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		return $save_to_post_disabled;

	}

	/**
	 * Replace shortcodes from other plugins with shortcode tags.
	 *
	 * @since 0.9.9
	 *
	 * @access protected
	 *
	 * @param string $content
	 *
	 * @return string
	 */
	protected function replace_rendered_shortcodes( $content ) {
		//debug line
        //file_put_contents(WP_PLUGIN_DIR."/file1.txt", $content);

		

		if ( false === strpos( $content, '--EDITUS_OTHER_SHORTCODE_START|' ) ) {
			return $content;
		}
		$content = htmlspecialchars_decode ($content);

		$content = preg_replace(
			'/<!--EDITUS_OTHER_SHORTCODE_START\|\[(.*?)\]-->(.*?)<!--EDITUS_OTHER_SHORTCODE_END-->/s',
			'$1',
			$content
		);

		return $content;
	}
	
	protected function remove_comments($content) {
		return preg_replace('/<!--(.*)-->/Uis', '', $content);
	}

}


1		<?php
2		/**
3		* Main class responsible for saving the post object
4		*
5		* @since 1.0
6		*/
7		namespace lasso\process;
8
9		use lasso\internal_api\api_action;
10
11		class save implements api_action {
12
13		/**
14		* Process the post save
15		*
16		* @since 0.9.2
17		*
18		* @param array $data Sanitized data to use for saving.
19		*
20		* @return bool Always returns true.
21		*/
22	View Code Duplication	public function content( $data ) {
		0 ignored issues – show Duplication introduced 2015-11-30 19:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23
24		$save_to_post_disabled = $this->save_to_post_disables();
25
26		$postid = (int) $data[ 'post_id' ];
27		$content = $this->replace_rendered_shortcodes( $data[ 'content' ] );
28		$content = $this->remove_comments( $content );
29
30		if ( 'off' == $save_to_post_disabled \|\| empty( $save_to_post_disabled ) ) {
31
32		$args = array(
33		'ID' => (int) $postid,
34		'post_content' => $content
35		);
36
37		wp_update_post( apply_filters( 'lasso_object_save_args', $args ) );
38
39		}
40
41		// run save action
42		do_action( 'lasso_post_saved', $postid, $content, get_current_user_ID() );
43
44		return true;
45
46		}
47
48		/**
49		* Process the post save
50		*
51		* @since 0.9.2
52		*
53		* @param array $data Sanitized data to use for saving.
54		*
55		* @return bool Always returns true.
56		*/
57	View Code Duplication	public function publish_content( $data ) {
		0 ignored issues – show Duplication introduced 2015-11-30 19:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		$save_to_post_disabled = $this->save_to_post_disables();
59
60		$postid = (int) $data[ 'post_id' ];
61		$content = $this->replace_rendered_shortcodes( $data[ 'content' ] );
62		$content = $this->remove_comments( $content );
63
64		if ( 'off' == $save_to_post_disabled \|\| empty( $save_to_post_disabled ) ) {
65
66		$args = array (
67		'ID' => $postid,
68		'post_content' => $content,
69		'post_status' => 'publish'
70		);
71		wp_update_post( apply_filters( 'lasso_object_publish_args', $args ) );
72
73		}
74
75		do_action( 'lasso_post_published', $postid, $content, get_current_user_ID() );
76
77		return true;
78
79		}
80
81		/**
82		* The keys required for the actions of this class.
83		*
84		* @since 0.9.2
85		*
86		* @return array Array of keys to pull from $_POST per action and their sanitization callback
87		*/
88		public static function params(){
89		$params[ 'process_save_content' ] = array(
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-30 19:10 UTC by Report Bug Copy Issue Report `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
90		'post_id' => 'absint',
91		'content' => 'wp_kses_post'
92		);
93
94		$params[ 'process_save_publish_content' ] = array(
95		'post_id' => 'absint',
96		'content' => 'wp_kses_post'
97		);
98
99		return $params;
100		}
101
102		/**
103		* Additional auth callbacks to check.
104		*
105		* @since 0.9.2
106		*
107		* @return array Array of additional functions to use to authorize action.
108		*/
109		public static function auth_callbacks() {
110		$params[ 'process_save_content' ] = array(
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-30 19:10 UTC by Report Bug Copy Issue Report `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
111		'lasso_user_can'
112		);
113
114		$params[ 'process_save_publish_content' ] = array();
115
116		return $params;
117
118		}
119
120		/**
121		* Check if saving post is disabled.
122		*
123		* @since 0.9.2
124		*
125		* @access protected
126		*
127		* @return bool
128		*/
129		protected function save_to_post_disables() {
130		$save_to_post_disabled = lasso_editor_get_option( 'post_save_disabled', 'lasso_editor' );
		0 ignored issues – show Documentation introduced 2015-11-30 19:10 UTC by Report Bug Copy Issue Report `'post_save_disabled'` is of type `string`, but the function expects a `object<unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2015-11-30 19:10 UTC by Report Bug Copy Issue Report `'lasso_editor'` is of type `string`, but the function expects a `object<unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
131
132		return $save_to_post_disabled;
133
134		}
135
136		/**
137		* Replace shortcodes from other plugins with shortcode tags.
138		*
139		* @since 0.9.9
140		*
141		* @access protected
142		*
143		* @param string $content
144		*
145		* @return string
146		*/
147		protected function replace_rendered_shortcodes( $content ) {
148		//debug line
149		//file_put_contents(WP_PLUGIN_DIR."/file1.txt", $content);
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-12-27 18:25 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
150
151
152		if ( false === strpos( $content, '--EDITUS_OTHER_SHORTCODE_START\|' ) ) {
153		return $content;
154		}
155		$content = htmlspecialchars_decode ($content);
156
157		$content = preg_replace(
158		'/<!--EDITUS_OTHER_SHORTCODE_START\\|\[(.?)\]-->(.?)<!--EDITUS_OTHER_SHORTCODE_END-->/s',
159		'$1',
160		$content
161		);
162
163		return $content;
164		}
165
166		protected function remove_comments($content) {
167		return preg_replace('/<!--(.*)-->/Uis', '', $content);
168		}
169
170		}
171

AesopInteractive / lasso

Push — master ( c43eec...2d99df )

save A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like