lasso.php ➔ lasso_show_in_rest() - Code Metrics - Inspection of "show the custom post in rest api" - AesopInteractive/lasso - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7bcb93...eac623 )

unknown

created 2017-06-29 13:00 UTC

lasso.php ➔ lasso_show_in_rest() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	8
nc	3
nop	0
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0

<?php

/**
 *
 *
 * @package   Editus
 * @author    Hyun Supul <[email protected]>, Nick Haskins <[email protected]>
 * @link      http://edituswp.com
 * @copyright 2015-2017 Aesopinteractive 
 *
 * Plugin Name:       Editus
 * Plugin URI:        http://edituswp.com
 * Description:       Front-end editor and story builder.
 * Version:           0.9.15.0
 * Author:            Aesopinteractive 
 * Author URI:        http://aesopinteractive.com
 * Text Domain:       lasso
 * Domain Path:       /languages
 */

// If this file is called directly, abort.
if ( ! defined( 'WPINC' ) ) {
	die;
}

// Set some constants
define( 'LASSO_VERSION', '0.9.15.0' );
define( 'LASSO_DIR', plugin_dir_path( __FILE__ ) );
define( 'LASSO_URL', plugins_url( '', __FILE__ ) );
define( 'LASSO_FILE', __FILE__ );

/**
 * Load plugin if PHP version is 5.4 or later.
 */
if ( version_compare( PHP_VERSION, '5.4.0', '>=' ) ) {

	include_once( LASSO_DIR . '/bootstrap.php' );

} else {

	add_action('admin_head', 'lasso_fail_notice');
	function lasso_fail_notice(){

		printf('<div class="error"><p>Lasso requires PHP 5.4 or higher.</p></div>');

	}
}

function lasso_show_in_rest() {
	global $wp_post_types;
function myFunction($a, $b) {
    // Do something
}
	
	$allowed_post_types = lasso_editor_get_option( 'allowed_post_types', 'lasso_editor', array( ) );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	$allowed_post_types = apply_filters( 'lasso_allowed_post_types', $allowed_post_types );
	
	foreach( $allowed_post_types as $key ) {
	    
		// If the post type doesn't exist, skip it
		if( !$wp_post_types[$key] )
			continue;
	    	
    	$wp_post_types[$key]->show_in_rest = true;
    }
}

 add_action( 'init', 'lasso_show_in_rest' );



Push — master ( 7bcb93...eac623 )

lasso.php ➔ lasso_show_in_rest() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-05-02 20:19 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 26 and the first side effect is on line 40. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			*
4			*
5			* @package Editus
6			* @author Hyun Supul <[email protected]>, Nick Haskins <[email protected]>
7			* @link http://edituswp.com
8			* @copyright 2015-2017 Aesopinteractive
9			*
10			* Plugin Name: Editus
11			* Plugin URI: http://edituswp.com
12			* Description: Front-end editor and story builder.
13			* Version: 0.9.15.0
14			* Author: Aesopinteractive
15			* Author URI: http://aesopinteractive.com
16			* Text Domain: lasso
17			* Domain Path: /languages
18			*/
19
20			// If this file is called directly, abort.
21			if ( ! defined( 'WPINC' ) ) {
22			die;
23			}
24
25			// Set some constants
26			define( 'LASSO_VERSION', '0.9.15.0' );
27			define( 'LASSO_DIR', plugin_dir_path( __FILE__ ) );
28			define( 'LASSO_URL', plugins_url( '', __FILE__ ) );
29			define( 'LASSO_FILE', __FILE__ );
30
31			/**
32			* Load plugin if PHP version is 5.4 or later.
33			*/
34			if ( version_compare( PHP_VERSION, '5.4.0', '>=' ) ) {
35
36			include_once( LASSO_DIR . '/bootstrap.php' );
37
38			} else {
39
40			add_action('admin_head', 'lasso_fail_notice');
41			function lasso_fail_notice(){
42
43			printf('<div class="error"><p>Lasso requires PHP 5.4 or higher.</p></div>');
44
45			}
46			}
47
48			function lasso_show_in_rest() {
49			global $wp_post_types;
			0 ignored issues – show Compatibility Best Practice introduced 2017-06-29 13:02 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
50
51			$allowed_post_types = lasso_editor_get_option( 'allowed_post_types', 'lasso_editor', array( ) );
			0 ignored issues – show Documentation introduced 2017-05-29 12:59 UTC by Report Bug Copy Issue Report `'allowed_post_types'` is of type `string`, but the function expects a `object<unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-05-29 12:59 UTC by Report Bug Copy Issue Report `'lasso_editor'` is of type `string`, but the function expects a `object<unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-06-29 13:02 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `string\|object<unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52			$allowed_post_types = apply_filters( 'lasso_allowed_post_types', $allowed_post_types );
53
54			foreach( $allowed_post_types as $key ) {
55
56			// If the post type doesn't exist, skip it
57			if( !$wp_post_types[$key] )
58			continue;
59
60			$wp_post_types[$key]->show_in_rest = true;
61			}
62			}
63
64			add_action( 'init', 'lasso_show_in_rest' );
65
66

AesopInteractive / lasso

Push — master ( 7bcb93...eac623 )

lasso.php ➔ lasso_show_in_rest() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like