Inspection of "Moved the ajax code to change post settings" - AesopInteractive/lasso - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00e978...fa1de1 )

unknown

created 2017-12-24 02:16 UTC

Status

Indentation +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -261,14 +261,14 @@  discard block
 block discarded – undo
 		$out = load_textdomain( $domain, trailingslashit( LASSO_DIR ). 'languages/' . $domain . '-' . $locale . '.mo' );
 	}
 	
-    // new ajax function to lock post for editing
+	// new ajax function to lock post for editing
 	public function editus_lock_post()
 	{
 		$post_id= $_POST["postid"];
 		$locked = wp_check_post_lock($post_id);
 		
 		if (!$locked) {
-		    wp_set_post_lock($post_id);
+			wp_set_post_lock($post_id);
 			echo "true";
 		} else {
 			$user_info = get_userdata($locked);
@@ -365,59 +365,59 @@  discard block
 block discarded – undo
 		 );
 		foreach ($_POST as $key => $value) {
 			if ($key !="code" && $key !="action") {
-			    //$shortcode = $shortcode.$key.'="'.$value.'" ';
+				//$shortcode = $shortcode.$key.'="'.$value.'" ';
 				$atts[$key] = $value;
 			}
 		}
 		if ($code == "aesop_video") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-video.php');
-		    echo aesop_video_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-video.php');
+			echo aesop_video_shortcode($atts);
 		}
 		else if ($code == "aesop_image") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
-		    echo aesop_image_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
+			echo aesop_image_shortcode($atts);
 		}
 		else if ($code == "aesop_quote") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
-		    echo aesop_quote_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
+			echo aesop_quote_shortcode($atts);
 		}
 		else if ($code == "aesop_parallax") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
-		    echo aesop_parallax_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
+			echo aesop_parallax_shortcode($atts);
 		}
 		else if ($code == "aesop_character") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
-		    echo aesop_character_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
+			echo aesop_character_shortcode($atts);
 		}
 		else if ($code == "aesop_collection") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-collections.php');
-		    echo aesop_collection_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-collections.php');
+			echo aesop_collection_shortcode($atts);
 		}
 		else if ($code == "aesop_chapter") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
-		    echo aesop_chapter_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
+			echo aesop_chapter_shortcode($atts);
 		}
 		else if ($code == "aesop_content") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-cbox.php');
-		    echo aesop_content_shortcode($atts, $atts['content_data']);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-cbox.php');
+			echo aesop_content_shortcode($atts, $atts['content_data']);
 		}
 		else if ($code == "aesop_gallery") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
-		    echo do_shortcode( '[aesop_gallery id="'.$atts["id"].'"]');
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
+			echo do_shortcode( '[aesop_gallery id="'.$atts["id"].'"]');
 		}
 		else if ($code == "aesop_audio") {
-		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-audio.php');
-		    echo aesop_audio_shortcode($atts);
+			require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-audio.php');
+			echo aesop_audio_shortcode($atts);
 		}
 		else {
 			$code = '['.$code.' ';
 			foreach ($atts as $key => $value) {
-			    $code = ''.$key.'="'.$value.'" ';
+				$code = ''.$key.'="'.$value.'" ';
 			}
 			$code = $code.']';
 			echo do_shortcode($code);
-		    //require_once( ABSPATH . '/wp-content/plugins/aesop-events/public/includes/shortcode.php');
-		    //echo aesop_audio_shortcode($atts);
+			//require_once( ABSPATH . '/wp-content/plugins/aesop-events/public/includes/shortcode.php');
+			//echo aesop_audio_shortcode($atts);
 		}
 		
 		exit; 
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
 			$value = explode( ',', $value );
 			
 			if ($taxonomy =='category') {
-                // convert from names to category ids
+				// convert from names to category ids
 				$cats = array();
 				foreach ($value as $cat) {
 					$cats [] = get_cat_ID($cat);
@@ -451,7 +451,7 @@  discard block
 block discarded – undo
 	
 	public function set_date( $postid, $value) {
 		if( $value ) {
-            wp_update_post(
+			wp_update_post(
 				array (
 					'ID'            => $postid, // ID of the post to update
 					'post_date'     => date( 'Y-m-d H:i:s',  strtotime($value) ),

Please login to merge, or discard this patch.

Braces +12 added lines, -23 removed lines patch added patch discarded remove patch

@@ -372,44 +372,34 @@  discard block
 block discarded – undo
 		if ($code == "aesop_video") {
 		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-video.php');
 		    echo aesop_video_shortcode($atts);
-		}
-		else if ($code == "aesop_image") {
+		} else if ($code == "aesop_image") {
 		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
 		    echo aesop_image_shortcode($atts);
-		}
-		else if ($code == "aesop_quote") {
+		} else if ($code == "aesop_quote") {
 		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
 		    echo aesop_quote_shortcode($atts);
-		}
-		else if ($code == "aesop_parallax") {
+		} else if ($code == "aesop_parallax") {
 		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
 		    echo aesop_parallax_shortcode($atts);
-		}
-		else if ($code == "aesop_character") {
+		} else if ($code == "aesop_character") {
 		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
 		    echo aesop_character_shortcode($atts);
-		}
-		else if ($code == "aesop_collection") {
+		} else if ($code == "aesop_collection") {
 		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-collections.php');
 		    echo aesop_collection_shortcode($atts);
-		}
-		else if ($code == "aesop_chapter") {
+		} else if ($code == "aesop_chapter") {
 		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
 		    echo aesop_chapter_shortcode($atts);
-		}
-		else if ($code == "aesop_content") {
+		} else if ($code == "aesop_content") {
 		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-cbox.php');
 		    echo aesop_content_shortcode($atts, $atts['content_data']);
-		}
-		else if ($code == "aesop_gallery") {
+		} else if ($code == "aesop_gallery") {
 		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
 		    echo do_shortcode( '[aesop_gallery id="'.$atts["id"].'"]');
-		}
-		else if ($code == "aesop_audio") {
+		} else if ($code == "aesop_audio") {
 		    require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-audio.php');
 		    echo aesop_audio_shortcode($atts);
-		}
-		else {
+		} else {
 			$code = '['.$code.' ';
 			foreach ($atts as $key => $value) {
 			    $code = ''.$key.'="'.$value.'" ';
@@ -436,15 +426,14 @@  discard block
 block discarded – undo
 			}
 	
 			$result = wp_set_object_terms( $postid, $value, $taxonomy );
-		}
-		else  {
+		} else  {
 			//remove all terms from post
 			$result = wp_set_object_terms( $postid, null, $taxonomy );
 		}
 
 		if ( ! is_wp_error( $result ) ) {
 			return true;
-		}else{
+		} else{
 			return false;
 		}
 	}

Please login to merge, or discard this patch.

		@@ -261,14 +261,14 @@ discard block
		block discarded – undo
261	261	$out = load_textdomain( $domain, trailingslashit( LASSO_DIR ). 'languages/' . $domain . '-' . $locale . '.mo' );
262	262	}
263	263
264		- // new ajax function to lock post for editing
	264	+ // new ajax function to lock post for editing
265	265	public function editus_lock_post()
266	266	{
267	267	$post_id= $_POST["postid"];
268	268	$locked = wp_check_post_lock($post_id);
269	269
270	270	if (!$locked) {
271		- wp_set_post_lock($post_id);
	271	+ wp_set_post_lock($post_id);
272	272	echo "true";
273	273	} else {
274	274	$user_info = get_userdata($locked);
		@@ -365,59 +365,59 @@ discard block
		block discarded – undo
365	365	);
366	366	foreach ($_POST as $key => $value) {
367	367	if ($key !="code" && $key !="action") {
368		- //$shortcode = $shortcode.$key.'="'.$value.'" ';
	368	+ //$shortcode = $shortcode.$key.'="'.$value.'" ';
369	369	$atts[$key] = $value;
370	370	}
371	371	}
372	372	if ($code == "aesop_video") {
373		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-video.php');
374		- echo aesop_video_shortcode($atts);
	373	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-video.php');
	374	+ echo aesop_video_shortcode($atts);
375	375	}
376	376	else if ($code == "aesop_image") {
377		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
378		- echo aesop_image_shortcode($atts);
	377	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
	378	+ echo aesop_image_shortcode($atts);
379	379	}
380	380	else if ($code == "aesop_quote") {
381		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
382		- echo aesop_quote_shortcode($atts);
	381	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
	382	+ echo aesop_quote_shortcode($atts);
383	383	}
384	384	else if ($code == "aesop_parallax") {
385		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
386		- echo aesop_parallax_shortcode($atts);
	385	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
	386	+ echo aesop_parallax_shortcode($atts);
387	387	}
388	388	else if ($code == "aesop_character") {
389		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
390		- echo aesop_character_shortcode($atts);
	389	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
	390	+ echo aesop_character_shortcode($atts);
391	391	}
392	392	else if ($code == "aesop_collection") {
393		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-collections.php');
394		- echo aesop_collection_shortcode($atts);
	393	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-collections.php');
	394	+ echo aesop_collection_shortcode($atts);
395	395	}
396	396	else if ($code == "aesop_chapter") {
397		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
398		- echo aesop_chapter_shortcode($atts);
	397	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
	398	+ echo aesop_chapter_shortcode($atts);
399	399	}
400	400	else if ($code == "aesop_content") {
401		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-cbox.php');
402		- echo aesop_content_shortcode($atts, $atts['content_data']);
	401	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-cbox.php');
	402	+ echo aesop_content_shortcode($atts, $atts['content_data']);
403	403	}
404	404	else if ($code == "aesop_gallery") {
405		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
406		- echo do_shortcode( '[aesop_gallery id="'.$atts["id"].'"]');
	405	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
	406	+ echo do_shortcode( '[aesop_gallery id="'.$atts["id"].'"]');
407	407	}
408	408	else if ($code == "aesop_audio") {
409		- require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-audio.php');
410		- echo aesop_audio_shortcode($atts);
	409	+ require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-audio.php');
	410	+ echo aesop_audio_shortcode($atts);
411	411	}
412	412	else {
413	413	$code = '['.$code.' ';
414	414	foreach ($atts as $key => $value) {
415		- $code = ''.$key.'="'.$value.'" ';
	415	+ $code = ''.$key.'="'.$value.'" ';
416	416	}
417	417	$code = $code.']';
418	418	echo do_shortcode($code);
419		- //require_once( ABSPATH . '/wp-content/plugins/aesop-events/public/includes/shortcode.php');
420		- //echo aesop_audio_shortcode($atts);
	419	+ //require_once( ABSPATH . '/wp-content/plugins/aesop-events/public/includes/shortcode.php');
	420	+ //echo aesop_audio_shortcode($atts);
421	421	}
422	422
423	423	exit;
		@@ -427,7 +427,7 @@ discard block
		block discarded – undo
427	427	$value = explode( ',', $value );
428	428
429	429	if ($taxonomy =='category') {
430		- // convert from names to category ids
	430	+ // convert from names to category ids
431	431	$cats = array();
432	432	foreach ($value as $cat) {
433	433	$cats [] = get_cat_ID($cat);
		@@ -451,7 +451,7 @@ discard block
		block discarded – undo
451	451
452	452	public function set_date( $postid, $value) {
453	453	if( $value ) {
454		- wp_update_post(
	454	+ wp_update_post(
455	455	array (
456	456	'ID' => $postid, // ID of the post to update
457	457	'post_date' => date( 'Y-m-d H:i:s', strtotime($value) ),

		@@ -372,44 +372,34 @@ discard block
		block discarded – undo
372	372	if ($code == "aesop_video") {
373	373	require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-video.php');
374	374	echo aesop_video_shortcode($atts);
375		- }
376		- else if ($code == "aesop_image") {
	375	+ } else if ($code == "aesop_image") {
377	376	require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-image.php');
378	377	echo aesop_image_shortcode($atts);
379		- }
380		- else if ($code == "aesop_quote") {
	378	+ } else if ($code == "aesop_quote") {
381	379	require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-quote.php');
382	380	echo aesop_quote_shortcode($atts);
383		- }
384		- else if ($code == "aesop_parallax") {
	381	+ } else if ($code == "aesop_parallax") {
385	382	require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-parallax.php');
386	383	echo aesop_parallax_shortcode($atts);
387		- }
388		- else if ($code == "aesop_character") {
	384	+ } else if ($code == "aesop_character") {
389	385	require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-character.php');
390	386	echo aesop_character_shortcode($atts);
391		- }
392		- else if ($code == "aesop_collection") {
	387	+ } else if ($code == "aesop_collection") {
393	388	require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-collections.php');
394	389	echo aesop_collection_shortcode($atts);
395		- }
396		- else if ($code == "aesop_chapter") {
	390	+ } else if ($code == "aesop_chapter") {
397	391	require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-heading.php');
398	392	echo aesop_chapter_shortcode($atts);
399		- }
400		- else if ($code == "aesop_content") {
	393	+ } else if ($code == "aesop_content") {
401	394	require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-cbox.php');
402	395	echo aesop_content_shortcode($atts, $atts['content_data']);
403		- }
404		- else if ($code == "aesop_gallery") {
	396	+ } else if ($code == "aesop_gallery") {
405	397	require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-gallery.php');
406	398	echo do_shortcode( '[aesop_gallery id="'.$atts["id"].'"]');
407		- }
408		- else if ($code == "aesop_audio") {
	399	+ } else if ($code == "aesop_audio") {
409	400	require_once( ABSPATH . '/wp-content/plugins/aesop-story-engine/public/includes/components/component-audio.php');
410	401	echo aesop_audio_shortcode($atts);
411		- }
412		- else {
	402	+ } else {
413	403	$code = '['.$code.' ';
414	404	foreach ($atts as $key => $value) {
415	405	$code = ''.$key.'="'.$value.'" ';
		@@ -436,15 +426,14 @@ discard block
		block discarded – undo
436	426	}
437	427
438	428	$result = wp_set_object_terms( $postid, $value, $taxonomy );
439		- }
440		- else {
	429	+ } else {
441	430	//remove all terms from post
442	431	$result = wp_set_object_terms( $postid, null, $taxonomy );
443	432	}
444	433
445	434	if ( ! is_wp_error( $result ) ) {
446	435	return true;
447		- }else{
	436	+ } else{
448	437	return false;
449	438	}
450	439	}

AesopInteractive / lasso

Push — master ( 00e978...fa1de1 )

Status

Category

Indentation +28 added lines, -28 removed lines patch added patch discarded remove patch

Braces +12 added lines, -23 removed lines patch added patch discarded remove patch