DatabaseTest::testCount() - Code Metrics - Inspection of "Only run Unit Tests in my local environment" - AdamB7586/pdo-dbal - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 340820...a8e19d )

by Adam

created 2017-08-17 14:04 UTC

DatabaseTest::testCount() A

↳ Parent: DatabaseTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	3
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php
namespace DBAL\Tests;

use DBAL\Database;
use PHPUnit\Framework\TestCase;

class DatabaseTest extends TestCase{
    
    public static $db;

    
    /**
     * @covers DBAL\Database::__construct
     * @covers DBAL\Database::connectToServer
     */
    public static function setUpBeforeClass(){
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        self::$db = new Database($GLOBALS['DB_HOST'], $GLOBALS['DB_USER'], $GLOBALS['DB_PASSWD'], $GLOBALS['DB_DBNAME']);
    }
    
    /**
     * @covers DBAL\Database::__destruct
     */
    public static function tearDownAfterClass(){
        self::$db = null;
    }

    /**
     * @covers DBAL\Database::__construct
     * @covers DBAL\Database::connectToServer
     */
    public function testConnect(){
        $this->assertObjectHasAttribute('db', self::$db);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }
    
    /**
     * @covers DBAL\Database
     */
    public function testConnectFailure(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::query
     */
    public function testQuery(){
        $query = self::$db->query("SELECT * FROM `test_table` WHERE `id` = ?", array(1));
        $this->assertArrayHasKey('0', $query);
        $this->assertCount(1, $query);
    }
    
    /**
     * @covers DBAL\Database::select
     * @covers DBAL\Database::buildSelectQuery
     * @covers DBAL\Database::where
     * @covers DBAL\Database::orderBy
     * @covers DBAL\Database::limit
     * @covers DBAL\Database::executeQuery
     */
    public function testSelect(){
        $simpleSelect = self::$db->select('test_table', array('id' => array('>', 1)), '*', array('id' => 'ASC'));
        $this->assertArrayHasKey('name', $simpleSelect);
    }
    
    /**
     * @covers DBAL\Database::selectAll
     * @covers DBAL\Database::buildSelectQuery
     * @covers DBAL\Database::where
     * @covers DBAL\Database::orderBy
     * @covers DBAL\Database::limit
     * @covers DBAL\Database::executeQuery
     */
    public function testSelectAll(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::select
     * @covers DBAL\Database::selectAll
     * @covers DBAL\Database::buildSelectQuery
     * @covers DBAL\Database::where
     * @covers DBAL\Database::orderBy
     * @covers DBAL\Database::limit
     * @covers DBAL\Database::executeQuery
     */
    public function testSelectFailure(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::insert
     * @covers DBAL\Database::fields
     * @covers DBAL\Database::executeQuery
     * @covers DBAL\Database::numRows
     */
    public function testInsert(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::insert
     * @covers DBAL\Database::fields
     * @covers DBAL\Database::executeQuery
     * @covers DBAL\Database::numRows
     */
    public function tsetInsertFailure(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::update
     * @covers DBAL\Database::fields
     * @covers DBAL\Database::where
     * @covers DBAL\Database::limit
     * @covers DBAL\Database::executeQuery
     * @covers DBAL\Database::numRows
     */
    public function testUpdate(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::update
     * @covers DBAL\Database::fields
     * @covers DBAL\Database::where
     * @covers DBAL\Database::limit
     * @covers DBAL\Database::executeQuery
     * @covers DBAL\Database::numRows
     */
    public function testUpdateFailure(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::delete
     * @covers DBAL\Database::where
     * @covers DBAL\Database::limit
     * @covers DBAL\Database::executeQuery
     * @covers DBAL\Database::numRows
     */
    public function testDelete(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::delete
     * @covers DBAL\Database::where
     * @covers DBAL\Database::limit
     * @covers DBAL\Database::executeQuery
     * @covers DBAL\Database::numRows
     */
    public function testDeleteFailure(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::count
     * @covers DBAL\Database::where
     * @covers DBAL\Database::executeQuery
     */
    public function testCount(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::fulltextIndex
     */
    public function testFulltextIndex(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::numRows
     * @covers DBAL\Database::rowCount
     */
    public function testNumRows(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::lastInsertId
     */
    public function testLastInsertID(){
        $this->assertFalse(false);
    }
    
    /**
     * @covers DBAL\Database::setCaching
     */
    public function testCaching(){
        $this->assertFalse(false);
    }
}


1			<?php
2			namespace DBAL\Tests;
3
4			use DBAL\Database;
5			use PHPUnit\Framework\TestCase;
6
7			class DatabaseTest extends TestCase{
8
9			public static $db;
			0 ignored issues – show Comprehensibility introduced 2017-08-17 10:15 UTC by Report Bug Copy Issue Report Avoid variables with short names like $db. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
10
11			/**
12			* @covers DBAL\Database::__construct
13			* @covers DBAL\Database::connectToServer
14			*/
15			public static function setUpBeforeClass(){
			0 ignored issues – show Coding Style introduced 2017-08-17 13:27 UTC by Report Bug Copy Issue Report `setUpBeforeClass` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
16			self::$db = new Database($GLOBALS['DB_HOST'], $GLOBALS['DB_USER'], $GLOBALS['DB_PASSWD'], $GLOBALS['DB_DBNAME']);
17			}
18
19			/**
20			* @covers DBAL\Database::__destruct
21			*/
22			public static function tearDownAfterClass(){
23			self::$db = null;
24			}
25
26			/**
27			* @covers DBAL\Database::__construct
28			* @covers DBAL\Database::connectToServer
29			*/
30			public function testConnect(){
31			$this->assertObjectHasAttribute('db', self::$db);
			0 ignored issues – show Bug introduced 2017-08-16 16:18 UTC by Report Bug Copy Issue Report It seems like `self::$db` can be `null`; however, `assertObjectHasAttribute()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
32			}
33
34			/**
35			* @covers DBAL\Database
36			*/
37			public function testConnectFailure(){
38			$this->assertFalse(false);
39			}
40
41			/**
42			* @covers DBAL\Database::query
43			*/
44			public function testQuery(){
45			$query = self::$db->query("SELECT * FROM `test_table` WHERE `id` = ?", array(1));
46			$this->assertArrayHasKey('0', $query);
47			$this->assertCount(1, $query);
48			}
49
50			/**
51			* @covers DBAL\Database::select
52			* @covers DBAL\Database::buildSelectQuery
53			* @covers DBAL\Database::where
54			* @covers DBAL\Database::orderBy
55			* @covers DBAL\Database::limit
56			* @covers DBAL\Database::executeQuery
57			*/
58			public function testSelect(){
59			$simpleSelect = self::$db->select('test_table', array('id' => array('>', 1)), '*', array('id' => 'ASC'));
60			$this->assertArrayHasKey('name', $simpleSelect);
61			}
62
63			/**
64			* @covers DBAL\Database::selectAll
65			* @covers DBAL\Database::buildSelectQuery
66			* @covers DBAL\Database::where
67			* @covers DBAL\Database::orderBy
68			* @covers DBAL\Database::limit
69			* @covers DBAL\Database::executeQuery
70			*/
71			public function testSelectAll(){
72			$this->assertFalse(false);
73			}
74
75			/**
76			* @covers DBAL\Database::select
77			* @covers DBAL\Database::selectAll
78			* @covers DBAL\Database::buildSelectQuery
79			* @covers DBAL\Database::where
80			* @covers DBAL\Database::orderBy
81			* @covers DBAL\Database::limit
82			* @covers DBAL\Database::executeQuery
83			*/
84			public function testSelectFailure(){
85			$this->assertFalse(false);
86			}
87
88			/**
89			* @covers DBAL\Database::insert
90			* @covers DBAL\Database::fields
91			* @covers DBAL\Database::executeQuery
92			* @covers DBAL\Database::numRows
93			*/
94			public function testInsert(){
95			$this->assertFalse(false);
96			}
97
98			/**
99			* @covers DBAL\Database::insert
100			* @covers DBAL\Database::fields
101			* @covers DBAL\Database::executeQuery
102			* @covers DBAL\Database::numRows
103			*/
104			public function tsetInsertFailure(){
105			$this->assertFalse(false);
106			}
107
108			/**
109			* @covers DBAL\Database::update
110			* @covers DBAL\Database::fields
111			* @covers DBAL\Database::where
112			* @covers DBAL\Database::limit
113			* @covers DBAL\Database::executeQuery
114			* @covers DBAL\Database::numRows
115			*/
116			public function testUpdate(){
117			$this->assertFalse(false);
118			}
119
120			/**
121			* @covers DBAL\Database::update
122			* @covers DBAL\Database::fields
123			* @covers DBAL\Database::where
124			* @covers DBAL\Database::limit
125			* @covers DBAL\Database::executeQuery
126			* @covers DBAL\Database::numRows
127			*/
128			public function testUpdateFailure(){
129			$this->assertFalse(false);
130			}
131
132			/**
133			* @covers DBAL\Database::delete
134			* @covers DBAL\Database::where
135			* @covers DBAL\Database::limit
136			* @covers DBAL\Database::executeQuery
137			* @covers DBAL\Database::numRows
138			*/
139			public function testDelete(){
140			$this->assertFalse(false);
141			}
142
143			/**
144			* @covers DBAL\Database::delete
145			* @covers DBAL\Database::where
146			* @covers DBAL\Database::limit
147			* @covers DBAL\Database::executeQuery
148			* @covers DBAL\Database::numRows
149			*/
150			public function testDeleteFailure(){
151			$this->assertFalse(false);
152			}
153
154			/**
155			* @covers DBAL\Database::count
156			* @covers DBAL\Database::where
157			* @covers DBAL\Database::executeQuery
158			*/
159			public function testCount(){
160			$this->assertFalse(false);
161			}
162
163			/**
164			* @covers DBAL\Database::fulltextIndex
165			*/
166			public function testFulltextIndex(){
167			$this->assertFalse(false);
168			}
169
170			/**
171			* @covers DBAL\Database::numRows
172			* @covers DBAL\Database::rowCount
173			*/
174			public function testNumRows(){
175			$this->assertFalse(false);
176			}
177
178			/**
179			* @covers DBAL\Database::lastInsertId
180			*/
181			public function testLastInsertID(){
182			$this->assertFalse(false);
183			}
184
185			/**
186			* @covers DBAL\Database::setCaching
187			*/
188			public function testCaching(){
189			$this->assertFalse(false);
190			}
191			}
192

AdamB7586 / pdo-dbal

Push — master ( 340820...a8e19d )

DatabaseTest::testCount() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like