Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | class RedisCache implements CacheInterface |
||
| 10 | { |
||
| 11 | |||
| 12 | protected $cache; |
||
| 13 | |||
| 14 | /** |
||
| 15 | * constructor |
||
| 16 | */ |
||
| 17 | public function __construct() |
||
| 21 | |||
| 22 | /** |
||
| 23 | * destructor closes the connection |
||
| 24 | */ |
||
| 25 | public function __destruct() |
||
| 31 | |||
| 32 | /** |
||
| 33 | * Connect to a server |
||
| 34 | * @param string $host This should be the host name or IP address you want to connect to |
||
| 35 | * @param int $port The port number where Memcache can be accessed |
||
| 36 | * @param boolean $persistent If you want this connection to be persistent set to true else set to false |
||
| 37 | * @return $this |
||
| 38 | */ |
||
| 39 | public function connect($host, $port, $persistent = false) |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Add a server to connection pool |
||
| 47 | * @param string $host This should be the host name or IP address you want to add to the Memcache pool |
||
| 48 | * @param int $port The port number where Memcache can be accessed |
||
| 49 | * @param boolean $persistent If you want this connection to be persistent set to true else set to false |
||
| 50 | * @return $this |
||
| 51 | */ |
||
| 52 | View Code Duplication | public function addServer($host, $port, $persistent = false) |
|
| 61 | |||
| 62 | |||
| 63 | /** |
||
| 64 | * Adds a value to be stored on the server |
||
| 65 | * @param string $key This should be the key for the value you wish to add |
||
| 66 | * @param mixed $value The value you wish to be stored with the given key |
||
| 67 | * @param int $time How long should the value be stored for in seconds (0 = never expire) (max set value = 2592000 (30 Days)) |
||
| 68 | * @return boolean Returns true if successfully added or false on failure |
||
| 69 | */ |
||
| 70 | public function save($key, $value, $time = 0) |
||
| 74 | |||
| 75 | |||
| 76 | /** |
||
| 77 | * Replaces a stored value for a given key |
||
| 78 | * @param string $key This should be the key for the value you wish to replace |
||
| 79 | * @param mixed $value The new value that you wish to give to that key |
||
| 80 | * @param int $time How long should the value be stored for in seconds (0 = never expire) (max set value = 2592000 (30 Days)) |
||
| 81 | * @return boolean Returns true if successfully replaced or false on failure |
||
| 82 | */ |
||
| 83 | public function replace($key, $value, $time = 0) |
||
| 87 | |||
| 88 | /** |
||
| 89 | * Returns the values store for the given key |
||
| 90 | * @param string $key This should be the unique query key to get the value |
||
| 91 | * @return mixed The store value will be returned |
||
| 92 | */ |
||
| 93 | public function fetch($key) |
||
| 97 | |||
| 98 | /** |
||
| 99 | * Deletes a single value from the server based on the given key |
||
| 100 | * @param string $key This should be the key that you wish to delete the value for |
||
| 101 | * @return boolean Returns true on success or false on failure |
||
| 102 | */ |
||
| 103 | public function delete($key) |
||
| 107 | |||
| 108 | /** |
||
| 109 | * Deletes all values from the server |
||
| 110 | * @return boolean Returns true on success or false on failure |
||
| 111 | */ |
||
| 112 | public function deleteAll() |
||
| 116 | } |
||
| 117 |