AdFabConnect /
abejs
| Conditions | 10 |
| Paths | 24 |
| Total Lines | 29 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Complex classes like sourceAttr.js ➔ ... ➔ ??? often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | |||
| 22 | Array.prototype.forEach.call(params.value, (v) => { |
||
| 23 | var item = v |
||
| 24 | try { |
||
| 25 | var displayV = eval('item.' + params.display) |
||
| 26 | if(params.display != null && displayV !== null) { |
||
| 27 | item = displayV |
||
| 28 | } else { |
||
| 29 | if(typeof v === 'string') { |
||
| 30 | item = v |
||
| 31 | } else { |
||
| 32 | item = v[Object.keys(v)[0]] |
||
| 33 | } |
||
| 34 | } |
||
| 35 | } catch(e) { |
||
| 36 | item = v[Object.keys(v)[0]] |
||
| 37 | } |
||
| 38 | |||
| 39 | if(typeof val === 'object' && Object.prototype.toString.call(val) === '[object Array]' |
||
| 40 | && typeof item === 'object' && Object.prototype.toString.call(item) === '[object Array]') { |
||
| 41 | |||
| 42 | Array.prototype.forEach.call(item, (i) => { |
||
| 43 | if(val.includes(i)) { |
||
| 44 | selected = 'selected="selected"' |
||
| 45 | } |
||
| 46 | }) |
||
| 47 | }else if(val === item) { |
||
| 48 | selected = 'selected="selected"' |
||
| 49 | } |
||
| 50 | }) |
||
| 51 | }else if(params.value === hiddenVal) { |
||
| 61 |
Loading history...