source.js ➔ ... ➔ ??? - Code Metrics - Inspection of "refactoring: object test + fix" - AdFabConnect/abejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f48291...a65f2c )

by greg

created 2016-10-09 11:02 UTC

source.js ➔ ... ➔ ??? B

↳ Parent: source.js ➔ urlList

Complexity

Conditions	6
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
c	1
b	0
f	0
nc	5
dl	0
loc	72
rs	8.5164
nop	1

How to fix Long Method

import {Promise} from 'es6-promise'
import http from 'http' 
import https from 'https'
import path from 'path'

import {
  config,
  cmsData
} from '../../'

export function requestList(obj, tplPath, match, jsonPage) {
  var p = new Promise((resolve) => {
    cmsData.sql.executeQuery(tplPath, match, jsonPage)
      .then((data) => {
        if (!jsonPage['abe_source']) {
          jsonPage['abe_source'] = {}
        }
        jsonPage['abe_source'][obj.key] = data
        if (!obj.editable) {
          if (obj['max-length']) {
            jsonPage[obj.key] = data.slice(0, obj['max-length'])
          }else {
            jsonPage[obj.key] = data
          }
        } else if ((jsonPage[obj.key] == null) && obj.prefill) {
          if (obj['prefill-quantity'] && obj['max-length']) {
            jsonPage[obj.key] = data.slice(0, (obj['prefill-quantity'] > obj['max-length']) ? obj['max-length'] : obj['prefill-quantity'])
          }else if (obj['prefill-quantity']) {
            jsonPage[obj.key] = data.slice(0, obj['prefill-quantity'])
          }else if (obj['max-length']) {
            jsonPage[obj.key] = data.slice(0, obj['max-length'])
          }else {
            jsonPage[obj.key] = data
          }
        }

        resolve()
      })
  })

  return p
}

export function valueList(obj, match, jsonPage) {
  var p = new Promise((resolve) => {
    var value = cmsData.sql.getDataSource(match)

    if(value.indexOf('{') > -1 || value.indexOf('[') > -1) {
      try{
        value = JSON.parse(value)

        jsonPage['abe_source'][obj.key] = value
      }catch(e){
        jsonPage['abe_source'][obj.key] = null
        console.log(`Error ${value}/is not a valid JSON`, `\n${e}`)

      }
    }
    resolve()
  })

  return p
}

export function urlList(obj, tplPath, match, jsonPage) {
  var p = new Promise((resolve) => {
    if(obj.autocomplete !== true && obj.autocomplete !== 'true') {
      var host = obj.sourceString
      host = host.split('/')
      var httpUse = http
      var defaultPort = 80
      if(host[0] === 'https:') {
        httpUse = https
        defaultPort = 443
      }
      host = host[2].split(':')

      var pathSource = obj.sourceString.split('//')
      if(pathSource[1] != null) {
        pathSource = pathSource[1].split('/')
        pathSource.shift()
        pathSource = '/' + path.join('/')
      }else {
        pathSource = '/'
      }
      var options = {
        hostname: host[0],
        port: (host[1] != null) ? host[1] : defaultPort,
        path: pathSource,
        method: 'GET',
        headers: {
          'Content-Type': 'application/x-www-form-urlencoded',
          'Content-Length': 0
        }
      }

      var body = ''

      var localReq = httpUse.request(options, (localRes) => {
        localRes.setEncoding('utf8')
        localRes.on('data', (chunk) => {
          body += chunk
        })
        localRes.on('end', () => {
          try {
            if(typeof body === 'string') {
              var parsedBody = JSON.parse(body)
              if(typeof parsedBody === 'object' && Object.prototype.toString.call(parsedBody) === '[object Array]') {
                jsonPage['abe_source'][obj.key] = parsedBody
              }else if(typeof parsedBody === 'object' && Object.prototype.toString.call(parsedBody) === '[object Object]') {
                jsonPage['abe_source'][obj.key] = [parsedBody]
              }
            }else if(typeof body === 'object' && Object.prototype.toString.call(body) === '[object Array]') {
              jsonPage['abe_source'][obj.key] = body
            }else if(typeof body === 'object' && Object.prototype.toString.call(body) === '[object Object]') {
              jsonPage['abe_source'][obj.key] = body
            }
          } catch(e) {
            console.log(`Error ${obj.sourceString} is not a valid JSON`, `\n${e}`)

          }
          resolve()
        })
      })

      localReq.on('error', (e) => {
        console.log(e)

      })

      // write data to request body
      localReq.write('')
      localReq.end()
      
    }else {
      jsonPage['abe_source'][obj.key] = obj.sourceString
      resolve()
    }
  })

  return p
}

export function fileList(obj, tplPath, match, jsonPage) {
  var p = new Promise((resolve) => {
    jsonPage['abe_source'][obj.key] = cmsData.file.get(path.join(config.root, obj.sourceString))
    resolve()
  })

  return p
}

export function nextDataList(tplPath, jsonPage, match) {
  var p = new Promise((resolve) => {
    if(jsonPage['abe_source'] == null) {
      jsonPage['abe_source'] = {}
    }

    var obj = cmsData.attributes.getAll(match, jsonPage)
    obj = cmsData.attributes.sanitizeSourceAttribute(obj, jsonPage)
    
    var type = cmsData.sql.getSourceType(obj.sourceString)

    switch (type) {
    case 'request':
      requestList(obj, tplPath, match, jsonPage)
          .then(() => {
            resolve()
          }).catch((e) => {
            console.log('[ERROR] source.js requestList', e)

          })
      break
    case 'value':
      valueList(obj, match, jsonPage)
          .then(() => {
            resolve()
          }).catch((e) => {
            console.log('[ERROR] source.js valueList', e)

          })
      break
    case 'url':
      urlList(obj, tplPath, match, jsonPage)
          .then(() => {
            resolve()
          }).catch((e) => {
            console.log('[ERROR] source.js urlList', e)

          })
      break
    case 'file':
      fileList(obj, tplPath, match, jsonPage)
          .then(() => {
            resolve()
          }).catch((e) => {
            console.log('[ERROR] source.js fileList', e)

          })
      break
    default:
      resolve()
      break
    }
  })

  return p
}

export function getDataList(tplPath, text, jsonPage) {
  var p = new Promise((resolve) => {

    var promises = []
    var matches = cmsData.regex.getTagAbeTypeRequest(text)
    Array.prototype.forEach.call(matches, (match) => {
      promises.push(nextDataList(tplPath, jsonPage, match[0]))
    })

    Promise.all(promises)
      .then(() => {
        resolve()
      }).catch(function(e) {
        console.error('source.js getDataList', e)
      })
  }).catch(function(e) {
    console.error('source.js getDataList', e)
  })

  return p
}

export function removeDataList(text) {
  var listReg = /({{abe.*type=[\'|\"]data.*}})/g

  return text.replace(listReg, '')
}

1			import {Promise} from 'es6-promise'
2			import http from 'http'
3			import https from 'https'
4			import path from 'path'
5
6			import {
7			config,
8			cmsData
9			} from '../../'
10
11			export function requestList(obj, tplPath, match, jsonPage) {
12			var p = new Promise((resolve) => {
13			cmsData.sql.executeQuery(tplPath, match, jsonPage)
14			.then((data) => {
15			if (!jsonPage['abe_source']) {
16			jsonPage['abe_source'] = {}
17			}
18			jsonPage['abe_source'][obj.key] = data
19			if (!obj.editable) {
20			if (obj['max-length']) {
21			jsonPage[obj.key] = data.slice(0, obj['max-length'])
22			}else {
23			jsonPage[obj.key] = data
24			}
25			} else if ((jsonPage[obj.key] == null) && obj.prefill) {
26			if (obj['prefill-quantity'] && obj['max-length']) {
27			jsonPage[obj.key] = data.slice(0, (obj['prefill-quantity'] > obj['max-length']) ? obj['max-length'] : obj['prefill-quantity'])
28			}else if (obj['prefill-quantity']) {
29			jsonPage[obj.key] = data.slice(0, obj['prefill-quantity'])
30			}else if (obj['max-length']) {
31			jsonPage[obj.key] = data.slice(0, obj['max-length'])
32			}else {
33			jsonPage[obj.key] = data
34			}
35			}
36
37			resolve()
38			})
39			})
40
41			return p
42			}
43
44			export function valueList(obj, match, jsonPage) {
45			var p = new Promise((resolve) => {
46			var value = cmsData.sql.getDataSource(match)
47
48			if(value.indexOf('{') > -1 \|\| value.indexOf('[') > -1) {
49			try{
50			value = JSON.parse(value)
51
52			jsonPage['abe_source'][obj.key] = value
53			}catch(e){
54			jsonPage['abe_source'][obj.key] = null
55			console.log(`Error ${value}/is not a valid JSON`, `\n${e}`)
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
56			}
57			}
58			resolve()
59			})
60
61			return p
62			}
63
64			export function urlList(obj, tplPath, match, jsonPage) {
65			var p = new Promise((resolve) => {
66			if(obj.autocomplete !== true && obj.autocomplete !== 'true') {
67			var host = obj.sourceString
68			host = host.split('/')
69			var httpUse = http
70			var defaultPort = 80
71			if(host[0] === 'https:') {
72			httpUse = https
73			defaultPort = 443
74			}
75			host = host[2].split(':')
76
77			var pathSource = obj.sourceString.split('//')
78			if(pathSource[1] != null) {
79			pathSource = pathSource[1].split('/')
80			pathSource.shift()
81			pathSource = '/' + path.join('/')
82			}else {
83			pathSource = '/'
84			}
85			var options = {
86			hostname: host[0],
87			port: (host[1] != null) ? host[1] : defaultPort,
88			path: pathSource,
89			method: 'GET',
90			headers: {
91			'Content-Type': 'application/x-www-form-urlencoded',
92			'Content-Length': 0
93			}
94			}
95
96			var body = ''
97
98			var localReq = httpUse.request(options, (localRes) => {
99			localRes.setEncoding('utf8')
100			localRes.on('data', (chunk) => {
101			body += chunk
102			})
103			localRes.on('end', () => {
104			try {
105			if(typeof body === 'string') {
106			var parsedBody = JSON.parse(body)
107			if(typeof parsedBody === 'object' && Object.prototype.toString.call(parsedBody) === '[object Array]') {
108			jsonPage['abe_source'][obj.key] = parsedBody
109			}else if(typeof parsedBody === 'object' && Object.prototype.toString.call(parsedBody) === '[object Object]') {
110			jsonPage['abe_source'][obj.key] = [parsedBody]
111			}
112			}else if(typeof body === 'object' && Object.prototype.toString.call(body) === '[object Array]') {
113			jsonPage['abe_source'][obj.key] = body
114			}else if(typeof body === 'object' && Object.prototype.toString.call(body) === '[object Object]') {
115			jsonPage['abe_source'][obj.key] = body
116			}
117			} catch(e) {
118			console.log(`Error ${obj.sourceString} is not a valid JSON`, `\n${e}`)
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
119			}
120			resolve()
121			})
122			})
123
124			localReq.on('error', (e) => {
125			console.log(e)
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
126			})
127
128			// write data to request body
129			localReq.write('')
130			localReq.end()
131
132			}else {
133			jsonPage['abe_source'][obj.key] = obj.sourceString
134			resolve()
135			}
136			})
137
138			return p
139			}
140
141			export function fileList(obj, tplPath, match, jsonPage) {
142			var p = new Promise((resolve) => {
143			jsonPage['abe_source'][obj.key] = cmsData.file.get(path.join(config.root, obj.sourceString))
144			resolve()
145			})
146
147			return p
148			}
149
150			export function nextDataList(tplPath, jsonPage, match) {
151			var p = new Promise((resolve) => {
152			if(jsonPage['abe_source'] == null) {
153			jsonPage['abe_source'] = {}
154			}
155
156			var obj = cmsData.attributes.getAll(match, jsonPage)
157			obj = cmsData.attributes.sanitizeSourceAttribute(obj, jsonPage)
158
159			var type = cmsData.sql.getSourceType(obj.sourceString)
160
161			switch (type) {
162			case 'request':
163			requestList(obj, tplPath, match, jsonPage)
164			.then(() => {
165			resolve()
166			}).catch((e) => {
167			console.log('[ERROR] source.js requestList', e)
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
168			})
169			break
170			case 'value':
171			valueList(obj, match, jsonPage)
172			.then(() => {
173			resolve()
174			}).catch((e) => {
175			console.log('[ERROR] source.js valueList', e)
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
176			})
177			break
178			case 'url':
179			urlList(obj, tplPath, match, jsonPage)
180			.then(() => {
181			resolve()
182			}).catch((e) => {
183			console.log('[ERROR] source.js urlList', e)
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
184			})
185			break
186			case 'file':
187			fileList(obj, tplPath, match, jsonPage)
188			.then(() => {
189			resolve()
190			}).catch((e) => {
191			console.log('[ERROR] source.js fileList', e)
			0 ignored issues – show Debugging Code introduced 2016-09-27 10:32 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
192			})
193			break
194			default:
195			resolve()
196			break
197			}
198			})
199
200			return p
201			}
202
203			export function getDataList(tplPath, text, jsonPage) {
204			var p = new Promise((resolve) => {
205
206			var promises = []
207			var matches = cmsData.regex.getTagAbeTypeRequest(text)
208			Array.prototype.forEach.call(matches, (match) => {
209			promises.push(nextDataList(tplPath, jsonPage, match[0]))
210			})
211
212			Promise.all(promises)
213			.then(() => {
214			resolve()
215			}).catch(function(e) {
216			console.error('source.js getDataList', e)
217			})
218			}).catch(function(e) {
219			console.error('source.js getDataList', e)
220			})
221
222			return p
223			}
224
225			export function removeDataList(text) {
226			var listReg = /({{abe.type=[\'\|\"]data.}})/g
227
228			return text.replace(listReg, '')
229			}

AdFabConnect / abejs

Push — master ( f48291...a65f2c )

source.js ➔ ... ➔ ??? B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like