forgot.js ➔ ... ➔ crypto.randomBytes - Code Metrics - Inspection of "Abe users core" - AdFabConnect/abejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#40)

unknown

created 2016-11-25 16:23 UTC

forgot.js ➔ ... ➔ crypto.randomBytes C

↳ Parent: forgot.js ➔ ... ➔ User.utils.findByEmail

Complexity

Conditions	7
Paths	18

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
nc	18
dl	0
loc	70
rs	6.8519
c	0
b	0
f	0
nop	2

How to fix Long Method

import fs from 'fs-extra'
import crypto from 'crypto'
import nodemailer from 'nodemailer'
import path from 'path'

import {
  coreUtils,
  config,
  Handlebars,
  User
} from '../../../../cli'

function showHtml(res, req, info) {
  var resHtml = ''
  var page = path.join(__dirname + '/../../../views/users/forgot.html')

  if (coreUtils.file.exist(page)) {
    resHtml = fs.readFileSync(page, 'utf8')
  }

  var template = Handlebars.compile(resHtml, {noEscape: true})

  var tmp = template({
    csrfToken: res.locals.csrfToken,
    config: JSON.stringify(config),
    express: {
      req: req,
      res: res
    },
    token: req.query.token,
    info: info
  })

  return res.send(tmp)
}

var route = function route(req, res) {

  var html
  if(typeof req.query.email !== 'undefined' && req.query.email !== null) {
    User.utils.findByEmail(req.query.email, function (err, user) {
      if (err) {
        return res.status(200).json({success: 1}) 
      }

      crypto.randomBytes(20, function(err, buf) {
        var resetPasswordToken = buf.toString('hex')
        var forgotExpire = config.forgotExpire

        User.operations.update({
          id:user.id,
          resetPasswordToken: resetPasswordToken,
          resetPasswordExpires: Date.now() + (forgotExpire*60*1000)
        })

        var requestedUrl = req.protocol + '://' + req.get('Host') + '/abe/users/reset?token=' + resetPasswordToken

        var smtp = config.smtp
        var emailConf = config.users.email
        html = emailConf.html || ''

        if(typeof emailConf.templateHtml !== 'undefined' && emailConf.templateHtml !== null) {
          var fileHtml = path.join(config.root, emailConf.templateHtml)
          if (coreUtils.file.exist(fileHtml)) {
            html = fs.readFileSync(fileHtml, 'utf8')
          }
        }

        var template = Handlebars.compile(html, {noEscape: true})

        html = template({
          express: {
            req: req,
            res: res
          },
          forgotUrl: requestedUrl,
          siteUrl: req.protocol + '://' + req.get('Host'),
          user: user
        })

        if(typeof smtp === 'undefined' || smtp === null) {
          var transport = nodemailer.createTransport('direct', {})
          transport.sendMail({
            from: emailConf.from, // sender address
            to: user.email, // list of receivers
            subject: emailConf.subject, // Subject line
            text: emailConf.text.replace(/\{\{forgotUrl\}\}/g, requestedUrl), // plaintext body
            html: html.replace(/\{\{forgotUrl\}\}/g, requestedUrl) // html body
          }, console.error)

          showHtml(res, req, 'Check your inbox')
        }else if(typeof smtp !== 'string') {
          // create reusable transporter object using the default SMTP transport
          var transporter = nodemailer.createTransport('SMTP', smtp)

          // setup e-mail data with unicode symbols
          var mailOptions = {
            from: emailConf.from, // sender address
            to: user.email, // list of receivers
            subject: emailConf.subject, // Subject line
            text: emailConf.text.replace(/\{\{forgotUrl\}\}/g, requestedUrl), // plaintext body
            html: html.replace(/\{\{forgotUrl\}\}/g, requestedUrl) // html body
          }

          // send mail with defined transport object
          transporter.sendMail(mailOptions, function(error, info){
            if(error){
              return console.log(error)

            }

            showHtml(res, req, 'Check your inbox')
            console.log('Message sent: ' + info.response)

          })
        }
      })

    })
  }else {
    showHtml(res, req, req.flash('info'))
  }
}

export default route

1			import fs from 'fs-extra'
2			import crypto from 'crypto'
3			import nodemailer from 'nodemailer'
4			import path from 'path'
5
6			import {
7			coreUtils,
8			config,
9			Handlebars,
10			User
11			} from '../../../../cli'
12
13			function showHtml(res, req, info) {
14			var resHtml = ''
15			var page = path.join(__dirname + '/../../../views/users/forgot.html')
			0 ignored issues – show Compatibility introduced 2016-11-24 15:22 UTC by Report Bug Copy Issue Report Consider using the `path` module for constructing paths since they are otherwise not cross-OS compatible. Loading history...
16			if (coreUtils.file.exist(page)) {
17			resHtml = fs.readFileSync(page, 'utf8')
18			}
19
20			var template = Handlebars.compile(resHtml, {noEscape: true})
21
22			var tmp = template({
23			csrfToken: res.locals.csrfToken,
24			config: JSON.stringify(config),
25			express: {
26			req: req,
27			res: res
28			},
29			token: req.query.token,
30			info: info
31			})
32
33			return res.send(tmp)
34			}
35
36			var route = function route(req, res) {
			0 ignored issues – show Comprehensibility Naming Best Practice introduced 2016-11-24 15:22 UTC by Report Bug Copy Issue Report The variable `route` already seems to be declared on line `36`. Consider using another variable name or omitting the `var` keyword. This check looks for variables that are declared in multiple lines. There may be several reasons for this. In the simplest case the variable name was reused by mistake. This may lead to very hard to locate bugs. If you want to reuse a variable for another purpose, consider declaring it at or near the top of your function and just assigning to it subsequently so it is always declared. Loading history...
37			var html
38			if(typeof req.query.email !== 'undefined' && req.query.email !== null) {
39			User.utils.findByEmail(req.query.email, function (err, user) {
40			if (err) {
41			return res.status(200).json({success: 1})
42			}
43
44			crypto.randomBytes(20, function(err, buf) {
45			var resetPasswordToken = buf.toString('hex')
46			var forgotExpire = config.forgotExpire
47
48			User.operations.update({
49			id:user.id,
50			resetPasswordToken: resetPasswordToken,
51			resetPasswordExpires: Date.now() + (forgotExpire601000)
52			})
53
54			var requestedUrl = req.protocol + '://' + req.get('Host') + '/abe/users/reset?token=' + resetPasswordToken
55
56			var smtp = config.smtp
57			var emailConf = config.users.email
58			html = emailConf.html \|\| ''
59
60			if(typeof emailConf.templateHtml !== 'undefined' && emailConf.templateHtml !== null) {
61			var fileHtml = path.join(config.root, emailConf.templateHtml)
62			if (coreUtils.file.exist(fileHtml)) {
63			html = fs.readFileSync(fileHtml, 'utf8')
64			}
65			}
66
67			var template = Handlebars.compile(html, {noEscape: true})
68
69			html = template({
70			express: {
71			req: req,
72			res: res
73			},
74			forgotUrl: requestedUrl,
75			siteUrl: req.protocol + '://' + req.get('Host'),
76			user: user
77			})
78
79			if(typeof smtp === 'undefined' \|\| smtp === null) {
80			var transport = nodemailer.createTransport('direct', {})
81			transport.sendMail({
82			from: emailConf.from, // sender address
83			to: user.email, // list of receivers
84			subject: emailConf.subject, // Subject line
85			text: emailConf.text.replace(/\{\{forgotUrl\}\}/g, requestedUrl), // plaintext body
86			html: html.replace(/\{\{forgotUrl\}\}/g, requestedUrl) // html body
87			}, console.error)
88
89			showHtml(res, req, 'Check your inbox')
90			}else if(typeof smtp !== 'string') {
91			// create reusable transporter object using the default SMTP transport
92			var transporter = nodemailer.createTransport('SMTP', smtp)
93
94			// setup e-mail data with unicode symbols
95			var mailOptions = {
96			from: emailConf.from, // sender address
97			to: user.email, // list of receivers
98			subject: emailConf.subject, // Subject line
99			text: emailConf.text.replace(/\{\{forgotUrl\}\}/g, requestedUrl), // plaintext body
100			html: html.replace(/\{\{forgotUrl\}\}/g, requestedUrl) // html body
101			}
102
103			// send mail with defined transport object
104			transporter.sendMail(mailOptions, function(error, info){
105			if(error){
106			return console.log(error)
			0 ignored issues – show Debugging Code introduced 2016-11-24 15:22 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
107			}
108
109			showHtml(res, req, 'Check your inbox')
110			console.log('Message sent: ' + info.response)
			0 ignored issues – show Best Practice introduced 2016-11-24 15:22 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
111			})
112			}
113			})
			0 ignored issues – show Best Practice introduced 2016-11-24 15:22 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
114			})
115			}else {
116			showHtml(res, req, req.flash('info'))
117			}
118			}
119
120			export default route

AdFabConnect / abejs

Pull Request — master (#40)

forgot.js ➔ ... ➔ crypto.randomBytes C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like