post.js ➔ reject - Code Metrics - Inspection of "Abe users core" - AdFabConnect/abejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#40)

unknown

created 2016-11-25 16:23 UTC

post.js ➔ reject B

↳ Parent: src/cli/cms/operations/post.js

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
dl	0
loc	36
rs	8.8571
c	0
b	0
f	0
nop	3

1 Function

Rating	Name	Duplication	Size	Complexity
A	post.js ➔ ... ➔ ???	0	8	3

import path from 'path'

import {
  cmsData,
  Page,
  cmsOperations,
  cmsTemplates,
  coreUtils,
  config,
  abeExtend,
  Manager
} from '../../'

export function draft(filePath, json, workflow = 'draft') {
  var p = new Promise((resolve) => {
    abeExtend.hooks.instance.trigger('beforeDraft', json, filePath)

    var revisionPath = path.join(config.root, config.data.url, filePath.replace(`.${config.files.templates.extension}`, '.json'))
    revisionPath = coreUtils.file.addDateIsoToRevisionPath(revisionPath, workflow)
    var date = coreUtils.file.getDate(revisionPath)
    cmsData.metas.add(json, workflow, date)

    var template = cmsTemplates.template.getTemplate(json.abe_meta.template)

    cmsData.source.getDataList(path.dirname(json.abe_meta.link), template, json)
    .then(() => {

      json['abe_meta'].complete = cmsData.utils.getPercentOfRequiredTagsFilled(template, json)

      // var page = new Page(json.abe_meta.template, template, json, true)
      var result
      if (!cmsOperations.save.saveJson(revisionPath, json)) {
        result = {
          success: 0,
          error: 'cannot json save file'
        }
      }else {
        Manager.instance.updatePostInList(revisionPath)
        result = {
          success: 1,
          json: json
        }
      }
      resolve(result)
    })
  })

  return p
}

export function publish(filePath, json) {
  var p = new Promise((resolve) => {
    abeExtend.hooks.instance.trigger('beforePublish', json, filePath)

    var revisionPath = path.join(config.root, config.data.url, filePath.replace(`.${config.files.templates.extension}`, '.json'))
    var postPath = path.join(config.root, config.publish.url, filePath)
    // revisionPath = coreUtils.file.addDateIsoToRevisionPath(revisionPath, workflow)
    cmsData.metas.add(json, 'publish')

    var template = cmsTemplates.template.getTemplate(json.abe_meta.template)

    cmsData.source.getDataList(path.dirname(json.abe_meta.link), template, json)
    .then(() => {
      json['abe_meta'].complete = cmsData.utils.getPercentOfRequiredTagsFilled(template, json)

      var page = new Page(json.abe_meta.template, template, json, true)
      
      var result
      if (!cmsOperations.save.saveHtml(postPath, page.html)) {
        result = {
          success: 0,
          error: 'cannot html save file'
        }
      }else {
        if (!cmsOperations.save.saveJson(revisionPath, json)) {
          result = {
            success: 0,
            error: 'cannot json save file'
          }
        }else {
          Manager.instance.updatePostInList(revisionPath)
          result = {
            success: 1,
            json: json
          }
        }
      }
      resolve(result)
    })
  })

  return p
}

export function unpublish(filePath) {
  abeExtend.hooks.instance.trigger('beforeUnpublish', filePath)

  var p = new Promise((resolve, reject) => {
    var revisionPath = path.join(config.root, config.data.url, filePath.replace(`.${config.files.templates.extension}`, '.json'))
    var postPath = path.join(config.root, config.publish.url, filePath)
    if(coreUtils.file.exist(revisionPath)) {
      var json = JSON.parse(JSON.stringify(cmsData.file.get(revisionPath)))
      if(json.abe_meta.publish != null) {
        delete json.abe_meta.publish
      }

      var p = draft(
        filePath, 
        json,
        'draft'
      )

      p.then((result) => {
        cmsOperations.remove.removeFile(revisionPath, postPath)
        abeExtend.hooks.instance.trigger('afterUnpublish', revisionPath, postPath)
        var newRevisionPath = path.join(config.root, config.data.url, result.json.abe_meta.latest.abeUrl.replace(`.${config.files.templates.extension}`, '.json'))
        Manager.instance.updatePostInList(newRevisionPath)
        resolve(result)
      }).catch(function(e) {
        console.error('[ERROR] unpublish', e)
        reject()
      })
    }
  })

  return p
}

export function reject(filePath, json, workflow) {
  abeExtend.hooks.instance.trigger('beforeReject', filePath)

  var rejectToWorkflow
  var found = false
  Array.prototype.forEach.call(config.users.workflow, (flow) => {
    if (workflow === flow) {
      found = true
    }
    if (!found) {
      rejectToWorkflow = flow
    }
  })
  if (!found) {
    rejectToWorkflow = 'draft'
  }

  var p = new Promise((resolve) => {
    if(json.abe_meta.publish != null) {
      delete json.abe_meta.publish
    }
    var p2 = draft(
        filePath, 
        json,
        rejectToWorkflow

      )
    p2.then((result) => {
      abeExtend.hooks.instance.trigger('afterReject', result)
      resolve(result)
    }).catch(function(e) {
      console.error('[ERROR] reject.js', e)
    })
  })

  return p
}

1			import path from 'path'
2
3			import {
4			cmsData,
5			Page,
6			cmsOperations,
7			cmsTemplates,
8			coreUtils,
9			config,
10			abeExtend,
11			Manager
12			} from '../../'
13
14			export function draft(filePath, json, workflow = 'draft') {
15			var p = new Promise((resolve) => {
16			abeExtend.hooks.instance.trigger('beforeDraft', json, filePath)
17
18			var revisionPath = path.join(config.root, config.data.url, filePath.replace(`.${config.files.templates.extension}`, '.json'))
19			revisionPath = coreUtils.file.addDateIsoToRevisionPath(revisionPath, workflow)
20			var date = coreUtils.file.getDate(revisionPath)
21			cmsData.metas.add(json, workflow, date)
22
23			var template = cmsTemplates.template.getTemplate(json.abe_meta.template)
24
25			cmsData.source.getDataList(path.dirname(json.abe_meta.link), template, json)
26			.then(() => {
27
28			json['abe_meta'].complete = cmsData.utils.getPercentOfRequiredTagsFilled(template, json)
29
30			// var page = new Page(json.abe_meta.template, template, json, true)
31			var result
32			if (!cmsOperations.save.saveJson(revisionPath, json)) {
33			result = {
34			success: 0,
35			error: 'cannot json save file'
36			}
37			}else {
38			Manager.instance.updatePostInList(revisionPath)
39			result = {
40			success: 1,
41			json: json
42			}
43			}
44			resolve(result)
45			})
46			})
47
48			return p
49			}
50
51			export function publish(filePath, json) {
52			var p = new Promise((resolve) => {
53			abeExtend.hooks.instance.trigger('beforePublish', json, filePath)
54
55			var revisionPath = path.join(config.root, config.data.url, filePath.replace(`.${config.files.templates.extension}`, '.json'))
56			var postPath = path.join(config.root, config.publish.url, filePath)
57			// revisionPath = coreUtils.file.addDateIsoToRevisionPath(revisionPath, workflow)
58			cmsData.metas.add(json, 'publish')
59
60			var template = cmsTemplates.template.getTemplate(json.abe_meta.template)
61
62			cmsData.source.getDataList(path.dirname(json.abe_meta.link), template, json)
63			.then(() => {
64			json['abe_meta'].complete = cmsData.utils.getPercentOfRequiredTagsFilled(template, json)
65
66			var page = new Page(json.abe_meta.template, template, json, true)
67
68			var result
69			if (!cmsOperations.save.saveHtml(postPath, page.html)) {
70			result = {
71			success: 0,
72			error: 'cannot html save file'
73			}
74			}else {
75			if (!cmsOperations.save.saveJson(revisionPath, json)) {
76			result = {
77			success: 0,
78			error: 'cannot json save file'
79			}
80			}else {
81			Manager.instance.updatePostInList(revisionPath)
82			result = {
83			success: 1,
84			json: json
85			}
86			}
87			}
88			resolve(result)
89			})
90			})
91
92			return p
93			}
94
95			export function unpublish(filePath) {
96			abeExtend.hooks.instance.trigger('beforeUnpublish', filePath)
97
98			var p = new Promise((resolve, reject) => {
99			var revisionPath = path.join(config.root, config.data.url, filePath.replace(`.${config.files.templates.extension}`, '.json'))
100			var postPath = path.join(config.root, config.publish.url, filePath)
101			if(coreUtils.file.exist(revisionPath)) {
102			var json = JSON.parse(JSON.stringify(cmsData.file.get(revisionPath)))
103			if(json.abe_meta.publish != null) {
104			delete json.abe_meta.publish
105			}
106
107			var p = draft(
108			filePath,
109			json,
110			'draft'
111			)
112
113			p.then((result) => {
114			cmsOperations.remove.removeFile(revisionPath, postPath)
115			abeExtend.hooks.instance.trigger('afterUnpublish', revisionPath, postPath)
116			var newRevisionPath = path.join(config.root, config.data.url, result.json.abe_meta.latest.abeUrl.replace(`.${config.files.templates.extension}`, '.json'))
117			Manager.instance.updatePostInList(newRevisionPath)
118			resolve(result)
119			}).catch(function(e) {
120			console.error('[ERROR] unpublish', e)
121			reject()
122			})
123			}
124			})
125
126			return p
127			}
128
129			export function reject(filePath, json, workflow) {
130			abeExtend.hooks.instance.trigger('beforeReject', filePath)
131
132			var rejectToWorkflow
133			var found = false
134			Array.prototype.forEach.call(config.users.workflow, (flow) => {
135			if (workflow === flow) {
136			found = true
137			}
138			if (!found) {
139			rejectToWorkflow = flow
140			}
141			})
142			if (!found) {
143			rejectToWorkflow = 'draft'
144			}
145
146			var p = new Promise((resolve) => {
147			if(json.abe_meta.publish != null) {
148			delete json.abe_meta.publish
149			}
150			var p2 = draft(
151			filePath,
152			json,
153			rejectToWorkflow
			0 ignored issues – show Bug introduced 2016-11-24 15:22 UTC by Report Bug Copy Issue Report The variable `rejectToWorkflow` does not seem to be initialized in case `!found` on line `142` is `false`. Are you sure the function `draft` handles `undefined` variables? Loading history...
154			)
155			p2.then((result) => {
156			abeExtend.hooks.instance.trigger('afterReject', result)
157			resolve(result)
158			}).catch(function(e) {
159			console.error('[ERROR] reject.js', e)
160			})
161			})
162
163			return p
164			}

AdFabConnect / abejs

Pull Request — master (#40)

post.js ➔ reject B

Complexity

Size

Duplication

Importance

1 Function

Duplication Side-by-Side

Filter issues like