image.js ➔ describe(ꞌimageꞌ) - Code Metrics - Inspection of "enhancement: image crop feature & refactoring uplo..." - AdFabConnect/abejs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#39)

unknown

created 2016-11-23 17:35 UTC

image.js ➔ describe(ꞌimageꞌ) B

↳ Parent: test/image.js

Complexity

Conditions	1
Paths	1

Size

Total Lines

121

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	121
rs	8.2857

7 Functions

Rating	Name	Size	Complexity
A	image.js ➔ ... ➔ it(ꞌcmsMedia.image.getThumbsList()ꞌ)	12	1
A	image.js ➔ ... ➔ after	4	1
A	image.js ➔ ... ➔ before	4	1
A	image.js ➔ ... ➔ it(ꞌcmsMedia.image.isValidMedia()ꞌ)	7	1
B	image.js ➔ ... ➔ it(ꞌcmsMedia.image.cropAndSaveFiles()ꞌ)	26	1
A	image.js ➔ ... ➔ it(ꞌcmsMedia.image.getAssociatedImageFileFromThumb()ꞌ)	13	1
A	image.js ➔ ... ➔ it(ꞌcmsMedia.image.generateThumbnail()ꞌ)	15	1

How to fix Long Method

import chai from'chai'
import sinonChai from'sinon-chai'
var expect = chai.expect
chai.use(sinonChai)
import sinon from 'sinon'
import path from 'path'
import {Promise} from 'bluebird'
import fse from 'fs-extra'
import events from 'events'
import {
  config,
  cmsMedia,
  coreUtils
} from '../src/cli'
config.set({root: path.join(__dirname,'fixtures')})

describe('image', function() {

  var pathToImage = path.join(config.root, config.publish.url, config.upload.image, 'chat-1.jpg');

  var imagesListInFolder = [
    path.join(config.root, config.publish.url, config.upload.image, 'img.jpg'),
    path.join(config.root, config.publish.url, config.upload.image, 'img_100x100.jpg'),
    path.join(config.root, config.publish.url, config.upload.image, 'img_10x10.jpg'),
    path.join(config.root, config.publish.url, config.upload.image, 'img_thumb.jpg')
  ];

  before(function(done) {
    fse.copySync(path.join(config.root, 'media'), config.root)
    done()
  });
  
  /**
   * cmsMedia.image.generateThumbnail
   * @todo : UNIT TEST this method
   * 
   */
  it('cmsMedia.image.generateThumbnail()', function(done) {
    // this.sinon = sinon.sandbox.create();
    // var stub = sinon.stub(cmsMedia.image, 'smartCropAndSaveFile')
    // stub.returns(Promise.resolve(0))
    // var thumb = cmsMedia.image.generateThumbnail(pathToImage)
    // thumb.then(function (result) {
    //   done()
    //   chai.expect(result).to.not.be.undefined
    //   chai.expect(result.thumb).to.not.be.undefined
    //   chai.expect(result.thumb).to.equal('/unitimage/chat-1_thumb.jpg')
    //   sinon.assert.calledOnce(cmsMedia.image.smartCropAndSaveFile)
    //   cmsMedia.image.smartCropAndSaveFile.restore()
    // })
    done()
  });

  /**
   * cmsMedia.image.cropAndSaveFiles
   * @todo : UNIT TEST this method
   * 
   */
  it('cmsMedia.image.cropAndSaveFiles()', function(done) {
    // this.sinon = sinon.sandbox.create();
    // var stub = sinon.stub(cmsMedia.image, 'smartCropAndSaveFile')
    // stub.returns(Promise.resolve({
    //   'stdout': false,
    //   'stderr': false
    // }))
    // var thumbs = cmsMedia.image.cropAndSaveFiles(['10x10'], pathToImage, {})
    
    // thumbs.then(function (result) {
    //   console.log("result", result)
    //   chai.expect(result).to.not.be.undefined
    //   chai.expect(result.thumbs).to.have.length(1)
    //   chai.expect(result.thumbs[0]).to.have.property('name').to.equal('/unitimage/chat-1_10x10.jpg')
    //   chai.expect(result.thumbs[0]).to.have.property('size').to.equal('10x10')
    //   sinon.assert.calledOnce(cmsMedia.image.smartCropAndSaveFile)
    //   cmsMedia.image.smartCropAndSaveFile.restore()

    //   done()
    // })
    // .catch(function (err) {
    //   console.log("catch", err)
    //   done()
    // })
    done()
  });

  /**
   * cmsMedia.image.getThumbsList
   * 
   */
  it('cmsMedia.image.getThumbsList()', function() {
    this.sinon = sinon.sandbox.create();
    var stub = sinon.stub(coreUtils.file, 'getFilesSync')
    stub.returns(imagesListInFolder)
    var result = cmsMedia.image.getThumbsList()
    chai.expect(result).to.not.be.undefined

    chai.expect(result).to.have.length(1)
    chai.expect(result[0]).to.have.property('originalFile').to.equal('/unitimage/img.jpg')
    chai.expect(result[0]).to.have.property('thumbFile').to.equal('/unitimage/img_thumb.jpg')
    sinon.assert.calledOnce(coreUtils.file.getFilesSync)
    coreUtils.file.getFilesSync.restore()
  });

  /**
   * cmsMedia.image.getAssociatedImageFileFromThumb
   * 
   */
  it('cmsMedia.image.getAssociatedImageFileFromThumb()', function() {
    this.sinon = sinon.sandbox.create();
    var stub = sinon.stub(coreUtils.file, 'getFilesSync')
    stub.returns(imagesListInFolder)
    var result = cmsMedia.image.getAssociatedImageFileFromThumb('/unitimage/img_thumb.jpg')
    chai.expect(result).to.not.be.undefined

    chai.expect(result).to.have.property('originalFile').to.equal('/unitimage/img.jpg')
    chai.expect(result).to.have.property('thumbFile').to.equal('/unitimage/img_thumb.jpg')
    chai.expect(result.thumbs).to.have.length(2)
    chai.expect(result.thumbs[0]).to.equal('/unitimage/img_100x100.jpg')
    sinon.assert.calledOnce(coreUtils.file.getFilesSync)
    coreUtils.file.getFilesSync.restore()
  });

  /**
   * cmsMedia.image.isValidMedia
   * 
   */
  it('cmsMedia.image.isValidMedia()', function() {
    var result = cmsMedia.image.isValidMedia('image/jpeg', '.jpg')
    var result2 = cmsMedia.image.isValidMedia('wrong/mimetype', '.exe')
    chai.expect(result.error).to.equal(false)
    chai.expect(result2.error).to.be.a('string')
    chai.expect(result2.error).to.equal('unauthorized file')
  });

  after(function(done) {
    fse.remove(path.join(config.root, config.publish.url))
    done()
  });
  
});


1			import chai from'chai'
2			import sinonChai from'sinon-chai'
3			var expect = chai.expect
4			chai.use(sinonChai)
5			import sinon from 'sinon'
6			import path from 'path'
7			import {Promise} from 'bluebird'
8			import fse from 'fs-extra'
9			import events from 'events'
10			import {
11			config,
12			cmsMedia,
13			coreUtils
14			} from '../src/cli'
15			config.set({root: path.join(__dirname,'fixtures')})
16
17			describe('image', function() {
18
19			var pathToImage = path.join(config.root, config.publish.url, config.upload.image, 'chat-1.jpg');
			0 ignored issues – show Unused Code introduced 2016-11-23 17:37 UTC by Report Bug Copy Issue Report The variable `pathToImage` seems to be never used. Consider removing it. Loading history...
20			var imagesListInFolder = [
21			path.join(config.root, config.publish.url, config.upload.image, 'img.jpg'),
22			path.join(config.root, config.publish.url, config.upload.image, 'img_100x100.jpg'),
23			path.join(config.root, config.publish.url, config.upload.image, 'img_10x10.jpg'),
24			path.join(config.root, config.publish.url, config.upload.image, 'img_thumb.jpg')
25			];
26
27			before(function(done) {
28			fse.copySync(path.join(config.root, 'media'), config.root)
29			done()
30			});
31
32			/**
33			* cmsMedia.image.generateThumbnail
34			* @todo : UNIT TEST this method
35			*
36			*/
37			it('cmsMedia.image.generateThumbnail()', function(done) {
38			// this.sinon = sinon.sandbox.create();
39			// var stub = sinon.stub(cmsMedia.image, 'smartCropAndSaveFile')
40			// stub.returns(Promise.resolve(0))
41			// var thumb = cmsMedia.image.generateThumbnail(pathToImage)
42			// thumb.then(function (result) {
43			// done()
44			// chai.expect(result).to.not.be.undefined
45			// chai.expect(result.thumb).to.not.be.undefined
46			// chai.expect(result.thumb).to.equal('/unitimage/chat-1_thumb.jpg')
47			// sinon.assert.calledOnce(cmsMedia.image.smartCropAndSaveFile)
48			// cmsMedia.image.smartCropAndSaveFile.restore()
49			// })
50			done()
51			});
52
53			/**
54			* cmsMedia.image.cropAndSaveFiles
55			* @todo : UNIT TEST this method
56			*
57			*/
58			it('cmsMedia.image.cropAndSaveFiles()', function(done) {
59			// this.sinon = sinon.sandbox.create();
60			// var stub = sinon.stub(cmsMedia.image, 'smartCropAndSaveFile')
61			// stub.returns(Promise.resolve({
62			// 'stdout': false,
63			// 'stderr': false
64			// }))
65			// var thumbs = cmsMedia.image.cropAndSaveFiles(['10x10'], pathToImage, {})
66
67			// thumbs.then(function (result) {
68			// console.log("result", result)
69			// chai.expect(result).to.not.be.undefined
70			// chai.expect(result.thumbs).to.have.length(1)
71			// chai.expect(result.thumbs[0]).to.have.property('name').to.equal('/unitimage/chat-1_10x10.jpg')
72			// chai.expect(result.thumbs[0]).to.have.property('size').to.equal('10x10')
73			// sinon.assert.calledOnce(cmsMedia.image.smartCropAndSaveFile)
74			// cmsMedia.image.smartCropAndSaveFile.restore()
75
76			// done()
77			// })
78			// .catch(function (err) {
79			// console.log("catch", err)
80			// done()
81			// })
82			done()
83			});
84
85			/**
86			* cmsMedia.image.getThumbsList
87			*
88			*/
89			it('cmsMedia.image.getThumbsList()', function() {
90			this.sinon = sinon.sandbox.create();
91			var stub = sinon.stub(coreUtils.file, 'getFilesSync')
92			stub.returns(imagesListInFolder)
93			var result = cmsMedia.image.getThumbsList()
94			chai.expect(result).to.not.be.undefined
			0 ignored issues – show introduced 2016-11-23 17:37 UTC by Report Bug Copy Issue Report The result of the property access to `chai.expect(result).to.not.be.undefined` is not used. Loading history...
95			chai.expect(result).to.have.length(1)
96			chai.expect(result[0]).to.have.property('originalFile').to.equal('/unitimage/img.jpg')
97			chai.expect(result[0]).to.have.property('thumbFile').to.equal('/unitimage/img_thumb.jpg')
98			sinon.assert.calledOnce(coreUtils.file.getFilesSync)
99			coreUtils.file.getFilesSync.restore()
100			});
101
102			/**
103			* cmsMedia.image.getAssociatedImageFileFromThumb
104			*
105			*/
106			it('cmsMedia.image.getAssociatedImageFileFromThumb()', function() {
107			this.sinon = sinon.sandbox.create();
108			var stub = sinon.stub(coreUtils.file, 'getFilesSync')
109			stub.returns(imagesListInFolder)
110			var result = cmsMedia.image.getAssociatedImageFileFromThumb('/unitimage/img_thumb.jpg')
111			chai.expect(result).to.not.be.undefined
			0 ignored issues – show introduced 2016-11-23 17:37 UTC by Report Bug Copy Issue Report The result of the property access to `chai.expect(result).to.not.be.undefined` is not used. Loading history...
112			chai.expect(result).to.have.property('originalFile').to.equal('/unitimage/img.jpg')
113			chai.expect(result).to.have.property('thumbFile').to.equal('/unitimage/img_thumb.jpg')
114			chai.expect(result.thumbs).to.have.length(2)
115			chai.expect(result.thumbs[0]).to.equal('/unitimage/img_100x100.jpg')
116			sinon.assert.calledOnce(coreUtils.file.getFilesSync)
117			coreUtils.file.getFilesSync.restore()
118			});
119
120			/**
121			* cmsMedia.image.isValidMedia
122			*
123			*/
124			it('cmsMedia.image.isValidMedia()', function() {
125			var result = cmsMedia.image.isValidMedia('image/jpeg', '.jpg')
126			var result2 = cmsMedia.image.isValidMedia('wrong/mimetype', '.exe')
127			chai.expect(result.error).to.equal(false)
128			chai.expect(result2.error).to.be.a('string')
129			chai.expect(result2.error).to.equal('unauthorized file')
130			});
131
132			after(function(done) {
133			fse.remove(path.join(config.root, config.publish.url))
134			done()
135			});
136
137			});
138

AdFabConnect / abejs

Pull Request — master (#39)

image.js ➔ describe(ꞌimageꞌ) B

Complexity

Size

Duplication

Importance

7 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like