| Conditions | 1 |
| Paths | 1 |
| Total Lines | 143 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | var chai = require('chai'); |
||
| 4 | describe("Helpers", function () { |
||
| 5 | describe("lowercase", function () { |
||
| 6 | it('properly lowercase string', function() { |
||
| 7 | var value = 'ThiS IS mY String', |
||
| 8 | rendered = Handlebars.helpers.lowercase(value), |
||
| 9 | expected = 'this is my string'; |
||
| 10 | chai.expect(rendered).to.eql(expected); |
||
| 11 | }); |
||
| 12 | it('properly return empty string', function() { |
||
| 13 | var value = null, |
||
| 14 | rendered = Handlebars.helpers.lowercase(value), |
||
| 15 | expected = ''; |
||
| 16 | chai.expect(rendered).to.eql(expected); |
||
| 17 | }); |
||
| 18 | }); |
||
| 19 | describe("uppercase", function () { |
||
| 20 | it('properly uppercase string', function() { |
||
| 21 | var value = 'ThiS IS mY String', |
||
| 22 | rendered = Handlebars.helpers.uppercase(value), |
||
| 23 | expected = 'THIS IS MY STRING'; |
||
| 24 | chai.expect(rendered).to.eql(expected); |
||
| 25 | }); |
||
| 26 | it('properly return empty string', function() { |
||
| 27 | var value = null, |
||
| 28 | rendered = Handlebars.helpers.uppercase(value), |
||
| 29 | expected = ''; |
||
| 30 | chai.expect(rendered).to.eql(expected); |
||
| 31 | }); |
||
| 32 | }); |
||
| 33 | describe("truncate", function () { |
||
| 34 | it('properly truncate string', function() { |
||
| 35 | var value = 'ThiS IS mY String', |
||
| 36 | length = 10, |
||
| 37 | rendered = Handlebars.helpers.truncate(value, length), |
||
| 38 | expected = 'ThiS IS mY...'; |
||
| 39 | chai.expect(rendered).to.eql(expected); |
||
| 40 | }); |
||
| 41 | it('properly return full string', function() { |
||
| 42 | var value = 'ThiS IS mY String', |
||
| 43 | length = 20, |
||
| 44 | rendered = Handlebars.helpers.truncate(value, length), |
||
| 45 | expected = 'ThiS IS mY String'; |
||
| 46 | chai.expect(rendered).to.eql(expected); |
||
| 47 | }); |
||
| 48 | it('properly return empty string', function() { |
||
| 49 | var value = null, |
||
| 50 | length = 10, |
||
| 51 | rendered = Handlebars.helpers.truncate(value, length), |
||
| 52 | expected = ''; |
||
| 53 | chai.expect(rendered).to.eql(expected); |
||
| 54 | }); |
||
| 55 | }); |
||
| 56 | describe("isTrue", function () { |
||
| 57 | it('properly eval ==', function() { |
||
| 58 | var value1 = 'str1', |
||
| 59 | operator = '==', |
||
| 60 | value2 = 'str1', |
||
| 61 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 62 | expected = true; |
||
| 63 | chai.expect(rendered).to.eql(expected); |
||
| 64 | }); |
||
| 65 | it('properly eval ==', function() { |
||
| 66 | var value1 = 'str1', |
||
| 67 | operator = '==', |
||
| 68 | value2 = 'str2', |
||
| 69 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 70 | expected = false; |
||
| 71 | chai.expect(rendered).to.eql(expected); |
||
| 72 | }); |
||
| 73 | it('properly eval ===', function() { |
||
| 74 | var value1 = '1', |
||
| 75 | operator = '===', |
||
| 76 | value2 = 1, |
||
| 77 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 78 | expected = false; |
||
| 79 | chai.expect(rendered).to.eql(expected); |
||
| 80 | }); |
||
| 81 | it('properly eval <', function() { |
||
| 82 | var value1 = 1, |
||
| 83 | operator = '<', |
||
| 84 | value2 = 10, |
||
| 85 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 86 | expected = true; |
||
| 87 | chai.expect(rendered).to.eql(expected); |
||
| 88 | }); |
||
| 89 | it('properly eval <=', function() { |
||
| 90 | var value1 = 10, |
||
| 91 | operator = '<=', |
||
| 92 | value2 = 10, |
||
| 93 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 94 | expected = true; |
||
| 95 | chai.expect(rendered).to.eql(expected); |
||
| 96 | }); |
||
| 97 | it('properly eval &&', function() { |
||
| 98 | var value1 = null, |
||
| 99 | operator = '&&', |
||
| 100 | value2 = 10, |
||
| 101 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 102 | expected = false; |
||
| 103 | chai.expect(rendered).to.eql(expected); |
||
| 104 | }); |
||
| 105 | it('properly eval &&', function() { |
||
| 106 | var value1 = [], |
||
| 107 | operator = '&&', |
||
| 108 | value2 = 10, |
||
| 109 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 110 | expected = false; |
||
| 111 | chai.expect(rendered).to.eql(expected); |
||
| 112 | }); |
||
| 113 | it('properly eval &&', function() { |
||
| 114 | var value1 = {"var":"1"}, |
||
| 115 | operator = '&&', |
||
| 116 | value2 = {"other":"1"}, |
||
| 117 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 118 | expected = true; |
||
| 119 | chai.expect(rendered).to.eql(expected); |
||
| 120 | }); |
||
| 121 | it('properly eval ||', function() { |
||
| 122 | var value1 = null, |
||
| 123 | operator = '||', |
||
| 124 | value2 = 10, |
||
| 125 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 126 | expected = true; |
||
| 127 | chai.expect(rendered).to.eql(expected); |
||
| 128 | }); |
||
| 129 | it('properly eval ||', function() { |
||
| 130 | var value1 = [], |
||
| 131 | operator = '||', |
||
| 132 | value2 = null, |
||
| 133 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 134 | expected = false; |
||
| 135 | chai.expect(rendered).to.eql(expected); |
||
| 136 | }); |
||
| 137 | it('properly eval ||', function() { |
||
| 138 | var value1 = false, |
||
| 139 | operator = '||', |
||
| 140 | value2 = 4, |
||
| 141 | rendered = Handlebars.helpers.isTrue(value1, operator, value2), |
||
| 142 | expected = true; |
||
| 143 | chai.expect(rendered).to.eql(expected); |
||
| 144 | }); |
||
| 145 | }); |
||
| 146 | }); |