Abo-khalaf / weather_package

src/ControllerIP/IpValidate.php

<?php

namespace Moody\ControllerIP;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

// use Anax\Route\Exception\ForbiddenException;
// use Anax\Route\Exception\NotFoundException;
// use Anax\Route\Exception\InternalErrorException;

/**
 * A sample controller to show how a controller class can be implemented.
 * The controller will be injected with $di if implementing the interface
 * ContainerInjectableInterface, like this sample class does.
 * The controller is mounted on a particular route and can then handle all
 * requests for that mount point.
 *
 * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */




class IpValidate implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    /**
     * Check if IP is valid or not.
     * GET ip
     *
     * @return string
     */

    public function getProtocol($ipAddress)
    {
        if (filter_var($ipAddress, FILTER_VALIDATE_IP)) {
            if (filter_var($ipAddress, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {
                return "IPv4";
            }
            if (filter_var($ipAddress, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
                return "IPv6";
            }
        }
        return false;

The expression return false returns the type false which is incompatible with the documented return type string.

    }
        /**
    * Check if IP is valid or not.
    * GET  domain
    *
    * @return string
    */
    public function getDomain($ipAddress)
    {
        if (filter_var($ipAddress, FILTER_VALIDATE_IP)) {
            return gethostbyaddr($ipAddress);
        }
        return "Not valid";
    }

    public function getCurrentIp()
    {
        return $_SERVER["193.11.187.229"] ?? '193.11.187.229';
    }



    public function getAddress($ipAddress)
    {
        $the_access_key = "9ffbd83fca588b355bff399b8da7526f";
        $theUrl  = "http://api.ipstack.com/";
        $req = curl_init($theUrl . $ipAddress . "?access_key=" . $the_access_key . '');
        curl_setopt($req, CURLOPT_RETURNTRANSFER, true);

It seems like $req can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        $json = curl_exec($req);

It seems like $req can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        curl_close($req);

It seems like $req can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        $result = json_decode($json, 'JAON_PRETTY_PRINT');

'JAON_PRETTY_PRINT' of type string is incompatible with the type boolean expected by parameter $assoc of json_decode().

        return $result;
    }
}