Issues in interface.php (master) - Issues in master - ATM-Consulting/dolibarr_module_subtotal - Measure and Improve Code Quality continuously with Scrutinizer

Issues (358)

script/interface.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

	if (! defined('NOTOKENRENEWAL')) define('NOTOKENRENEWAL', 1);

	require '../config.php';

	dol_include_once('/subtotal/lib/subtotal.lib.php');
	dol_include_once('/subtotal/class/subtotal.class.php');
	dol_include_once('/comm/propal/class/propal.class.php');
	dol_include_once('/commande/class/commande.class.php');
	dol_include_once('/compta/facture/class/facture.class.php');
	dol_include_once('/fourn/class/fournisseur.commande.class.php');
	dol_include_once('/supplier_proposal/class/supplier_proposal.class.php');
	dol_include_once('/fourn/class/fournisseur.facture.class.php');

	$get=GETPOST('get', 'none');
	$set=GETPOST('set', 'none');

	switch ($get) {
		default:
			break;
	}

	switch ($set) {
		case 'updateLineNC': // Gestion du Compris/Non Compris via les titres et/ou lignes
			echo json_encode( _updateLineNC(GETPOST('element', 'none'), GETPOST('elementid', 'none'), GETPOST('lineid', 'none'), GETPOST('subtotal_nc', 'none')) );
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

			break;
		default:
			break;
	}


1			<?php
2
3			if (! defined('NOTOKENRENEWAL')) define('NOTOKENRENEWAL', 1);
4
5			require '../config.php';
6
7			dol_include_once('/subtotal/lib/subtotal.lib.php');
8			dol_include_once('/subtotal/class/subtotal.class.php');
9			dol_include_once('/comm/propal/class/propal.class.php');
10			dol_include_once('/commande/class/commande.class.php');
11			dol_include_once('/compta/facture/class/facture.class.php');
12			dol_include_once('/fourn/class/fournisseur.commande.class.php');
13			dol_include_once('/supplier_proposal/class/supplier_proposal.class.php');
14			dol_include_once('/fourn/class/fournisseur.facture.class.php');
15
16			$get=GETPOST('get', 'none');
17			$set=GETPOST('set', 'none');
18
19			switch ($get) {
20			default:
21			break;
22			}
23
24			switch ($set) {
25			case 'updateLineNC': // Gestion du Compris/Non Compris via les titres et/ou lignes
26			echo json_encode( _updateLineNC(GETPOST('element', 'none'), GETPOST('elementid', 'none'), GETPOST('lineid', 'none'), GETPOST('subtotal_nc', 'none')) );
			0 ignored issues – show Bug introduced 2022-05-23 15:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `_updateLineNC(GETPOST('e...'subtotal_nc', 'none'))` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
27
28			break;
29			default:
30			break;
31			}
32

ATM-Consulting / dolibarr_module_subtotal

Issues (358)

script/interface.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like