ATM-Consulting / dolibarr_module_subtotal

core/triggers/interface_90_modSubtotal_subtotaltrigger.class.php

Braces +58 added lines, -27 removed lines

@@ -89,12 +89,14 @@ 
 
         if ($this->version == 'development') {
             return $langs->trans("Development");
-        } elseif ($this->version == 'experimental')
-
+        } elseif ($this->version == 'experimental') {
+        
                 return $langs->trans("Experimental");
-        elseif ($this->version == 'dolibarr') return DOL_VERSION;
-        elseif ($this->version) return $this->version;
-        else {
+        } elseif ($this->version == 'dolibarr') {
+        	return DOL_VERSION;
+        } elseif ($this->version) {
+        	return $this->version;
+        } else {
             return $langs->trans("Unknown");
         }
     }
@@ -122,14 +124,18 @@ 
 		$subtotal_line_found = false;
 		foreach ($parent->lines as $k => &$line)
 		{
-			if ($line->rang < $rang) continue;
-			elseif ($line->rang == $rang) // Je suis sur la ligne de titre où je souhaite ajouter ma nouvelle ligne en fin de bloc
+			if ($line->rang < $rang) {
+				continue;
+			} elseif ($line->rang == $rang) {
+				// Je suis sur la ligne de titre où je souhaite ajouter ma nouvelle ligne en fin de bloc
 			{
 				$title_level = $line->qty;
 			}
-			elseif (!$subtotal_line_found && $title_level > -1 && ($line->qty == 100 - $title_level)) // Le level de mon titre a été trouvé avant, donc maintenant je vais m'arrêter jusqu'à trouver un sous-total
+			} elseif (!$subtotal_line_found && $title_level > -1 && ($line->qty == 100 - $title_level)) {
+				// Le level de mon titre a été trouvé avant, donc maintenant je vais m'arrêter jusqu'à trouver un sous-total
 			{
 				$subtotal_line_found = true;
+			}
 				$rang = $line->rang;
 			}
 			
@@ -191,8 +197,11 @@ 
 						break;
 				}
 				
-				if (!empty($conf->global->SUBTOTAL_ADD_LINE_UNDER_TITLE_AT_END_BLOCK)) $this->addToEnd($parent, $object, $rang);
-				else $this->addToBegin($parent, $object, $rang);
+				if (!empty($conf->global->SUBTOTAL_ADD_LINE_UNDER_TITLE_AT_END_BLOCK)) {
+					$this->addToEnd($parent, $object, $rang);
+				} else {
+					$this->addToBegin($parent, $object, $rang);
+				}
 				
 			}
 			
@@ -220,7 +229,9 @@ 
 						$commande->fetch($current_fk_commande);
 						
 						$label = $conf->global->SUBTOTAL_TEXT_FOR_TITLE_ORDETSTOINVOICE;
-						if (empty($label)) $label = 'Commande [__REFORDER__] - Référence client : [__REFCUSTOMER__]';
+						if (empty($label)) {
+							$label = 'Commande [__REFORDER__] - Référence client : [__REFCUSTOMER__]';
+						}
 						$label = str_replace(array('__REFORDER__', '__REFCUSTOMER__'), array($commande->ref, $commande->ref_client), $label);
 						
 						TSubtotal::addTitle($facture, $label, 1, $rang);
@@ -271,10 +282,15 @@ 
 						$object->total_ht = $object->total_tva = $object->total_ttc = $object->total_localtax1 = $object->total_localtax2 = 
 							$object->multicurrency_total_ht = $object->multicurrency_total_tva = $object->multicurrency_total_ttc = 0;
 
-						if ($object->element == 'propal') $res = $object->update(1);
-						else $res = $object->update($user, 1);
+						if ($object->element == 'propal') {
+							$res = $object->update(1);
+						} else {
+							$res = $object->update($user, 1);
+						}
 						
-						if ($res > 0) setEventMessage($langs->trans('subtotal_update_nc_success'));
+						if ($res > 0) {
+							setEventMessage($langs->trans('subtotal_update_nc_success'));
+						}
 						break;
 					}
 				}
@@ -284,10 +300,15 @@ 
 					$object->total_ht = $object->total_tva = $object->total_ttc = $object->total_localtax1 = $object->total_localtax2 = 
 							$object->multicurrency_total_ht = $object->multicurrency_total_tva = $object->multicurrency_total_ttc = 0;
 
-					if ($object->element == 'propaldet') $res = $object->update(1);
-					else $res = $object->update($user, 1);
+					if ($object->element == 'propaldet') {
+						$res = $object->update(1);
+					} else {
+						$res = $object->update($user, 1);
+					}
 
-					if ($res > 0) setEventMessage($langs->trans('subtotal_update_nc_success'));
+					if ($res > 0) {
+						setEventMessage($langs->trans('subtotal_update_nc_success'));
+					}
 				}
 			}
 		}
@@ -484,26 +505,38 @@ 
 				);
 				
 				// En fonction de l'objet et de la version, les lignes conservent l'id de l'objet d'origine
-				if (method_exists($object, 'fetch_lines')) $object->fetch_lines();
-				else $object->fetch($object->id);
+				if (method_exists($object, 'fetch_lines')) {
+					$object->fetch_lines();
+				} else {
+					$object->fetch($object->id);
+				}
 			
 				foreach ($object->lines as &$line)
 				{
-					if (empty($line->array_options)) $line->fetch_optionals();
+					if (empty($line->array_options)) {
+						$line->fetch_optionals();
+					}
 					
 					if (!TSubtotal::isModSubtotalLine($line) && !empty($line->array_options['options_subtotal_nc']))
 					{
 						$line->total_ht = $line->total_tva = $line->total_ttc = $line->total_localtax1 = $line->total_localtax2 = 
 							$line->multicurrency_total_ht = $line->multicurrency_total_tva = $line->multicurrency_total_ttc = 0;
 
-						if ($line->element == 'propaldet') $res = $line->update(1);
-						else $res = $line->update($user, 1);
+						if ($line->element == 'propaldet') {
+							$res = $line->update(1);
+						} else {
+							$res = $line->update($user, 1);
+						}
 						
-						if ($res > 0) setEventMessage($langs->trans('subtotal_update_nc_success'));
+						if ($res > 0) {
+							setEventMessage($langs->trans('subtotal_update_nc_success'));
+						}
 					}
 				}
 				
-				if (!empty($line)) $object->update_price(1);
+				if (!empty($line)) {
+					$object->update_price(1);
+				}
 			}
 			
         } elseif ($action == 'PROPAL_MODIFY') {
@@ -573,9 +606,7 @@ 
             dol_syslog(
                 "Trigger '" . $this->name . "' for action '$action' launched by " . __FILE__ . ". id=" . $object->id
             );
-        }
-
-		elseif ($action == 'BILL_MODIFY') {
+        } elseif ($action == 'BILL_MODIFY') {
             dol_syslog(
                 "Trigger '" . $this->name . "' for action '$action' launched by " . __FILE__ . ". id=" . $object->id
             );

lib/subtotal.lib.php

Braces +56 added lines, -27 removed lines

@@ -54,7 +54,9 @@ 
 	dol_include_once('/subtotal/class/subtotal.class.php');
 	$TTitle = TSubtotal::getAllTitleFromDocument($object);
 	$html = '';
-	if ($showLabel) $html.= '<label for="under_title">'.$langs->trans('subtotalLabelForUnderTitle').'</label>';
+	if ($showLabel) {
+		$html.= '<label for="under_title">'.$langs->trans('subtotalLabelForUnderTitle').'</label>';
+	}
 	$html.= '<select onChange="$(\'select[name=under_title]\').val(this.value);" name="under_title" class="under_title minwidth200"><option value="-1"></option>';
 	
 	$nbsp = '&nbsp;';
@@ -95,7 +97,9 @@ 
 	$TFreeText = getTFreeText();
 	$html = '<label for="free_text">'.$langs->trans('subtotalLabelForFreeText').'</label>';
 	$html.= '<select onChange="getTFreeText($(this));" name="free_text" class="minwidth200">';
-	if ($withEmpty) $html.= '<option value=""></option>';
+	if ($withEmpty) {
+		$html.= '<option value=""></option>';
+	}
 
 	$TFreeTextContents = array();
 	foreach ($TFreeText as $id => $tab)
@@ -134,8 +138,13 @@ 
 	$level = GETPOST('subtotal_level', 'int');
 	if (!empty($level))
 	{
-		if ($line->qty > 90) $line->qty = 100 - $level; // Si on edit une ligne sous-total
-		else $line->qty = $level;
+		if ($line->qty > 90) {
+			$line->qty = 100 - $level;
+		}
+		// Si on edit une ligne sous-total
+		else {
+			$line->qty = $level;
+		}
 	}
 	
 	$res = TSubtotal::doUpdateLine($object, $line->id, $description, 0, $line->qty, 0, '', '', 0, 9, 0, 0, 'HT', $pagebreak, 0, 1, null, 0, $label, TSubtotal::$module_number, $line->array_options);
@@ -162,13 +171,18 @@ 
 			{
 				$subtotal_tva_tx = $subtotal_tva_tx_init; // ré-init car la variable peut évoluer
 					
-				if (!empty($showBlockExtrafields)) $line->array_options = $array_options;
-				if ($subtotal_tva_tx == '') $subtotal_tva_tx = $line->tva_tx;
+				if (!empty($showBlockExtrafields)) {
+					$line->array_options = $array_options;
+				}
+				if ($subtotal_tva_tx == '') {
+					$subtotal_tva_tx = $line->tva_tx;
+				}
 				if ($object->element == 'facture' && !empty($conf->global->INVOICE_USE_SITUATION) && $object->type == Facture::TYPE_SITUATION)
 				{
 					$subtotal_progress = $subtotal_progress_init;
-					if ($subtotal_progress == '') $subtotal_progress = $line->situation_percent;
-					else
+					if ($subtotal_progress == '') {
+						$subtotal_progress = $line->situation_percent;
+					} else
 					{
 						$prev_percent = $line->get_prev_progress($object->id);
 						if ($subtotal_progress < $prev_percent)
@@ -181,14 +195,21 @@ 
 				
 				$res = TSubtotal::doUpdateLine($object, $line->id, $line->desc, $line->subprice, $line->qty, $line->remise_percent, $line->date_start, $line->date_end, $subtotal_tva_tx, $line->product_type, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits, $line->fk_parent_line, $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label, $line->special_code, $line->array_options, $subtotal_progress, $line->fk_unit);
 
-				if ($res > 0) $success_updated_line++;
-				else $error_updated_line++;
+				if ($res > 0) {
+					$success_updated_line++;
+				} else {
+					$error_updated_line++;
+				}
 			}
 		}
 
-		if ($nb_progress_not_updated > 0) setEventMessage($langs->trans('subtotal_nb_progress_not_updated', $nb_progress_not_updated), 'warnings');
+		if ($nb_progress_not_updated > 0) {
+			setEventMessage($langs->trans('subtotal_nb_progress_not_updated', $nb_progress_not_updated), 'warnings');
+		}
 		
-		if ($success_updated_line > 0) setEventMessage($langs->trans('subtotal_success_updated_line', $success_updated_line));
+		if ($success_updated_line > 0) {
+			setEventMessage($langs->trans('subtotal_success_updated_line', $success_updated_line));
+		}
 		if ($error_updated_line > 0)
 		{
 			setEventMessage($langs->trans('subtotal_error_updated_line', $error_updated_line), 'errors');
@@ -226,21 +247,25 @@ 
 	global $db,$langs,$tmp_object_nc;
 	
 	$error = 0;
-	if (empty($element)) $error++;
+	if (empty($element)) {
+		$error++;
+	}
 	
 	if (!$error)
 	{
 		if (!empty($tmp_object_nc) && $tmp_object_nc->element == $element && $tmp_object_nc->id == $elementid)
 		{
 			$object = $tmp_object_nc;
-		}
-		else
+		} else
 		{
 			$classname = ucfirst($element);
 			$object = new $classname($db); // Propal | Commande | Facture
 			$res = $object->fetch($elementid);
-			if ($res < 0) $error++;
-			else $tmp_object_nc = $object;
+			if ($res < 0) {
+				$error++;
+			} else {
+				$tmp_object_nc = $object;
+			}
 		}
 	}
 	
@@ -268,21 +293,21 @@ 
 						$res = doUpdate($object, $line_block, $subtotal_nc);
 					}
 				}
-			}
-			else
+			} else
 			{
 				$res = doUpdate($object, $line, $subtotal_nc);
 			}
 			
 			$res = $object->update_price(1);
-			if ($res <= 0) $error++;
+			if ($res <= 0) {
+				$error++;
+			}
 			
 			if (!$error)
 			{
 				setEventMessage($langs->trans('subtotal_update_nc_success'));
 				$db->commit();
-			}
-			else
+			} else
 			{
 				setEventMessage($langs->trans('subtotal_update_nc_error'), 'errors');
 				$db->rollback();
@@ -295,7 +320,9 @@ 
 {
 	global $user;
 	
-	if (TSubtotal::isFreeText($line) || TSubtotal::isSubtotal($line)) return 1;
+	if (TSubtotal::isFreeText($line) || TSubtotal::isSubtotal($line)) {
+		return 1;
+	}
 	// Update extrafield et total
 	if(! empty($subtotal_nc)) {
 		$line->total_ht = $line->total_tva = $line->total_ttc = $line->total_localtax1 = $line->total_localtax2 = 
@@ -303,10 +330,12 @@ 
 
 		$line->array_options['options_subtotal_nc'] = 1;
 
-		if ($line->element == 'propaldet') $res = $line->update();
-		else $res = $line->update($user);
-	}
-	else {
+		if ($line->element == 'propaldet') {
+			$res = $line->update();
+		} else {
+			$res = $line->update($user);
+		}
+	} else {
 		$line->array_options['options_subtotal_nc'] = 0;
 		$res = TSubtotal::doUpdateLine($object, $line->id, $line->desc, $line->subprice, $line->qty, $line->remise_percent, $line->date_start, $line->date_end, $line->tva_tx, $line->product_type, $line->localtax1_tx, $line->localtax2_tx, 'HT', $line->info_bits, $line->fk_parent_line, $line->skip_update_total, $line->fk_fournprice, $line->pa_ht, $line->label, $line->special_code, $line->array_options, $line->situation_percent, $line->fk_unit);
 	}