ATM-Consulting / dolibarr_module_subtotal

class/actions_subtotal.class.php

Braces +353 added lines, -215 removed lines

@@ -75,8 +75,11 @@ 
 			if ($object->statut == 0  && $createRight) {
 			
 
-				if($object->element=='facture')$idvar = 'facid';
-				else $idvar='id';
+				if($object->element=='facture') {
+					$idvar = 'facid';
+				} else {
+					$idvar='id';
+				}
 				
 				if(in_array($action, array('add_title_line', 'add_total_line', 'add_subtitle_line', 'add_subtotal_line', 'add_free_text')) )
 				{
@@ -84,10 +87,11 @@ 
 					
 					if($action=='add_title_line') {
 						$title = GETPOST('title');
-						if(empty($title)) $title = $langs->trans('title');
+						if(empty($title)) {
+							$title = $langs->trans('title');
+						}
 						$qty = $level<1 ? 1 : $level ;
-					}
-					else if($action=='add_free_text') {
+					} else if($action=='add_free_text') {
 						$title = GETPOST('title');
 
 						if (empty($title)) {
@@ -99,29 +103,31 @@ 
 								}
 							}
 						}
-						if(empty($title)) $title = $langs->trans('subtotalAddLineDescription');
+						if(empty($title)) {
+							$title = $langs->trans('subtotalAddLineDescription');
+						}
 						$qty = 50;
-					}
-					else if($action=='add_subtitle_line') {
+					} else if($action=='add_subtitle_line') {
 						$title = GETPOST('title');
-						if(empty($title)) $title = $langs->trans('subtitle');
+						if(empty($title)) {
+							$title = $langs->trans('subtitle');
+						}
 						$qty = 2;
-					}
-					else if($action=='add_subtotal_line') {
+					} else if($action=='add_subtotal_line') {
 						$title = $langs->trans('SubSubTotal');
 						$qty = 98;
-					}
-					else {
+					} else {
 						$title = GETPOST('title') ? GETPOST('title') : $langs->trans('SubTotal');
 						$qty = $level ? 100-$level : 99;
 					}
 					dol_include_once('/subtotal/class/subtotal.class.php');
 					
-					if (!empty($conf->global->SUBTOTAL_AUTO_ADD_SUBTOTAL_ON_ADDING_NEW_TITLE) && $qty < 10) TSubtotal::addSubtotalMissing($object, $qty);
+					if (!empty($conf->global->SUBTOTAL_AUTO_ADD_SUBTOTAL_ON_ADDING_NEW_TITLE) && $qty < 10) {
+						TSubtotal::addSubtotalMissing($object, $qty);
+					}
 					
 	    			TSubtotal::addSubTotalLine($object, $title, $qty);
-				}
-				else if($action==='ask_deleteallline') {
+				} else if($action==='ask_deleteallline') {
 						$form=new Form($db);
 						
 						$lineid = GETPOST('lineid','integer');
@@ -144,8 +150,7 @@ 
 					$this->printNewFormat($object, $conf, $langs, $idvar);
 				}
 			}
-		}
-		elseif ((!empty($parameters['currentcontext']) && $parameters['currentcontext'] == 'orderstoinvoice') || in_array('orderstoinvoice',$contexts))
+		} elseif ((!empty($parameters['currentcontext']) && $parameters['currentcontext'] == 'orderstoinvoice') || in_array('orderstoinvoice',$contexts))
 		{
 			?>
 			<script type="text/javascript">
@@ -163,8 +168,13 @@ 
      
 	function printNewFormat(&$object, &$conf, &$langs, $idvar)
 	{
-		if (empty($conf->global->SUBTOTAL_ALLOW_ADD_BLOCK)) return false;
-		if (!empty($object->situation_cycle_ref) && $object->situation_counter > 1) return false; // Si facture de situation
+		if (empty($conf->global->SUBTOTAL_ALLOW_ADD_BLOCK)) {
+			return false;
+		}
+		if (!empty($object->situation_cycle_ref) && $object->situation_counter > 1) {
+			return false;
+		}
+		// Si facture de situation
 		?>
 		 	<script type="text/javascript">
 				$(document).ready(function() {
@@ -450,8 +460,7 @@ 
 				}
 				
 				
-			}	
-			else{
+			} else{
 				$substitutionarray['line_not_modsubtotal'] = true;
 				$substitutionarray['line_modsubtotal'] = 0;
 			}
@@ -509,8 +518,11 @@ 
 		
 		$showBlockExtrafields = GETPOST('showBlockExtrafields');
 		
-		if($object->element=='facture') $idvar = 'facid';
-		else $idvar = 'id';
+		if($object->element=='facture') {
+			$idvar = 'facid';
+		} else {
+			$idvar = 'id';
+		}
 			
 		if ($action == 'updateligne' || $action == 'updateline')
 		{
@@ -540,8 +552,7 @@ 
 				header('Location: '.$_SERVER['PHP_SELF'].'?'.$idvar.'='.$object->id);
 				exit; // Surtout ne pas laisser Dolibarr faire du traitement sur le updateligne sinon ça plante les données de la ligne
 			}
-		}
-		else if($action === 'builddoc') {
+		} else if($action === 'builddoc') {
 			
 			if (
 				in_array('invoicecard',explode(':',$parameters['context']))
@@ -556,33 +567,27 @@ 
 					$sessname = 'subtotal_hideInnerLines_facture';	
 					$sessname2 = 'subtotal_hidedetails_facture';
 					$sessname3 = 'subtotal_hideprices_facture';
-				}
-				elseif(in_array('invoicesuppliercard',explode(':',$parameters['context']))) {
+				} elseif(in_array('invoicesuppliercard',explode(':',$parameters['context']))) {
 				    $sessname = 'subtotal_hideInnerLines_facture_fournisseur';
 				    $sessname2 = 'subtotal_hidedetails_facture_fournisseur';
 				    $sessname3 = 'subtotal_hideprices_facture_fournisseur';
-				}
-				elseif(in_array('propalcard',explode(':',$parameters['context']))) {
+				} elseif(in_array('propalcard',explode(':',$parameters['context']))) {
 					$sessname = 'subtotal_hideInnerLines_propal';
 					$sessname2 = 'subtotal_hidedetails_propal';	
 					$sessname3 = 'subtotal_hideprices_propal';
-				}
-				elseif(in_array('supplier_proposalcard',explode(':',$parameters['context']))) {
+				} elseif(in_array('supplier_proposalcard',explode(':',$parameters['context']))) {
 				    $sessname = 'subtotal_hideInnerLines_supplier_proposal';
 				    $sessname2 = 'subtotal_hidedetails_supplier_proposal';
 				    $sessname3 = 'subtotal_hideprices_supplier_proposal';
-				}
-				elseif(in_array('ordercard',explode(':',$parameters['context']))) {
+				} elseif(in_array('ordercard',explode(':',$parameters['context']))) {
 					$sessname = 'subtotal_hideInnerLines_commande';
 					$sessname2 = 'subtotal_hidedetails_commande';	
 					$sessname3 = 'subtotal_hideprices_commande';
-				}
-				elseif(in_array('ordersuppliercard',explode(':',$parameters['context']))) {
+				} elseif(in_array('ordersuppliercard',explode(':',$parameters['context']))) {
 				    $sessname = 'subtotal_hideInnerLines_commande_fournisseur';
 				    $sessname2 = 'subtotal_hidedetails_commande_fournisseur';
 				    $sessname3 = 'subtotal_hideprices_commande_fournisseur';
-				}
-				else {
+				} else {
 					$sessname = 'subtotal_hideInnerLines_unknown';
 					$sessname2 = 'subtotal_hidedetails_unknown';
 					$sessname3 = 'subtotal_hideprices_unknown';
@@ -604,8 +609,7 @@ 
 					    
                         if($line->qty>=90) {
                             $line->modsubtotal_total = 1;
-                        }
-                        else{
+                        } else{
                             $line->modsubtotal_title = 1;
                         }
                         
@@ -614,8 +618,7 @@ 
 	        	}
 	        }
 			
-		}
-		else if($action === 'confirm_delete_all_lines' && GETPOST('confirm')=='yes') {
+		} else if($action === 'confirm_delete_all_lines' && GETPOST('confirm')=='yes') {
 			
 			$Tab = $this->getArrayOfLineForAGroup($object, GETPOST('lineid'));
 			
@@ -623,7 +626,9 @@ 
 				/**
 				 * @var $object Facture
 				 */
-				if($object->element=='facture') $object->deleteline($idLine);
+				if($object->element=='facture') {
+					$object->deleteline($idLine);
+				}
 				/**
 				 * @var $object Facture fournisseur
 				 */
@@ -634,18 +639,25 @@ 
 				/**
 				 * @var $object Propal
 				 */
-				else if($object->element=='propal') $object->deleteline($idLine);
+				else if($object->element=='propal') {
+					$object->deleteline($idLine);
+				}
 				/**
 				 * @var $object Propal Fournisseur
 				 */
-				else if($object->element=='supplier_proposal') $object->deleteline($idLine);
+				else if($object->element=='supplier_proposal') {
+					$object->deleteline($idLine);
+				}
 				/**
 				 * @var $object Commande
 				 */
 				else if($object->element=='commande') 
 				{
-					if ((float) DOL_VERSION >= 5.0) $object->deleteline($user, $idLine);
-					else $object->deleteline($idLine);
+					if ((float) DOL_VERSION >= 5.0) {
+						$object->deleteline($user, $idLine);
+					} else {
+						$object->deleteline($idLine);
+					}
 				}
 				/**
 				 * @var $object Commande fournisseur
@@ -657,21 +669,26 @@ 
 				/**
 				 * @var $object Facturerec
 				 */
-				else if($object->element=='facturerec') $object->deleteline($idLine);
+				else if($object->element=='facturerec') {
+					$object->deleteline($idLine);
+				}
 			}
 			
 			header('location:?id='.$object->id);
 			exit;
 			
-		}
-		else if ($action == 'duplicate')
+		} else if ($action == 'duplicate')
 		{
 			$lineid = GETPOST('lineid', 'int');
 			$nbDuplicate = TSubtotal::duplicateLines($object, $lineid, true);
 			
-			if ($nbDuplicate > 0) setEventMessage($langs->trans('subtotal_duplicate_success', $nbDuplicate));
-			elseif ($nbDuplicate == 0) setEventMessage($langs->trans('subtotal_duplicate_lineid_not_found'), 'warnings');
-			else setEventMessage($langs->trans('subtotal_duplicate_error'), 'errors');
+			if ($nbDuplicate > 0) {
+				setEventMessage($langs->trans('subtotal_duplicate_success', $nbDuplicate));
+			} elseif ($nbDuplicate == 0) {
+				setEventMessage($langs->trans('subtotal_duplicate_lineid_not_found'), 'warnings');
+			} else {
+				setEventMessage($langs->trans('subtotal_duplicate_error'), 'errors');
+			}
 			
 			header('Location: ?id='.$object->id);
 			exit;
@@ -751,17 +768,18 @@ 
 			//print $l->rang.'>='.$rang.' '.$total.'<br/>';
 			if($l->rang>=$rang) {
 				//echo 'return!<br>';
-				if (!$return_all) return $total;
-				else return array($total, $total_tva, $total_ttc, $TTotal_tva);
-			}
-			else if(TSubtotal::isTitle($l, 100 - $qty_line)) 
+				if (!$return_all) {
+					return $total;
+				} else {
+					return array($total, $total_tva, $total_ttc, $TTotal_tva);
+				}
+			} else if(TSubtotal::isTitle($l, 100 - $qty_line)) 
 		  	{
 				$total = 0;
 				$total_tva = 0;
 				$total_ttc = 0;
 				$TTotal_tva = array();
-			}
-			elseif(!TSubtotal::isTitle($l) && !TSubtotal::isSubtotal($l)) {
+			} elseif(!TSubtotal::isTitle($l) && !TSubtotal::isSubtotal($l)) {
 				$total += $l->total_ht;
 				$total_tva += $l->total_tva;
 				$TTotal_tva[$l->tva_tx] += $l->total_tva;
@@ -769,8 +787,11 @@ 
 			}
 			
 		}
-		if (!$return_all) return $total;
-		else return array($total, $total_tva, $total_ttc, $TTotal_tva);
+		if (!$return_all) {
+			return $total;
+		} else {
+			return array($total, $total_tva, $total_ttc, $TTotal_tva);
+		}
 	}
 
 	/*
@@ -838,15 +859,18 @@ 
 		}
 		
 			
-		if($line->qty==99)
-			$pdf->SetFillColor(220,220,220);
-		elseif ($line->qty==98)
-			$pdf->SetFillColor(230,230,230);
-		else
-			$pdf->SetFillColor(240,240,240);
+		if($line->qty==99) {
+					$pdf->SetFillColor(220,220,220);
+		} elseif ($line->qty==98) {
+					$pdf->SetFillColor(230,230,230);
+		} else {
+					$pdf->SetFillColor(240,240,240);
+		}
 		
 		$style = 'B';
-		if (!empty($conf->global->SUBTOTAL_SUBTOTAL_STYLE)) $style = $conf->global->SUBTOTAL_SUBTOTAL_STYLE;
+		if (!empty($conf->global->SUBTOTAL_SUBTOTAL_STYLE)) {
+			$style = $conf->global->SUBTOTAL_SUBTOTAL_STYLE;
+		}
 		
 		$pdf->SetFont('', $style, 9);
 		
@@ -885,8 +909,7 @@ 
 //					$line->total_tva
 //					$line->total
 //					$line->total_ttc
-				}
-				else
+				} else
 				{
 					list($total, $total_tva, $total_ttc, $TTotal_tva) = $this->getTotalLineFromObject($object, $line, '', 1);
                                         if(get_class($object) == 'Facture' && $object->type==Facture::TYPE_SITUATION){//Facture de situation
@@ -903,11 +926,14 @@ 
 			}
 
 			$pdf->SetXY($pdf->postotalht, $posy);
-			if($set_pagebreak_margin) $pdf->SetAutoPageBreak( $pageBreakOriginalValue , $bMargin);
+			if($set_pagebreak_margin) {
+				$pdf->SetAutoPageBreak( $pageBreakOriginalValue , $bMargin);
+			}
 			$pdf->MultiCell($pdf->page_largeur-$pdf->marge_droite-$pdf->postotalht, 3, $total_to_print, 0, 'R', 0);
-		}
-		else{
-			if($set_pagebreak_margin) $pdf->SetAutoPageBreak( $pageBreakOriginalValue , $bMargin);
+		} else{
+			if($set_pagebreak_margin) {
+				$pdf->SetAutoPageBreak( $pageBreakOriginalValue , $bMargin);
+			}
 		}
 		
 		$posy = $posy + $cell_height;
@@ -939,25 +965,40 @@ 
 		
  
 		$style = ($line->qty==1) ? 'BU' : 'BUI';
-		if (!empty($conf->global->SUBTOTAL_TITLE_STYLE)) $style = $conf->global->SUBTOTAL_TITLE_STYLE;
+		if (!empty($conf->global->SUBTOTAL_TITLE_STYLE)) {
+			$style = $conf->global->SUBTOTAL_TITLE_STYLE;
+		}
 		
 		if($hideInnerLines) {
-			if($line->qty==1)$pdf->SetFont('', $style, 9);
-			else 
+			if($line->qty==1) {
+				$pdf->SetFont('', $style, 9);
+			} else 
 			{
-				if (!empty($conf->global->SUBTOTAL_STYLE_TITRES_SI_LIGNES_CACHEES)) $style = $conf->global->SUBTOTAL_STYLE_TITRES_SI_LIGNES_CACHEES;
+				if (!empty($conf->global->SUBTOTAL_STYLE_TITRES_SI_LIGNES_CACHEES)) {
+					$style = $conf->global->SUBTOTAL_STYLE_TITRES_SI_LIGNES_CACHEES;
+				}
 				$pdf->SetFont('', $style, 9);
 			}
-		}
-		else {
+		} else {
 
-			if($line->qty==1)$pdf->SetFont('', $style, 9); //TODO if super utile
-			else $pdf->SetFont('', $style, 9);
+			if($line->qty==1) {
+				$pdf->SetFont('', $style, 9);
+			}
+			//TODO if super utile
+			else {
+				$pdf->SetFont('', $style, 9);
+			}
 			
 		}
 		
-		if ($label === strip_tags($label) && $label === dol_html_entity_decode($label, ENT_QUOTES)) $pdf->MultiCell($w, $h, $label, 0, 'L'); // Pas de HTML dans la chaine
-		else $pdf->writeHTMLCell($w, $h, $posx, $posy, $label, 0, 1, false, true, 'J',true); // et maintenant avec du HTML
+		if ($label === strip_tags($label) && $label === dol_html_entity_decode($label, ENT_QUOTES)) {
+			$pdf->MultiCell($w, $h, $label, 0, 'L');
+		}
+		// Pas de HTML dans la chaine
+		else {
+			$pdf->writeHTMLCell($w, $h, $posx, $posy, $label, 0, 1, false, true, 'J',true);
+		}
+		// et maintenant avec du HTML
 		
 		if($description && !$hidedesc) {
 			$posy = $pdf->GetY();
@@ -981,8 +1022,7 @@ 
 		
 		if(is_array($parameters)) {
 			$i = & $parameters['i'];	
-		}
-		else {
+		} else {
 			$i = (int)$parameters;
 		}
 		
@@ -1004,17 +1044,14 @@ 
 			
 			if((float)DOL_VERSION<=3.6) {
 				return '';
-			}
-			else if((float)DOL_VERSION>=3.8) {
+			} else if((float)DOL_VERSION>=3.8) {
 				return 1;
 			}
 			
-		}
-		elseif(!empty($hideprices)) {
+		} elseif(!empty($hideprices)) {
 			$this->resprints = $object->lines[$parameters['i']]->qty;
 			return 1;
-		}
-		elseif (!empty($conf->global->SUBTOTAL_IF_HIDE_PRICES_SHOW_QTY))
+		} elseif (!empty($conf->global->SUBTOTAL_IF_HIDE_PRICES_SHOW_QTY))
 		{
 			$hideInnerLines = (int)GETPOST('hideInnerLines');
 			$hidedetails = (int)GETPOST('hidedetails');
@@ -1024,12 +1061,20 @@ 
 			}
 		}
 		
-		if(is_array($parameters)) $i = & $parameters['i'];
-		else $i = (int)$parameters;
+		if(is_array($parameters)) {
+			$i = & $parameters['i'];
+		} else {
+			$i = (int)$parameters;
+		}
 
-		if (empty($object->lines[$i])) return 0; // hideInnerLines => override $object->lines et Dolibarr ne nous permet pas de mettre à jour la variable qui conditionne la boucle sur les lignes (PR faite pour 6.0)
+		if (empty($object->lines[$i])) {
+			return 0;
+		}
+		// hideInnerLines => override $object->lines et Dolibarr ne nous permet pas de mettre à jour la variable qui conditionne la boucle sur les lignes (PR faite pour 6.0)
 		
-		if(empty($object->lines[$i]->array_options)) $object->lines[$i]->fetch_optionals();
+		if(empty($object->lines[$i]->array_options)) {
+			$object->lines[$i]->fetch_optionals();
+		}
 
 		if (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
 		{
@@ -1052,16 +1097,17 @@ 
 			
 			if((float)DOL_VERSION<=3.6) {
 				return '';
-			}
-			else if((float)DOL_VERSION>=3.8) {
+			} else if((float)DOL_VERSION>=3.8) {
 				return 1;
 			}
 			
-		}
-		elseif (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS))
+		} elseif (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS))
 		{
-			if(is_array($parameters)) $i = & $parameters['i'];
-			else $i = (int)$parameters;
+			if(is_array($parameters)) {
+				$i = & $parameters['i'];
+			} else {
+				$i = (int)$parameters;
+			}
 			
 			if (!in_array(__FUNCTION__, explode(',', $conf->global->SUBTOTAL_TFIELD_TO_KEEP_WITH_NC)))
 			{
@@ -1083,8 +1129,11 @@ 
 			}
 		}
 		if ((int)GETPOST('hideInnerLines') && !empty($conf->global->SUBTOTAL_REPLACE_WITH_VAT_IF_HIDE_INNERLINES)){
-		    if(is_array($parameters)) $i = & $parameters['i'];
-		    else $i = (int)$parameters;
+		    if(is_array($parameters)) {
+		    	$i = & $parameters['i'];
+		    } else {
+		    	$i = (int)$parameters;
+		    }
 		    $this->resprints = price($object->lines[$i]->total_ht);
 		}
 		if (!empty($hideprices)
@@ -1094,8 +1143,11 @@ 
 		    if (!empty($hideprices))
 		    {
 		        
-		        if(is_array($parameters)) $i = & $parameters['i'];
-		        else $i = (int)$parameters;
+		        if(is_array($parameters)) {
+		        	$i = & $parameters['i'];
+		        } else {
+		        	$i = (int)$parameters;
+		        }
 		        
 		        // Check if a title exist for this line && if the title have subtotal
 		        $lineTitle = TSubtotal::getParentTitleOfLine($object, $i);
@@ -1104,8 +1156,7 @@ 
 		            $this->resprints = ' ';
 		            return 1;
 		        }
-		    }
-		    elseif (!in_array(__FUNCTION__, explode(',', $conf->global->SUBTOTAL_TFIELD_TO_KEEP_WITH_NC)))
+		    } elseif (!in_array(__FUNCTION__, explode(',', $conf->global->SUBTOTAL_TFIELD_TO_KEEP_WITH_NC)))
 		    {
 		        $this->resprints = ' ';
 		        return 1;
@@ -1124,14 +1175,16 @@ 
 		
 			if((float)DOL_VERSION<=3.6) {
 				return '';
-			}
-			else if((float)DOL_VERSION>=3.8) {
+			} else if((float)DOL_VERSION>=3.8) {
 				return 1;
 			}
 		}
 		
-		if(is_array($parameters)) $i = & $parameters['i'];
-		else $i = (int)$parameters;
+		if(is_array($parameters)) {
+			$i = & $parameters['i'];
+		} else {
+			$i = (int)$parameters;
+		}
 		
 		if (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) ) 
 		{
@@ -1153,14 +1206,16 @@ 
 		
 			if((float)DOL_VERSION<=3.6) {
 				return '';
-			}
-			else if((float)DOL_VERSION>=3.8) {
+			} else if((float)DOL_VERSION>=3.8) {
 				return 1;
 			}
 		}
 		
-		if(is_array($parameters)) $i = & $parameters['i'];
-		else $i = (int)$parameters;
+		if(is_array($parameters)) {
+			$i = & $parameters['i'];
+		} else {
+			$i = (int)$parameters;
+		}
 			
 		if (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
 		{
@@ -1182,13 +1237,15 @@ 
 		
 			if((float)DOL_VERSION<=3.6) {
 				return '';
-			}
-			else if((float)DOL_VERSION>=3.8) {
+			} else if((float)DOL_VERSION>=3.8) {
 				return 1;
 			}
 		}
-		if(is_array($parameters)) $i = & $parameters['i'];
-		else $i = (int)$parameters;
+		if(is_array($parameters)) {
+			$i = & $parameters['i'];
+		} else {
+			$i = (int)$parameters;
+		}
 		
 		if (!empty($hideprices) 
 				|| (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
@@ -1211,14 +1268,16 @@ 
 			$this->resprints = ' ';
 			if((float)DOL_VERSION<=3.6) {
 				return '';
-			}
-			else if((float)DOL_VERSION>=3.8) {
+			} else if((float)DOL_VERSION>=3.8) {
 				return 1;
 			}
 		}
 		
-		if(is_array($parameters)) $i = & $parameters['i'];
-		else $i = (int)$parameters;
+		if(is_array($parameters)) {
+			$i = & $parameters['i'];
+		} else {
+			$i = (int)$parameters;
+		}
 			
 		if (!empty($hideprices)
 				|| (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
@@ -1242,16 +1301,21 @@ 
 			
 			if((float)DOL_VERSION<=3.6) {
 				return '';
-			}
-			else if((float)DOL_VERSION>=3.8) {
+			} else if((float)DOL_VERSION>=3.8) {
 				return 1;
 			}
 		}
 		
-		if(is_array($parameters)) $i = & $parameters['i'];
-		else $i = (int)$parameters;
+		if(is_array($parameters)) {
+			$i = & $parameters['i'];
+		} else {
+			$i = (int)$parameters;
+		}
 		
-		if (empty($object->lines[$i])) return 0; // hideInnerLines => override $object->lines et Dolibarr ne nous permet pas de mettre à jour la variable qui conditionne la boucle sur les lignes (PR faite pour 6.0)
+		if (empty($object->lines[$i])) {
+			return 0;
+		}
+		// hideInnerLines => override $object->lines et Dolibarr ne nous permet pas de mettre à jour la variable qui conditionne la boucle sur les lignes (PR faite pour 6.0)
 
 		$object->lines[$i]->fetch_optionals();
 		if (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
@@ -1273,14 +1337,16 @@ 
 			$this->resprints = ' ';
 			if((float)DOL_VERSION<=3.6) {
 				return '';
-			}
-			else if((float)DOL_VERSION>=3.8) {
+			} else if((float)DOL_VERSION>=3.8) {
 				return 1;
 			}
 		}
 		
-		if(is_array($parameters)) $i = & $parameters['i'];
-		else $i = (int)$parameters;
+		if(is_array($parameters)) {
+			$i = & $parameters['i'];
+		} else {
+			$i = (int)$parameters;
+		}
 			
 		if (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
 		{
@@ -1310,7 +1376,9 @@ 
 				}
 			}
 			
-			if (!empty($TLineTitle)) $TTitleNumeroted = $this->formatNumerotation($TLineTitle);
+			if (!empty($TLineTitle)) {
+				$TTitleNumeroted = $this->formatNumerotation($TLineTitle);
+			}
 		}
 		
 	}
@@ -1324,8 +1392,12 @@ 
 		$j=0;
 		foreach ($TLineTitle as $k => &$line)
 		{
-			if (!empty($line_reference) && $line->rang <= $line_reference->rang) continue;
-			if (!empty($line_reference) && $line->qty <= $line_reference->qty) break;
+			if (!empty($line_reference) && $line->rang <= $line_reference->rang) {
+				continue;
+			}
+			if (!empty($line_reference) && $line->qty <= $line_reference->qty) {
+				break;
+			}
 			
 			if ($line->qty == $level)
 			{
@@ -1359,7 +1431,9 @@ 
 		
 		$hidedetails = (int)GETPOST('hidedetails');
 		
-		if(empty($hidedetails)) return false;
+		if(empty($hidedetails)) {
+			return false;
+		}
 		
 		// TODO can't add VAT to document without lines... :-/
 		
@@ -1412,7 +1486,9 @@ 
 						*/
 						list($total, $total_tva, $total_ttc, $TTotal_tva) = $this->getTotalLineFromObject($object, $line, '', 1);
 						
-						if (TSubtotal::getNiveau($line) == 1) $line->TTotal_tva = $TTotal_tva;
+						if (TSubtotal::getNiveau($line) == 1) {
+							$line->TTotal_tva = $TTotal_tva;
+						}
 						$line->total_ht = $total;
 						$line->total_tva = $total_tva;
 						$line->total = $line->total_ht;
@@ -1467,8 +1543,7 @@ 
 				    }
 				    
 					
-				}
-				elseif ($hidedetails)
+				} elseif ($hidedetails)
 				{
 					$TLines[] = $line; //Cas où je cache uniquement les prix des produits	
 				}
@@ -1539,7 +1614,9 @@ 
 				
 				if(!empty($hideprices)) {
 					foreach($object->lines as &$line) {
-						if($line->fk_product_type!=9) $line->fk_parent_line = -1;	
+						if($line->fk_product_type!=9) {
+							$line->fk_parent_line = -1;
+						}
 					}
 				}
 			
@@ -1560,7 +1637,9 @@ 
 				
 				if($line->qty>90) {
 					
-					if ($conf->global->SUBTOTAL_USE_NEW_FORMAT)	$label .= ' '.$this->getTitle($object, $line);
+					if ($conf->global->SUBTOTAL_USE_NEW_FORMAT) {
+						$label .= ' '.$this->getTitle($object, $line);
+					}
 					
 					$pageBefore = $pdf->getPage();
 					$this->pdf_add_total($pdf,$object, $line, $label, $description,$posx, $posy, $w, $h);
@@ -1578,8 +1657,7 @@ 
 				
 					$posy = $pdf->GetY();
 					return 1;
-				}	
-				else if ($line->qty < 10) {
+				} else if ($line->qty < 10) {
 					$pageBefore = $pdf->getPage();
 
 					$this->pdf_add_title($pdf,$object, $line, $label, $description,$posx, $posy, $w, $h); 
@@ -1603,8 +1681,7 @@ 
 //	if($line->rowid==47) exit;
 			
 			return 0;
-		}
-		elseif (empty($object->lines[$parameters['i']]))
+		} elseif (empty($object->lines[$parameters['i']]))
 		{
 			$this->resprints = -1;
 		}
@@ -1637,7 +1714,9 @@ 
 		
 		foreach ($object->lines as $line)
 		{
-			if ($line->id == $currentLine->id) break;
+			if ($line->id == $currentLine->id) {
+				break;
+			}
 			
 			$qty_search = 100 - $currentLine->qty;
 			
@@ -1674,23 +1753,23 @@ 
 		{
 			$object->statut = 0; // hack for facture rec
 			$createRight = $user->rights->facture->creer;
-		}
-		elseif($object->element == 'order_supplier' )
+		} elseif($object->element == 'order_supplier' )
 		{
 		    $createRight = $user->rights->fournisseur->commande->creer;
-		}
-		elseif($object->element == 'invoice_supplier' )
+		} elseif($object->element == 'invoice_supplier' )
 		{
 		    $createRight = $user->rights->fournisseur->facture->creer;
 		}
 		
 		if($line->special_code!=$this->module_number || $line->product_type!=9) {
 			null;
-		}	
-		else if (in_array('invoicecard',$contexts) || in_array('invoicesuppliercard',$contexts) || in_array('propalcard',$contexts) || in_array('supplier_proposalcard',$contexts) || in_array('ordercard',$contexts) || in_array('ordersuppliercard',$contexts) || in_array('invoicereccard',$contexts)) 
+		} else if (in_array('invoicecard',$contexts) || in_array('invoicesuppliercard',$contexts) || in_array('propalcard',$contexts) || in_array('supplier_proposalcard',$contexts) || in_array('ordercard',$contexts) || in_array('ordersuppliercard',$contexts) || in_array('invoicereccard',$contexts)) 
         {
-			if($object->element=='facture')$idvar = 'facid';
-			else $idvar='id';
+			if($object->element=='facture') {
+				$idvar = 'facid';
+			} else {
+				$idvar='id';
+			}
 			
 			if((float)DOL_VERSION <= 3.4)
 			{
@@ -1716,20 +1795,44 @@ 
 				<?php
 			}
 			
-			if(empty($line->description)) $line->description = $line->desc;
+			if(empty($line->description)) {
+				$line->description = $line->desc;
+			}
 			
 			$colspan = 5;
-			if($object->element == 'facturerec' ) $colspan = 3;
-			if($object->element == 'order_supplier') $colspan = 3;
-			if($object->element == 'invoice_supplier') $colspan = 4;
-			if($object->element == 'supplier_proposal') $colspan = 4;
-			if(!empty($conf->multicurrency->enabled)) $colspan+=2;
-			if($object->element == 'commande' && $object->statut < 3 && !empty($conf->shippableorder->enabled)) $colspan++;
-			if(!empty($conf->margin->enabled)) $colspan++;
-			if(!empty($conf->global->DISPLAY_MARGIN_RATES)) $colspan++;
-			if(!empty($conf->global->DISPLAY_MARK_RATES)) $colspan++;
-			if($object->element == 'facture' && !empty($conf->global->INVOICE_USE_SITUATION) && $object->type == Facture::TYPE_SITUATION) $colspan++;
-			if(!empty($conf->global->PRODUCT_USE_UNITS)) $colspan++;
+			if($object->element == 'facturerec' ) {
+				$colspan = 3;
+			}
+			if($object->element == 'order_supplier') {
+				$colspan = 3;
+			}
+			if($object->element == 'invoice_supplier') {
+				$colspan = 4;
+			}
+			if($object->element == 'supplier_proposal') {
+				$colspan = 4;
+			}
+			if(!empty($conf->multicurrency->enabled)) {
+				$colspan+=2;
+			}
+			if($object->element == 'commande' && $object->statut < 3 && !empty($conf->shippableorder->enabled)) {
+				$colspan++;
+			}
+			if(!empty($conf->margin->enabled)) {
+				$colspan++;
+			}
+			if(!empty($conf->global->DISPLAY_MARGIN_RATES)) {
+				$colspan++;
+			}
+			if(!empty($conf->global->DISPLAY_MARK_RATES)) {
+				$colspan++;
+			}
+			if($object->element == 'facture' && !empty($conf->global->INVOICE_USE_SITUATION) && $object->type == Facture::TYPE_SITUATION) {
+				$colspan++;
+			}
+			if(!empty($conf->global->PRODUCT_USE_UNITS)) {
+				$colspan++;
+			}
 					
 			/* Titre */
 			//var_dump($line);
@@ -1742,23 +1845,36 @@ 
 			<tr <?php echo $bc[$var]; $var=!$var; echo $data; ?> rel="subtotal" id="row-<?php echo $line->id ?>" style="<?php
 					if (!empty($conf->global->SUBTOTAL_USE_NEW_FORMAT))
 					{
-						if($line->qty==99) print 'background:#adadcf';
-						else if($line->qty==98) print 'background:#ddddff;';
-						else if($line->qty<=97 && $line->qty>=91) print 'background:#eeeeff;';
-						else if($line->qty==1) print 'background:#adadcf;';
-						else if($line->qty==2) print 'background:#ddddff;';
-						else if($line->qty==50) print '';
-						else print 'background:#eeeeff;';
+						if($line->qty==99) {
+							print 'background:#adadcf';
+						} else if($line->qty==98) {
+							print 'background:#ddddff;';
+						} else if($line->qty<=97 && $line->qty>=91) {
+							print 'background:#eeeeff;';
+						} else if($line->qty==1) {
+							print 'background:#adadcf;';
+						} else if($line->qty==2) {
+							print 'background:#ddddff;';
+						} else if($line->qty==50) {
+							print '';
+						} else {
+							print 'background:#eeeeff;';
+						}
 
 						//A compléter si on veux plus de nuances de couleurs avec les niveau 4,5,6,7,8 et 9
-					}
-					else 
+					} else 
 					{
-						if($line->qty==99) print 'background:#ddffdd';
-						else if($line->qty==98) print 'background:#ddddff;';
-						else if($line->qty==2) print 'background:#eeeeff; ';
-						else if($line->qty==50) print '';
-						else print 'background:#eeffee;' ;
+						if($line->qty==99) {
+							print 'background:#ddffdd';
+						} else if($line->qty==98) {
+							print 'background:#ddddff;';
+						} else if($line->qty==2) {
+							print 'background:#eeeeff; ';
+						} else if($line->qty==50) {
+							print '';
+						} else {
+							print 'background:#eeffee;' ;
+						}
 					}
 
 			?>;">
@@ -1781,13 +1897,11 @@ 
 							$qty_displayed = $line->qty;
 							print img_picto('', 'subsubtotal@subtotal').'<span style="font-size:9px;margin-left:-3px;color:#0075DE;">'.$qty_displayed.'</span>&nbsp;&nbsp;';
 							
-						}
-						else if (TSubtotal::isSubtotal($line))
+						} else if (TSubtotal::isSubtotal($line))
 						{
 							$qty_displayed = 100 - $line->qty;
 							print img_picto('', 'subsubtotal2@subtotal').'<span style="font-size:9px;margin-left:-1px;color:#0075DE;">'.$qty_displayed.'</span>&nbsp;&nbsp;';
-						}
-						else
+						} else
 						{
 							$isFreeText = true;
 						}
@@ -1808,9 +1922,13 @@ 
 						}
 
 						$readonlyForSituation = '';
-						if (!empty($object->situation_cycle_ref) && $object->situation_counter > 1) $readonlyForSituation = 'readonly';
+						if (!empty($object->situation_cycle_ref) && $object->situation_counter > 1) {
+							$readonlyForSituation = 'readonly';
+						}
 						
-						if (!$isFreeText) echo '<input type="text" name="line-title" id-line="'.$line->id.'" value="'.$newlabel.'" size="80" '.$readonlyForSituation.'/>&nbsp;';
+						if (!$isFreeText) {
+							echo '<input type="text" name="line-title" id-line="'.$line->id.'" value="'.$newlabel.'" size="80" '.$readonlyForSituation.'/>&nbsp;';
+						}
 						
 						if (!empty($conf->global->SUBTOTAL_USE_NEW_FORMAT) && (TSubtotal::isTitle($line) || TSubtotal::isSubtotal($line)) )
 						{
@@ -1818,8 +1936,12 @@ 
 							for ($j=1; $j<10; $j++)
 							{
 								if (!empty($readonlyForSituation)) {
-									if ($qty_displayed == $j) $select .= '<option selected="selected" value="'.$j.'">'.$langs->trans('Level').' '.$j.'</option>';
-								} else $select .= '<option '.($qty_displayed == $j ? 'selected="selected"' : '').' value="'.$j.'">'.$langs->trans('Level').' '.$j.'</option>';
+									if ($qty_displayed == $j) {
+										$select .= '<option selected="selected" value="'.$j.'">'.$langs->trans('Level').' '.$j.'</option>';
+									}
+								} else {
+									$select .= '<option '.($qty_displayed == $j ? 'selected="selected"' : '').' value="'.$j.'">'.$langs->trans('Level').' '.$j.'</option>';
+								}
 							}
 							$select .= '</select>&nbsp;';
 
@@ -1835,15 +1957,18 @@ 
 								$form = new Form($db);
 								echo '<label for="subtotal_tva_tx">'.$form->textwithpicto($langs->trans('subtotal_apply_default_tva'), $langs->trans('subtotal_apply_default_tva_help')).'</label>';
 								echo '<select id="subtotal_tva_tx" name="subtotal_tva_tx" class="flat"><option selected="selected" value="">-</option>';
-								if (empty($readonlyForSituation)) echo str_replace('selected', '', $form->load_tva('subtotal_tva_tx', '', $parameters['seller'], $parameters['buyer'], 0, 0, '', true));
+								if (empty($readonlyForSituation)) {
+									echo str_replace('selected', '', $form->load_tva('subtotal_tva_tx', '', $parameters['seller'], $parameters['buyer'], 0, 0, '', true));
+								}
 								echo '</select>&nbsp;&nbsp;';
 								
 								if (!empty($conf->global->INVOICE_USE_SITUATION) && $object->element == 'facture' && $object->type == Facture::TYPE_SITUATION)
 								{
 									echo '<label for="subtotal_progress">'.$langs->trans('subtotal_apply_progress').'</label> <input id="subtotal_progress" name="subtotal_progress" value="" size="1" />%';
 								}
+							} else if ($isFreeText) {
+								echo TSubtotal::getFreeTextHtml($line, (bool) $readonlyForSituation);
 							}
-							else if ($isFreeText) echo TSubtotal::getFreeTextHtml($line, (bool) $readonlyForSituation);
 						echo '</div>';
 
 						if($line->qty<10) {
@@ -1863,8 +1988,7 @@ 
 							$doleditor->Create();
 						}
 						
-					}
-					else {
+					} else {
 
 						 if ($conf->global->SUBTOTAL_USE_NEW_FORMAT)
 						 {
@@ -1872,14 +1996,19 @@ 
 							{
 								echo str_repeat('&nbsp;&nbsp;&nbsp;', $line->qty-1);
 								
-								if (TSubtotal::isTitle($line)) print img_picto('', 'subtotal@subtotal').'<span style="font-size:9px;margin-left:-3px;">'.$line->qty.'</span>&nbsp;&nbsp;';
-								else print img_picto('', 'subtotal2@subtotal').'<span style="font-size:9px;margin-left:-1px;">'.(100-$line->qty).'</span>&nbsp;&nbsp;';
+								if (TSubtotal::isTitle($line)) {
+									print img_picto('', 'subtotal@subtotal').'<span style="font-size:9px;margin-left:-3px;">'.$line->qty.'</span>&nbsp;&nbsp;';
+								} else {
+									print img_picto('', 'subtotal2@subtotal').'<span style="font-size:9px;margin-left:-1px;">'.(100-$line->qty).'</span>&nbsp;&nbsp;';
+								}
 							}
-						 }
-						 else 
+						 } else 
 						 {
-							if($line->qty<=1) print img_picto('', 'subtotal@subtotal');
-							else if($line->qty==2) print img_picto('', 'subsubtotal@subtotal').'&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;'; 
+							if($line->qty<=1) {
+								print img_picto('', 'subtotal@subtotal');
+							} else if($line->qty==2) {
+								print img_picto('', 'subsubtotal@subtotal').'&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;';
+							}
 						 }
 						 
 						 
@@ -1889,21 +2018,26 @@ 
 						 $titleStyleUnderline =  strpos($conf->global->SUBTOTAL_TITLE_STYLE, 'U') === false ? '' : ' text-decoration: underline;';
 						 
 						 if (empty($line->label)) {
-							if ($line->qty >= 91 && $line->qty <= 99 && $conf->global->SUBTOTAL_USE_NEW_FORMAT) print  $line->description.' '.$this->getTitle($object, $line);
-							else print  $line->description;
-						 } 
-						 else {
+							if ($line->qty >= 91 && $line->qty <= 99 && $conf->global->SUBTOTAL_USE_NEW_FORMAT) {
+								print  $line->description.' '.$this->getTitle($object, $line);
+							} else {
+								print  $line->description;
+							}
+						 } else {
 
 							if (! empty($conf->global->PRODUIT_DESC_IN_FORM) && !empty($line->description)) {
 								print '<span class="subtotal_label" style="'.$titleStyleItalic.$titleStyleBold.$titleStyleUnderline.'" >'.$line->label.'</span><br><div class="subtotal_desc">'.dol_htmlentitiesbr($line->description).'</div>';
-							}
-							else{
+							} else{
 								print '<span class="subtotal_label classfortooltip '.$titleStyleItalic.$titleStyleBold.$titleStyleUnderline.'" title="'.$line->description.'">'.$line->label.'</span>';    
 							}
 
 						 } 
-						if($line->qty>90) print ' : ';
-						if($line->info_bits > 0) echo img_picto($langs->trans('Pagebreak'), 'pagebreak@subtotal');
+						if($line->qty>90) {
+							print ' : ';
+						}
+						if($line->info_bits > 0) {
+							echo img_picto($langs->trans('Pagebreak'), 'pagebreak@subtotal');
+						}
 
 						 
 
@@ -1940,11 +2074,12 @@ 
 						</script>
 						<?php
 						
-					}
-					else{
+					} else{
 						if ($object->statut == 0  && $createRight && !empty($conf->global->SUBTOTAL_ALLOW_DUPLICATE_BLOCK) && $object->element !== 'invoice_supplier')
 						{
-							if(TSubtotal::isTitle($line) && ($object->situation_counter == 1 || !$object->situation_cycle_ref) ) echo '<a href="'.$_SERVER['PHP_SELF'].'?'.$idvar.'='.$object->id.'&action=duplicate&lineid='.$line->id.'">'. img_picto($langs->trans('Duplicate'), 'duplicate@subtotal').'</a>';
+							if(TSubtotal::isTitle($line) && ($object->situation_counter == 1 || !$object->situation_cycle_ref) ) {
+								echo '<a href="'.$_SERVER['PHP_SELF'].'?'.$idvar.'='.$object->id.'&action=duplicate&lineid='.$line->id.'">'. img_picto($langs->trans('Duplicate'), 'duplicate@subtotal').'</a>';
+							}
 						}
 
 						if ($object->statut == 0  && $createRight && !empty($conf->global->SUBTOTAL_ALLOW_EDIT_BLOCK)) 
@@ -2013,7 +2148,9 @@ 
 				$extralabelsline = $extrafieldsline->fetch_name_optionals_label($object->table_element_line);
 				
 				$colspan+=3; $mode = 'view';
-				if($action === 'editline' && $line->rowid == GETPOST('lineid')) $mode = 'edit';
+				if($action === 'editline' && $line->rowid == GETPOST('lineid')) {
+					$mode = 'edit';
+				}
 				
 				$ex_element = $line->element;
 				$line->element = 'tr_extrafield_title '.$line->element; // Pour pouvoir manipuler ces tr
@@ -2195,10 +2332,9 @@ 
 	    
 	    if(TSubtotal::isTitle($line)){
 	        $ThtmlData['data-issubtotal'] = 'title';
-	    }elseif(TSubtotal::isSubtotal($line)){
+	    } elseif(TSubtotal::isSubtotal($line)){
 	        $ThtmlData['data-issubtotal'] = 'subtotal';
-	    }
-	    else{
+	    } else{
 	        $ThtmlData['data-issubtotal'] = 'freetext';
 	    }
 	    
@@ -2208,7 +2344,9 @@ 
 	    
 	    // hook 
 	    $reshook = $hookmanager->executeHooks('subtotalLineHtmlData',$parameters,$object,$action); // Note that $action and $object may have been modified by hook
-	    if ($reshook < 0) setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
+	    if ($reshook < 0) {
+	    	setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
+	    }
 	    if ($reshook>0)
 	    {
 	        $ThtmlData = $hookmanager->resArray;