Passed
Pull Request — master (#114)
by
unknown
02:00
created
class/actions_subtotal.class.php 1 patch
Braces   +357 added lines, -218 removed lines patch added patch discarded remove patch
@@ -25,7 +25,9 @@  discard block
 block discarded – undo
25 25
 				$value = '';
26 26
 				$sql = 'SELECT content FROM '.MAIN_DB_PREFIX.'c_subtotal_free_text WHERE rowid = '.GETPOST('rowid');
27 27
 				$resql = $this->db->query($sql);
28
-				if ($resql && ($obj = $this->db->fetch_object($resql))) $value = $obj->content;
28
+				if ($resql && ($obj = $this->db->fetch_object($resql))) {
29
+					$value = $obj->content;
30
+				}
29 31
 			}
30 32
 			
31 33
 			?>
@@ -109,8 +111,11 @@  discard block
 block discarded – undo
109 111
 			if ($object->statut == 0  && $createRight) {
110 112
 			
111 113
 
112
-				if($object->element=='facture')$idvar = 'facid';
113
-				else $idvar='id';
114
+				if($object->element=='facture') {
115
+					$idvar = 'facid';
116
+				} else {
117
+					$idvar='id';
118
+				}
114 119
 				
115 120
 				if(in_array($action, array('add_title_line', 'add_total_line', 'add_subtitle_line', 'add_subtotal_line', 'add_free_text')) )
116 121
 				{
@@ -118,10 +123,11 @@  discard block
 block discarded – undo
118 123
 					
119 124
 					if($action=='add_title_line') {
120 125
 						$title = GETPOST('title');
121
-						if(empty($title)) $title = $langs->trans('title');
126
+						if(empty($title)) {
127
+							$title = $langs->trans('title');
128
+						}
122 129
 						$qty = $level<1 ? 1 : $level ;
123
-					}
124
-					else if($action=='add_free_text') {
130
+					} else if($action=='add_free_text') {
125 131
 						$title = GETPOST('title');
126 132
 
127 133
 						if (empty($title)) {
@@ -133,29 +139,31 @@  discard block
 block discarded – undo
133 139
 								}
134 140
 							}
135 141
 						}
136
-						if(empty($title)) $title = $langs->trans('subtotalAddLineDescription');
142
+						if(empty($title)) {
143
+							$title = $langs->trans('subtotalAddLineDescription');
144
+						}
137 145
 						$qty = 50;
138
-					}
139
-					else if($action=='add_subtitle_line') {
146
+					} else if($action=='add_subtitle_line') {
140 147
 						$title = GETPOST('title');
141
-						if(empty($title)) $title = $langs->trans('subtitle');
148
+						if(empty($title)) {
149
+							$title = $langs->trans('subtitle');
150
+						}
142 151
 						$qty = 2;
143
-					}
144
-					else if($action=='add_subtotal_line') {
152
+					} else if($action=='add_subtotal_line') {
145 153
 						$title = $langs->trans('SubSubTotal');
146 154
 						$qty = 98;
147
-					}
148
-					else {
155
+					} else {
149 156
 						$title = GETPOST('title') ? GETPOST('title') : $langs->trans('SubTotal');
150 157
 						$qty = $level ? 100-$level : 99;
151 158
 					}
152 159
 					dol_include_once('/subtotal/class/subtotal.class.php');
153 160
 					
154
-					if (!empty($conf->global->SUBTOTAL_AUTO_ADD_SUBTOTAL_ON_ADDING_NEW_TITLE) && $qty < 10) TSubtotal::addSubtotalMissing($object, $qty);
161
+					if (!empty($conf->global->SUBTOTAL_AUTO_ADD_SUBTOTAL_ON_ADDING_NEW_TITLE) && $qty < 10) {
162
+						TSubtotal::addSubtotalMissing($object, $qty);
163
+					}
155 164
 					
156 165
 	    			TSubtotal::addSubTotalLine($object, $title, $qty);
157
-				}
158
-				else if($action==='ask_deleteallline') {
166
+				} else if($action==='ask_deleteallline') {
159 167
 						$form=new Form($db);
160 168
 						
161 169
 						$lineid = GETPOST('lineid','integer');
@@ -178,8 +186,7 @@  discard block
 block discarded – undo
178 186
 					$this->printNewFormat($object, $conf, $langs, $idvar);
179 187
 				}
180 188
 			}
181
-		}
182
-		elseif ((!empty($parameters['currentcontext']) && $parameters['currentcontext'] == 'orderstoinvoice') || in_array('orderstoinvoice',$contexts))
189
+		} elseif ((!empty($parameters['currentcontext']) && $parameters['currentcontext'] == 'orderstoinvoice') || in_array('orderstoinvoice',$contexts))
183 190
 		{
184 191
 			?>
185 192
 			<script type="text/javascript">
@@ -197,8 +204,13 @@  discard block
 block discarded – undo
197 204
      
198 205
 	function printNewFormat(&$object, &$conf, &$langs, $idvar)
199 206
 	{
200
-		if (empty($conf->global->SUBTOTAL_ALLOW_ADD_BLOCK)) return false;
201
-		if (!empty($object->situation_cycle_ref) && $object->situation_counter > 1) return false; // Si facture de situation
207
+		if (empty($conf->global->SUBTOTAL_ALLOW_ADD_BLOCK)) {
208
+			return false;
209
+		}
210
+		if (!empty($object->situation_cycle_ref) && $object->situation_counter > 1) {
211
+			return false;
212
+		}
213
+		// Si facture de situation
202 214
 		?>
203 215
 		 	<script type="text/javascript">
204 216
 				$(document).ready(function() {
@@ -484,8 +496,7 @@  discard block
 block discarded – undo
484 496
 				}
485 497
 				
486 498
 				
487
-			}	
488
-			else{
499
+			} else{
489 500
 				$substitutionarray['line_not_modsubtotal'] = true;
490 501
 				$substitutionarray['line_modsubtotal'] = 0;
491 502
 			}
@@ -543,8 +554,11 @@  discard block
 block discarded – undo
543 554
 		
544 555
 		$showBlockExtrafields = GETPOST('showBlockExtrafields');
545 556
 		
546
-		if($object->element=='facture') $idvar = 'facid';
547
-		else $idvar = 'id';
557
+		if($object->element=='facture') {
558
+			$idvar = 'facid';
559
+		} else {
560
+			$idvar = 'id';
561
+		}
548 562
 			
549 563
 		if ($action == 'updateligne' || $action == 'updateline')
550 564
 		{
@@ -574,8 +588,7 @@  discard block
 block discarded – undo
574 588
 				header('Location: '.$_SERVER['PHP_SELF'].'?'.$idvar.'='.$object->id);
575 589
 				exit; // Surtout ne pas laisser Dolibarr faire du traitement sur le updateligne sinon ça plante les données de la ligne
576 590
 			}
577
-		}
578
-		else if($action === 'builddoc') {
591
+		} else if($action === 'builddoc') {
579 592
 			
580 593
 			if (
581 594
 				in_array('invoicecard',explode(':',$parameters['context']))
@@ -590,33 +603,27 @@  discard block
 block discarded – undo
590 603
 					$sessname = 'subtotal_hideInnerLines_facture';	
591 604
 					$sessname2 = 'subtotal_hidedetails_facture';
592 605
 					$sessname3 = 'subtotal_hideprices_facture';
593
-				}
594
-				elseif(in_array('invoicesuppliercard',explode(':',$parameters['context']))) {
606
+				} elseif(in_array('invoicesuppliercard',explode(':',$parameters['context']))) {
595 607
 				    $sessname = 'subtotal_hideInnerLines_facture_fournisseur';
596 608
 				    $sessname2 = 'subtotal_hidedetails_facture_fournisseur';
597 609
 				    $sessname3 = 'subtotal_hideprices_facture_fournisseur';
598
-				}
599
-				elseif(in_array('propalcard',explode(':',$parameters['context']))) {
610
+				} elseif(in_array('propalcard',explode(':',$parameters['context']))) {
600 611
 					$sessname = 'subtotal_hideInnerLines_propal';
601 612
 					$sessname2 = 'subtotal_hidedetails_propal';	
602 613
 					$sessname3 = 'subtotal_hideprices_propal';
603
-				}
604
-				elseif(in_array('supplier_proposalcard',explode(':',$parameters['context']))) {
614
+				} elseif(in_array('supplier_proposalcard',explode(':',$parameters['context']))) {
605 615
 				    $sessname = 'subtotal_hideInnerLines_supplier_proposal';
606 616
 				    $sessname2 = 'subtotal_hidedetails_supplier_proposal';
607 617
 				    $sessname3 = 'subtotal_hideprices_supplier_proposal';
608
-				}
609
-				elseif(in_array('ordercard',explode(':',$parameters['context']))) {
618
+				} elseif(in_array('ordercard',explode(':',$parameters['context']))) {
610 619
 					$sessname = 'subtotal_hideInnerLines_commande';
611 620
 					$sessname2 = 'subtotal_hidedetails_commande';	
612 621
 					$sessname3 = 'subtotal_hideprices_commande';
613
-				}
614
-				elseif(in_array('ordersuppliercard',explode(':',$parameters['context']))) {
622
+				} elseif(in_array('ordersuppliercard',explode(':',$parameters['context']))) {
615 623
 				    $sessname = 'subtotal_hideInnerLines_commande_fournisseur';
616 624
 				    $sessname2 = 'subtotal_hidedetails_commande_fournisseur';
617 625
 				    $sessname3 = 'subtotal_hideprices_commande_fournisseur';
618
-				}
619
-				else {
626
+				} else {
620 627
 					$sessname = 'subtotal_hideInnerLines_unknown';
621 628
 					$sessname2 = 'subtotal_hidedetails_unknown';
622 629
 					$sessname3 = 'subtotal_hideprices_unknown';
@@ -638,8 +645,7 @@  discard block
 block discarded – undo
638 645
 					    
639 646
                         if($line->qty>=90) {
640 647
                             $line->modsubtotal_total = 1;
641
-                        }
642
-                        else{
648
+                        } else{
643 649
                             $line->modsubtotal_title = 1;
644 650
                         }
645 651
                         
@@ -648,8 +654,7 @@  discard block
 block discarded – undo
648 654
 	        	}
649 655
 	        }
650 656
 			
651
-		}
652
-		else if($action === 'confirm_delete_all_lines' && GETPOST('confirm')=='yes') {
657
+		} else if($action === 'confirm_delete_all_lines' && GETPOST('confirm')=='yes') {
653 658
 			
654 659
 			$Tab = $this->getArrayOfLineForAGroup($object, GETPOST('lineid'));
655 660
 			
@@ -657,7 +662,9 @@  discard block
 block discarded – undo
657 662
 				/**
658 663
 				 * @var $object Facture
659 664
 				 */
660
-				if($object->element=='facture') $object->deleteline($idLine);
665
+				if($object->element=='facture') {
666
+					$object->deleteline($idLine);
667
+				}
661 668
 				/**
662 669
 				 * @var $object Facture fournisseur
663 670
 				 */
@@ -668,18 +675,25 @@  discard block
 block discarded – undo
668 675
 				/**
669 676
 				 * @var $object Propal
670 677
 				 */
671
-				else if($object->element=='propal') $object->deleteline($idLine);
678
+				else if($object->element=='propal') {
679
+					$object->deleteline($idLine);
680
+				}
672 681
 				/**
673 682
 				 * @var $object Propal Fournisseur
674 683
 				 */
675
-				else if($object->element=='supplier_proposal') $object->deleteline($idLine);
684
+				else if($object->element=='supplier_proposal') {
685
+					$object->deleteline($idLine);
686
+				}
676 687
 				/**
677 688
 				 * @var $object Commande
678 689
 				 */
679 690
 				else if($object->element=='commande') 
680 691
 				{
681
-					if ((float) DOL_VERSION >= 5.0) $object->deleteline($user, $idLine);
682
-					else $object->deleteline($idLine);
692
+					if ((float) DOL_VERSION >= 5.0) {
693
+						$object->deleteline($user, $idLine);
694
+					} else {
695
+						$object->deleteline($idLine);
696
+					}
683 697
 				}
684 698
 				/**
685 699
 				 * @var $object Commande fournisseur
@@ -691,21 +705,26 @@  discard block
 block discarded – undo
691 705
 				/**
692 706
 				 * @var $object Facturerec
693 707
 				 */
694
-				else if($object->element=='facturerec') $object->deleteline($idLine);
708
+				else if($object->element=='facturerec') {
709
+					$object->deleteline($idLine);
710
+				}
695 711
 			}
696 712
 			
697 713
 			header('location:?id='.$object->id);
698 714
 			exit;
699 715
 			
700
-		}
701
-		else if ($action == 'duplicate')
716
+		} else if ($action == 'duplicate')
702 717
 		{
703 718
 			$lineid = GETPOST('lineid', 'int');
704 719
 			$nbDuplicate = TSubtotal::duplicateLines($object, $lineid, true);
705 720
 			
706
-			if ($nbDuplicate > 0) setEventMessage($langs->trans('subtotal_duplicate_success', $nbDuplicate));
707
-			elseif ($nbDuplicate == 0) setEventMessage($langs->trans('subtotal_duplicate_lineid_not_found'), 'warnings');
708
-			else setEventMessage($langs->trans('subtotal_duplicate_error'), 'errors');
721
+			if ($nbDuplicate > 0) {
722
+				setEventMessage($langs->trans('subtotal_duplicate_success', $nbDuplicate));
723
+			} elseif ($nbDuplicate == 0) {
724
+				setEventMessage($langs->trans('subtotal_duplicate_lineid_not_found'), 'warnings');
725
+			} else {
726
+				setEventMessage($langs->trans('subtotal_duplicate_error'), 'errors');
727
+			}
709 728
 			
710 729
 			header('Location: ?id='.$object->id);
711 730
 			exit;
@@ -785,17 +804,18 @@  discard block
 block discarded – undo
785 804
 			//print $l->rang.'>='.$rang.' '.$total.'<br/>';
786 805
 			if($l->rang>=$rang) {
787 806
 				//echo 'return!<br>';
788
-				if (!$return_all) return $total;
789
-				else return array($total, $total_tva, $total_ttc, $TTotal_tva);
790
-			}
791
-			else if(TSubtotal::isTitle($l, 100 - $qty_line)) 
807
+				if (!$return_all) {
808
+					return $total;
809
+				} else {
810
+					return array($total, $total_tva, $total_ttc, $TTotal_tva);
811
+				}
812
+			} else if(TSubtotal::isTitle($l, 100 - $qty_line)) 
792 813
 		  	{
793 814
 				$total = 0;
794 815
 				$total_tva = 0;
795 816
 				$total_ttc = 0;
796 817
 				$TTotal_tva = array();
797
-			}
798
-			elseif(!TSubtotal::isTitle($l) && !TSubtotal::isSubtotal($l)) {
818
+			} elseif(!TSubtotal::isTitle($l) && !TSubtotal::isSubtotal($l)) {
799 819
 				$total += $l->total_ht;
800 820
 				$total_tva += $l->total_tva;
801 821
 				$TTotal_tva[$l->tva_tx] += $l->total_tva;
@@ -803,8 +823,11 @@  discard block
 block discarded – undo
803 823
 			}
804 824
 			
805 825
 		}
806
-		if (!$return_all) return $total;
807
-		else return array($total, $total_tva, $total_ttc, $TTotal_tva);
826
+		if (!$return_all) {
827
+			return $total;
828
+		} else {
829
+			return array($total, $total_tva, $total_ttc, $TTotal_tva);
830
+		}
808 831
 	}
809 832
 
810 833
 	/*
@@ -872,15 +895,18 @@  discard block
 block discarded – undo
872 895
 		}
873 896
 		
874 897
 			
875
-		if($line->qty==99)
876
-			$pdf->SetFillColor(220,220,220);
877
-		elseif ($line->qty==98)
878
-			$pdf->SetFillColor(230,230,230);
879
-		else
880
-			$pdf->SetFillColor(240,240,240);
898
+		if($line->qty==99) {
899
+					$pdf->SetFillColor(220,220,220);
900
+		} elseif ($line->qty==98) {
901
+					$pdf->SetFillColor(230,230,230);
902
+		} else {
903
+					$pdf->SetFillColor(240,240,240);
904
+		}
881 905
 		
882 906
 		$style = 'B';
883
-		if (!empty($conf->global->SUBTOTAL_SUBTOTAL_STYLE)) $style = $conf->global->SUBTOTAL_SUBTOTAL_STYLE;
907
+		if (!empty($conf->global->SUBTOTAL_SUBTOTAL_STYLE)) {
908
+			$style = $conf->global->SUBTOTAL_SUBTOTAL_STYLE;
909
+		}
884 910
 		
885 911
 		$pdf->SetFont('', $style, 9);
886 912
 		
@@ -919,8 +945,7 @@  discard block
 block discarded – undo
919 945
 //					$line->total_tva
920 946
 //					$line->total
921 947
 //					$line->total_ttc
922
-				}
923
-				else
948
+				} else
924 949
 				{
925 950
 					list($total, $total_tva, $total_ttc, $TTotal_tva) = $this->getTotalLineFromObject($object, $line, '', 1);
926 951
                                         if(get_class($object) == 'Facture' && $object->type==Facture::TYPE_SITUATION){//Facture de situation
@@ -937,11 +962,14 @@  discard block
 block discarded – undo
937 962
 			}
938 963
 
939 964
 			$pdf->SetXY($pdf->postotalht, $posy);
940
-			if($set_pagebreak_margin) $pdf->SetAutoPageBreak( $pageBreakOriginalValue , $bMargin);
965
+			if($set_pagebreak_margin) {
966
+				$pdf->SetAutoPageBreak( $pageBreakOriginalValue , $bMargin);
967
+			}
941 968
 			$pdf->MultiCell($pdf->page_largeur-$pdf->marge_droite-$pdf->postotalht, 3, $total_to_print, 0, 'R', 0);
942
-		}
943
-		else{
944
-			if($set_pagebreak_margin) $pdf->SetAutoPageBreak( $pageBreakOriginalValue , $bMargin);
969
+		} else{
970
+			if($set_pagebreak_margin) {
971
+				$pdf->SetAutoPageBreak( $pageBreakOriginalValue , $bMargin);
972
+			}
945 973
 		}
946 974
 		
947 975
 		$posy = $posy + $cell_height;
@@ -973,25 +1001,40 @@  discard block
 block discarded – undo
973 1001
 		
974 1002
  
975 1003
 		$style = ($line->qty==1) ? 'BU' : 'BUI';
976
-		if (!empty($conf->global->SUBTOTAL_TITLE_STYLE)) $style = $conf->global->SUBTOTAL_TITLE_STYLE;
1004
+		if (!empty($conf->global->SUBTOTAL_TITLE_STYLE)) {
1005
+			$style = $conf->global->SUBTOTAL_TITLE_STYLE;
1006
+		}
977 1007
 		
978 1008
 		if($hideInnerLines) {
979
-			if($line->qty==1)$pdf->SetFont('', $style, 9);
980
-			else 
1009
+			if($line->qty==1) {
1010
+				$pdf->SetFont('', $style, 9);
1011
+			} else 
981 1012
 			{
982
-				if (!empty($conf->global->SUBTOTAL_STYLE_TITRES_SI_LIGNES_CACHEES)) $style = $conf->global->SUBTOTAL_STYLE_TITRES_SI_LIGNES_CACHEES;
1013
+				if (!empty($conf->global->SUBTOTAL_STYLE_TITRES_SI_LIGNES_CACHEES)) {
1014
+					$style = $conf->global->SUBTOTAL_STYLE_TITRES_SI_LIGNES_CACHEES;
1015
+				}
983 1016
 				$pdf->SetFont('', $style, 9);
984 1017
 			}
985
-		}
986
-		else {
1018
+		} else {
987 1019
 
988
-			if($line->qty==1)$pdf->SetFont('', $style, 9); //TODO if super utile
989
-			else $pdf->SetFont('', $style, 9);
1020
+			if($line->qty==1) {
1021
+				$pdf->SetFont('', $style, 9);
1022
+			}
1023
+			//TODO if super utile
1024
+			else {
1025
+				$pdf->SetFont('', $style, 9);
1026
+			}
990 1027
 			
991 1028
 		}
992 1029
 		
993
-		if ($label === strip_tags($label) && $label === dol_html_entity_decode($label, ENT_QUOTES)) $pdf->MultiCell($w, $h, $label, 0, 'L'); // Pas de HTML dans la chaine
994
-		else $pdf->writeHTMLCell($w, $h, $posx, $posy, $label, 0, 1, false, true, 'J',true); // et maintenant avec du HTML
1030
+		if ($label === strip_tags($label) && $label === dol_html_entity_decode($label, ENT_QUOTES)) {
1031
+			$pdf->MultiCell($w, $h, $label, 0, 'L');
1032
+		}
1033
+		// Pas de HTML dans la chaine
1034
+		else {
1035
+			$pdf->writeHTMLCell($w, $h, $posx, $posy, $label, 0, 1, false, true, 'J',true);
1036
+		}
1037
+		// et maintenant avec du HTML
995 1038
 		
996 1039
 		if($description && !$hidedesc) {
997 1040
 			$posy = $pdf->GetY();
@@ -1015,8 +1058,7 @@  discard block
 block discarded – undo
1015 1058
 		
1016 1059
 		if(is_array($parameters)) {
1017 1060
 			$i = & $parameters['i'];	
1018
-		}
1019
-		else {
1061
+		} else {
1020 1062
 			$i = (int)$parameters;
1021 1063
 		}
1022 1064
 		
@@ -1038,17 +1080,14 @@  discard block
 block discarded – undo
1038 1080
 			
1039 1081
 			if((float)DOL_VERSION<=3.6) {
1040 1082
 				return '';
1041
-			}
1042
-			else if((float)DOL_VERSION>=3.8) {
1083
+			} else if((float)DOL_VERSION>=3.8) {
1043 1084
 				return 1;
1044 1085
 			}
1045 1086
 			
1046
-		}
1047
-		elseif(!empty($hideprices)) {
1087
+		} elseif(!empty($hideprices)) {
1048 1088
 			$this->resprints = $object->lines[$parameters['i']]->qty;
1049 1089
 			return 1;
1050
-		}
1051
-		elseif (!empty($conf->global->SUBTOTAL_IF_HIDE_PRICES_SHOW_QTY))
1090
+		} elseif (!empty($conf->global->SUBTOTAL_IF_HIDE_PRICES_SHOW_QTY))
1052 1091
 		{
1053 1092
 			$hideInnerLines = (int)GETPOST('hideInnerLines');
1054 1093
 			$hidedetails = (int)GETPOST('hidedetails');
@@ -1058,12 +1097,20 @@  discard block
 block discarded – undo
1058 1097
 			}
1059 1098
 		}
1060 1099
 		
1061
-		if(is_array($parameters)) $i = & $parameters['i'];
1062
-		else $i = (int)$parameters;
1100
+		if(is_array($parameters)) {
1101
+			$i = & $parameters['i'];
1102
+		} else {
1103
+			$i = (int)$parameters;
1104
+		}
1063 1105
 
1064
-		if (empty($object->lines[$i])) return 0; // hideInnerLines => override $object->lines et Dolibarr ne nous permet pas de mettre à jour la variable qui conditionne la boucle sur les lignes (PR faite pour 6.0)
1106
+		if (empty($object->lines[$i])) {
1107
+			return 0;
1108
+		}
1109
+		// hideInnerLines => override $object->lines et Dolibarr ne nous permet pas de mettre à jour la variable qui conditionne la boucle sur les lignes (PR faite pour 6.0)
1065 1110
 		
1066
-		if(empty($object->lines[$i]->array_options)) $object->lines[$i]->fetch_optionals();
1111
+		if(empty($object->lines[$i]->array_options)) {
1112
+			$object->lines[$i]->fetch_optionals();
1113
+		}
1067 1114
 
1068 1115
 		if (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
1069 1116
 		{
@@ -1086,16 +1133,17 @@  discard block
 block discarded – undo
1086 1133
 			
1087 1134
 			if((float)DOL_VERSION<=3.6) {
1088 1135
 				return '';
1089
-			}
1090
-			else if((float)DOL_VERSION>=3.8) {
1136
+			} else if((float)DOL_VERSION>=3.8) {
1091 1137
 				return 1;
1092 1138
 			}
1093 1139
 			
1094
-		}
1095
-		elseif (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS))
1140
+		} elseif (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS))
1096 1141
 		{
1097
-			if(is_array($parameters)) $i = & $parameters['i'];
1098
-			else $i = (int)$parameters;
1142
+			if(is_array($parameters)) {
1143
+				$i = & $parameters['i'];
1144
+			} else {
1145
+				$i = (int)$parameters;
1146
+			}
1099 1147
 			
1100 1148
 			if (!in_array(__FUNCTION__, explode(',', $conf->global->SUBTOTAL_TFIELD_TO_KEEP_WITH_NC)))
1101 1149
 			{
@@ -1117,8 +1165,11 @@  discard block
 block discarded – undo
1117 1165
 			}
1118 1166
 		}
1119 1167
 		if ((int)GETPOST('hideInnerLines') && !empty($conf->global->SUBTOTAL_REPLACE_WITH_VAT_IF_HIDE_INNERLINES)){
1120
-		    if(is_array($parameters)) $i = & $parameters['i'];
1121
-		    else $i = (int)$parameters;
1168
+		    if(is_array($parameters)) {
1169
+		    	$i = & $parameters['i'];
1170
+		    } else {
1171
+		    	$i = (int)$parameters;
1172
+		    }
1122 1173
 		    $this->resprints = price($object->lines[$i]->total_ht);
1123 1174
 		}
1124 1175
 		
@@ -1141,8 +1192,11 @@  discard block
 block discarded – undo
1141 1192
 		// Cache le prix pour les lignes standards dolibarr qui sont dans un ensemble
1142 1193
 		else if (!empty($hideprices))
1143 1194
 		{
1144
-			if(is_array($parameters)) $i = & $parameters['i'];
1145
-			else $i = (int)$parameters;
1195
+			if(is_array($parameters)) {
1196
+				$i = & $parameters['i'];
1197
+			} else {
1198
+				$i = (int)$parameters;
1199
+			}
1146 1200
 
1147 1201
 			// Check if a title exist for this line && if the title have subtotal
1148 1202
 			$lineTitle = TSubtotal::getParentTitleOfLine($object, $i);
@@ -1172,12 +1226,10 @@  discard block
 block discarded – undo
1172 1226
 			$this->error = $hookmanager->error;
1173 1227
 			$this->errors = $hookmanager->errors;
1174 1228
 			return -1;
1175
-		}
1176
-		elseif (empty($reshook))
1229
+		} elseif (empty($reshook))
1177 1230
 		{
1178 1231
 			$this->resprints .= $hookmanager->resprints;
1179
-		}
1180
-		else
1232
+		} else
1181 1233
 		{
1182 1234
 			$this->resprints = $hookmanager->resprints;
1183 1235
 
@@ -1200,14 +1252,16 @@  discard block
 block discarded – undo
1200 1252
 		
1201 1253
 			if((float)DOL_VERSION<=3.6) {
1202 1254
 				return '';
1203
-			}
1204
-			else if((float)DOL_VERSION>=3.8) {
1255
+			} else if((float)DOL_VERSION>=3.8) {
1205 1256
 				return 1;
1206 1257
 			}
1207 1258
 		}
1208 1259
 		
1209
-		if(is_array($parameters)) $i = & $parameters['i'];
1210
-		else $i = (int)$parameters;
1260
+		if(is_array($parameters)) {
1261
+			$i = & $parameters['i'];
1262
+		} else {
1263
+			$i = (int)$parameters;
1264
+		}
1211 1265
 		
1212 1266
 		if (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) ) 
1213 1267
 		{
@@ -1229,14 +1283,16 @@  discard block
 block discarded – undo
1229 1283
 		
1230 1284
 			if((float)DOL_VERSION<=3.6) {
1231 1285
 				return '';
1232
-			}
1233
-			else if((float)DOL_VERSION>=3.8) {
1286
+			} else if((float)DOL_VERSION>=3.8) {
1234 1287
 				return 1;
1235 1288
 			}
1236 1289
 		}
1237 1290
 		
1238
-		if(is_array($parameters)) $i = & $parameters['i'];
1239
-		else $i = (int)$parameters;
1291
+		if(is_array($parameters)) {
1292
+			$i = & $parameters['i'];
1293
+		} else {
1294
+			$i = (int)$parameters;
1295
+		}
1240 1296
 			
1241 1297
 		if (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
1242 1298
 		{
@@ -1258,13 +1314,15 @@  discard block
 block discarded – undo
1258 1314
 		
1259 1315
 			if((float)DOL_VERSION<=3.6) {
1260 1316
 				return '';
1261
-			}
1262
-			else if((float)DOL_VERSION>=3.8) {
1317
+			} else if((float)DOL_VERSION>=3.8) {
1263 1318
 				return 1;
1264 1319
 			}
1265 1320
 		}
1266
-		if(is_array($parameters)) $i = & $parameters['i'];
1267
-		else $i = (int)$parameters;
1321
+		if(is_array($parameters)) {
1322
+			$i = & $parameters['i'];
1323
+		} else {
1324
+			$i = (int)$parameters;
1325
+		}
1268 1326
 		
1269 1327
 		if (!empty($hideprices) 
1270 1328
 				|| (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
@@ -1287,14 +1345,16 @@  discard block
 block discarded – undo
1287 1345
 			$this->resprints = ' ';
1288 1346
 			if((float)DOL_VERSION<=3.6) {
1289 1347
 				return '';
1290
-			}
1291
-			else if((float)DOL_VERSION>=3.8) {
1348
+			} else if((float)DOL_VERSION>=3.8) {
1292 1349
 				return 1;
1293 1350
 			}
1294 1351
 		}
1295 1352
 		
1296
-		if(is_array($parameters)) $i = & $parameters['i'];
1297
-		else $i = (int)$parameters;
1353
+		if(is_array($parameters)) {
1354
+			$i = & $parameters['i'];
1355
+		} else {
1356
+			$i = (int)$parameters;
1357
+		}
1298 1358
 			
1299 1359
 		if (!empty($hideprices)
1300 1360
 				|| (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
@@ -1318,16 +1378,21 @@  discard block
 block discarded – undo
1318 1378
 			
1319 1379
 			if((float)DOL_VERSION<=3.6) {
1320 1380
 				return '';
1321
-			}
1322
-			else if((float)DOL_VERSION>=3.8) {
1381
+			} else if((float)DOL_VERSION>=3.8) {
1323 1382
 				return 1;
1324 1383
 			}
1325 1384
 		}
1326 1385
 		
1327
-		if(is_array($parameters)) $i = & $parameters['i'];
1328
-		else $i = (int)$parameters;
1386
+		if(is_array($parameters)) {
1387
+			$i = & $parameters['i'];
1388
+		} else {
1389
+			$i = (int)$parameters;
1390
+		}
1329 1391
 		
1330
-		if (empty($object->lines[$i])) return 0; // hideInnerLines => override $object->lines et Dolibarr ne nous permet pas de mettre à jour la variable qui conditionne la boucle sur les lignes (PR faite pour 6.0)
1392
+		if (empty($object->lines[$i])) {
1393
+			return 0;
1394
+		}
1395
+		// hideInnerLines => override $object->lines et Dolibarr ne nous permet pas de mettre à jour la variable qui conditionne la boucle sur les lignes (PR faite pour 6.0)
1331 1396
 
1332 1397
 		$object->lines[$i]->fetch_optionals();
1333 1398
 		if (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
@@ -1349,14 +1414,16 @@  discard block
 block discarded – undo
1349 1414
 			$this->resprints = ' ';
1350 1415
 			if((float)DOL_VERSION<=3.6) {
1351 1416
 				return '';
1352
-			}
1353
-			else if((float)DOL_VERSION>=3.8) {
1417
+			} else if((float)DOL_VERSION>=3.8) {
1354 1418
 				return 1;
1355 1419
 			}
1356 1420
 		}
1357 1421
 		
1358
-		if(is_array($parameters)) $i = & $parameters['i'];
1359
-		else $i = (int)$parameters;
1422
+		if(is_array($parameters)) {
1423
+			$i = & $parameters['i'];
1424
+		} else {
1425
+			$i = (int)$parameters;
1426
+		}
1360 1427
 			
1361 1428
 		if (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && (!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) )
1362 1429
 		{
@@ -1386,7 +1453,9 @@  discard block
 block discarded – undo
1386 1453
 				}
1387 1454
 			}
1388 1455
 			
1389
-			if (!empty($TLineTitle)) $TTitleNumeroted = $this->formatNumerotation($TLineTitle);
1456
+			if (!empty($TLineTitle)) {
1457
+				$TTitleNumeroted = $this->formatNumerotation($TLineTitle);
1458
+			}
1390 1459
 		}
1391 1460
 		
1392 1461
 	}
@@ -1400,8 +1469,12 @@  discard block
 block discarded – undo
1400 1469
 		$j=0;
1401 1470
 		foreach ($TLineTitle as $k => &$line)
1402 1471
 		{
1403
-			if (!empty($line_reference) && $line->rang <= $line_reference->rang) continue;
1404
-			if (!empty($line_reference) && $line->qty <= $line_reference->qty) break;
1472
+			if (!empty($line_reference) && $line->rang <= $line_reference->rang) {
1473
+				continue;
1474
+			}
1475
+			if (!empty($line_reference) && $line->qty <= $line_reference->qty) {
1476
+				break;
1477
+			}
1405 1478
 			
1406 1479
 			if ($line->qty == $level)
1407 1480
 			{
@@ -1435,7 +1508,9 @@  discard block
 block discarded – undo
1435 1508
 		
1436 1509
 		$hidedetails = (int)GETPOST('hidedetails');
1437 1510
 		
1438
-		if(empty($hidedetails)) return false;
1511
+		if(empty($hidedetails)) {
1512
+			return false;
1513
+		}
1439 1514
 		
1440 1515
 		// TODO can't add VAT to document without lines... :-/
1441 1516
 		
@@ -1488,7 +1563,9 @@  discard block
 block discarded – undo
1488 1563
 						*/
1489 1564
 						list($total, $total_tva, $total_ttc, $TTotal_tva) = $this->getTotalLineFromObject($object, $line, '', 1);
1490 1565
 						
1491
-						if (TSubtotal::getNiveau($line) == 1) $line->TTotal_tva = $TTotal_tva;
1566
+						if (TSubtotal::getNiveau($line) == 1) {
1567
+							$line->TTotal_tva = $TTotal_tva;
1568
+						}
1492 1569
 						$line->total_ht = $total;
1493 1570
 						$line->total_tva = $total_tva;
1494 1571
 						$line->total = $line->total_ht;
@@ -1543,8 +1620,7 @@  discard block
 block discarded – undo
1543 1620
 				    }
1544 1621
 				    
1545 1622
 					
1546
-				}
1547
-				elseif ($hidedetails)
1623
+				} elseif ($hidedetails)
1548 1624
 				{
1549 1625
 					$TLines[] = $line; //Cas où je cache uniquement les prix des produits	
1550 1626
 				}
@@ -1615,7 +1691,9 @@  discard block
 block discarded – undo
1615 1691
 				
1616 1692
 				if(!empty($hideprices)) {
1617 1693
 					foreach($object->lines as &$line) {
1618
-						if($line->fk_product_type!=9) $line->fk_parent_line = -1;	
1694
+						if($line->fk_product_type!=9) {
1695
+							$line->fk_parent_line = -1;
1696
+						}
1619 1697
 					}
1620 1698
 				}
1621 1699
 			
@@ -1636,7 +1714,9 @@  discard block
 block discarded – undo
1636 1714
 				
1637 1715
 				if($line->qty>90) {
1638 1716
 					
1639
-					if ($conf->global->SUBTOTAL_USE_NEW_FORMAT)	$label .= ' '.$this->getTitle($object, $line);
1717
+					if ($conf->global->SUBTOTAL_USE_NEW_FORMAT) {
1718
+						$label .= ' '.$this->getTitle($object, $line);
1719
+					}
1640 1720
 					
1641 1721
 					$pageBefore = $pdf->getPage();
1642 1722
 					$this->pdf_add_total($pdf,$object, $line, $label, $description,$posx, $posy, $w, $h);
@@ -1654,8 +1734,7 @@  discard block
 block discarded – undo
1654 1734
 				
1655 1735
 					$posy = $pdf->GetY();
1656 1736
 					return 1;
1657
-				}	
1658
-				else if ($line->qty < 10) {
1737
+				} else if ($line->qty < 10) {
1659 1738
 					$pageBefore = $pdf->getPage();
1660 1739
 
1661 1740
 					$this->pdf_add_title($pdf,$object, $line, $label, $description,$posx, $posy, $w, $h); 
@@ -1679,8 +1758,7 @@  discard block
 block discarded – undo
1679 1758
 //	if($line->rowid==47) exit;
1680 1759
 			
1681 1760
 			return 0;
1682
-		}
1683
-		elseif (empty($object->lines[$parameters['i']]))
1761
+		} elseif (empty($object->lines[$parameters['i']]))
1684 1762
 		{
1685 1763
 			$this->resprints = -1;
1686 1764
 		}
@@ -1713,7 +1791,9 @@  discard block
 block discarded – undo
1713 1791
 		
1714 1792
 		foreach ($object->lines as $line)
1715 1793
 		{
1716
-			if ($line->id == $currentLine->id) break;
1794
+			if ($line->id == $currentLine->id) {
1795
+				break;
1796
+			}
1717 1797
 			
1718 1798
 			$qty_search = 100 - $currentLine->qty;
1719 1799
 			
@@ -1750,23 +1830,23 @@  discard block
 block discarded – undo
1750 1830
 		{
1751 1831
 			$object->statut = 0; // hack for facture rec
1752 1832
 			$createRight = $user->rights->facture->creer;
1753
-		}
1754
-		elseif($object->element == 'order_supplier' )
1833
+		} elseif($object->element == 'order_supplier' )
1755 1834
 		{
1756 1835
 		    $createRight = $user->rights->fournisseur->commande->creer;
1757
-		}
1758
-		elseif($object->element == 'invoice_supplier' )
1836
+		} elseif($object->element == 'invoice_supplier' )
1759 1837
 		{
1760 1838
 		    $createRight = $user->rights->fournisseur->facture->creer;
1761 1839
 		}
1762 1840
 		
1763 1841
 		if($line->special_code!=$this->module_number || $line->product_type!=9) {
1764 1842
 			null;
1765
-		}	
1766
-		else if (in_array('invoicecard',$contexts) || in_array('invoicesuppliercard',$contexts) || in_array('propalcard',$contexts) || in_array('supplier_proposalcard',$contexts) || in_array('ordercard',$contexts) || in_array('ordersuppliercard',$contexts) || in_array('invoicereccard',$contexts)) 
1843
+		} else if (in_array('invoicecard',$contexts) || in_array('invoicesuppliercard',$contexts) || in_array('propalcard',$contexts) || in_array('supplier_proposalcard',$contexts) || in_array('ordercard',$contexts) || in_array('ordersuppliercard',$contexts) || in_array('invoicereccard',$contexts)) 
1767 1844
         {
1768
-			if($object->element=='facture')$idvar = 'facid';
1769
-			else $idvar='id';
1845
+			if($object->element=='facture') {
1846
+				$idvar = 'facid';
1847
+			} else {
1848
+				$idvar='id';
1849
+			}
1770 1850
 			
1771 1851
 			if((float)DOL_VERSION <= 3.4)
1772 1852
 			{
@@ -1792,20 +1872,44 @@  discard block
 block discarded – undo
1792 1872
 				<?php
1793 1873
 			}
1794 1874
 			
1795
-			if(empty($line->description)) $line->description = $line->desc;
1875
+			if(empty($line->description)) {
1876
+				$line->description = $line->desc;
1877
+			}
1796 1878
 			
1797 1879
 			$colspan = 5;
1798
-			if($object->element == 'facturerec' ) $colspan = 3;
1799
-			if($object->element == 'order_supplier') $colspan = 3;
1800
-			if($object->element == 'invoice_supplier') $colspan = 4;
1801
-			if($object->element == 'supplier_proposal') $colspan = 4;
1802
-			if(!empty($conf->multicurrency->enabled)) $colspan+=2;
1803
-			if($object->element == 'commande' && $object->statut < 3 && !empty($conf->shippableorder->enabled)) $colspan++;
1804
-			if(!empty($conf->margin->enabled)) $colspan++;
1805
-			if(!empty($conf->global->DISPLAY_MARGIN_RATES)) $colspan++;
1806
-			if(!empty($conf->global->DISPLAY_MARK_RATES)) $colspan++;
1807
-			if($object->element == 'facture' && !empty($conf->global->INVOICE_USE_SITUATION) && $object->type == Facture::TYPE_SITUATION) $colspan++;
1808
-			if(!empty($conf->global->PRODUCT_USE_UNITS)) $colspan++;
1880
+			if($object->element == 'facturerec' ) {
1881
+				$colspan = 3;
1882
+			}
1883
+			if($object->element == 'order_supplier') {
1884
+				$colspan = 3;
1885
+			}
1886
+			if($object->element == 'invoice_supplier') {
1887
+				$colspan = 4;
1888
+			}
1889
+			if($object->element == 'supplier_proposal') {
1890
+				$colspan = 4;
1891
+			}
1892
+			if(!empty($conf->multicurrency->enabled)) {
1893
+				$colspan+=2;
1894
+			}
1895
+			if($object->element == 'commande' && $object->statut < 3 && !empty($conf->shippableorder->enabled)) {
1896
+				$colspan++;
1897
+			}
1898
+			if(!empty($conf->margin->enabled)) {
1899
+				$colspan++;
1900
+			}
1901
+			if(!empty($conf->global->DISPLAY_MARGIN_RATES)) {
1902
+				$colspan++;
1903
+			}
1904
+			if(!empty($conf->global->DISPLAY_MARK_RATES)) {
1905
+				$colspan++;
1906
+			}
1907
+			if($object->element == 'facture' && !empty($conf->global->INVOICE_USE_SITUATION) && $object->type == Facture::TYPE_SITUATION) {
1908
+				$colspan++;
1909
+			}
1910
+			if(!empty($conf->global->PRODUCT_USE_UNITS)) {
1911
+				$colspan++;
1912
+			}
1809 1913
 					
1810 1914
 			/* Titre */
1811 1915
 			//var_dump($line);
@@ -1818,23 +1922,36 @@  discard block
 block discarded – undo
1818 1922
 			<tr <?php echo $bc[$var]; $var=!$var; echo $data; ?> rel="subtotal" id="row-<?php echo $line->id ?>" style="<?php
1819 1923
 					if (!empty($conf->global->SUBTOTAL_USE_NEW_FORMAT))
1820 1924
 					{
1821
-						if($line->qty==99) print 'background:#adadcf';
1822
-						else if($line->qty==98) print 'background:#ddddff;';
1823
-						else if($line->qty<=97 && $line->qty>=91) print 'background:#eeeeff;';
1824
-						else if($line->qty==1) print 'background:#adadcf;';
1825
-						else if($line->qty==2) print 'background:#ddddff;';
1826
-						else if($line->qty==50) print '';
1827
-						else print 'background:#eeeeff;';
1925
+						if($line->qty==99) {
1926
+							print 'background:#adadcf';
1927
+						} else if($line->qty==98) {
1928
+							print 'background:#ddddff;';
1929
+						} else if($line->qty<=97 && $line->qty>=91) {
1930
+							print 'background:#eeeeff;';
1931
+						} else if($line->qty==1) {
1932
+							print 'background:#adadcf;';
1933
+						} else if($line->qty==2) {
1934
+							print 'background:#ddddff;';
1935
+						} else if($line->qty==50) {
1936
+							print '';
1937
+						} else {
1938
+							print 'background:#eeeeff;';
1939
+						}
1828 1940
 
1829 1941
 						//A compléter si on veux plus de nuances de couleurs avec les niveau 4,5,6,7,8 et 9
1830
-					}
1831
-					else 
1942
+					} else 
1832 1943
 					{
1833
-						if($line->qty==99) print 'background:#ddffdd';
1834
-						else if($line->qty==98) print 'background:#ddddff;';
1835
-						else if($line->qty==2) print 'background:#eeeeff; ';
1836
-						else if($line->qty==50) print '';
1837
-						else print 'background:#eeffee;' ;
1944
+						if($line->qty==99) {
1945
+							print 'background:#ddffdd';
1946
+						} else if($line->qty==98) {
1947
+							print 'background:#ddddff;';
1948
+						} else if($line->qty==2) {
1949
+							print 'background:#eeeeff; ';
1950
+						} else if($line->qty==50) {
1951
+							print '';
1952
+						} else {
1953
+							print 'background:#eeffee;' ;
1954
+						}
1838 1955
 					}
1839 1956
 
1840 1957
 			?>;">
@@ -1857,13 +1974,11 @@  discard block
 block discarded – undo
1857 1974
 							$qty_displayed = $line->qty;
1858 1975
 							print img_picto('', 'subsubtotal@subtotal').'<span style="font-size:9px;margin-left:-3px;color:#0075DE;">'.$qty_displayed.'</span>&nbsp;&nbsp;';
1859 1976
 							
1860
-						}
1861
-						else if (TSubtotal::isSubtotal($line))
1977
+						} else if (TSubtotal::isSubtotal($line))
1862 1978
 						{
1863 1979
 							$qty_displayed = 100 - $line->qty;
1864 1980
 							print img_picto('', 'subsubtotal2@subtotal').'<span style="font-size:9px;margin-left:-1px;color:#0075DE;">'.$qty_displayed.'</span>&nbsp;&nbsp;';
1865
-						}
1866
-						else
1981
+						} else
1867 1982
 						{
1868 1983
 							$isFreeText = true;
1869 1984
 						}
@@ -1884,9 +1999,13 @@  discard block
 block discarded – undo
1884 1999
 						}
1885 2000
 
1886 2001
 						$readonlyForSituation = '';
1887
-						if (!empty($object->situation_cycle_ref) && $object->situation_counter > 1) $readonlyForSituation = 'readonly';
2002
+						if (!empty($object->situation_cycle_ref) && $object->situation_counter > 1) {
2003
+							$readonlyForSituation = 'readonly';
2004
+						}
1888 2005
 						
1889
-						if (!$isFreeText) echo '<input type="text" name="line-title" id-line="'.$line->id.'" value="'.$newlabel.'" size="80" '.$readonlyForSituation.'/>&nbsp;';
2006
+						if (!$isFreeText) {
2007
+							echo '<input type="text" name="line-title" id-line="'.$line->id.'" value="'.$newlabel.'" size="80" '.$readonlyForSituation.'/>&nbsp;';
2008
+						}
1890 2009
 						
1891 2010
 						if (!empty($conf->global->SUBTOTAL_USE_NEW_FORMAT) && (TSubtotal::isTitle($line) || TSubtotal::isSubtotal($line)) )
1892 2011
 						{
@@ -1894,8 +2013,12 @@  discard block
 block discarded – undo
1894 2013
 							for ($j=1; $j<10; $j++)
1895 2014
 							{
1896 2015
 								if (!empty($readonlyForSituation)) {
1897
-									if ($qty_displayed == $j) $select .= '<option selected="selected" value="'.$j.'">'.$langs->trans('Level').' '.$j.'</option>';
1898
-								} else $select .= '<option '.($qty_displayed == $j ? 'selected="selected"' : '').' value="'.$j.'">'.$langs->trans('Level').' '.$j.'</option>';
2016
+									if ($qty_displayed == $j) {
2017
+										$select .= '<option selected="selected" value="'.$j.'">'.$langs->trans('Level').' '.$j.'</option>';
2018
+									}
2019
+								} else {
2020
+									$select .= '<option '.($qty_displayed == $j ? 'selected="selected"' : '').' value="'.$j.'">'.$langs->trans('Level').' '.$j.'</option>';
2021
+								}
1899 2022
 							}
1900 2023
 							$select .= '</select>&nbsp;';
1901 2024
 
@@ -1911,15 +2034,18 @@  discard block
 block discarded – undo
1911 2034
 								$form = new Form($db);
1912 2035
 								echo '<label for="subtotal_tva_tx">'.$form->textwithpicto($langs->trans('subtotal_apply_default_tva'), $langs->trans('subtotal_apply_default_tva_help')).'</label>';
1913 2036
 								echo '<select id="subtotal_tva_tx" name="subtotal_tva_tx" class="flat"><option selected="selected" value="">-</option>';
1914
-								if (empty($readonlyForSituation)) echo str_replace('selected', '', $form->load_tva('subtotal_tva_tx', '', $parameters['seller'], $parameters['buyer'], 0, 0, '', true));
2037
+								if (empty($readonlyForSituation)) {
2038
+									echo str_replace('selected', '', $form->load_tva('subtotal_tva_tx', '', $parameters['seller'], $parameters['buyer'], 0, 0, '', true));
2039
+								}
1915 2040
 								echo '</select>&nbsp;&nbsp;';
1916 2041
 								
1917 2042
 								if (!empty($conf->global->INVOICE_USE_SITUATION) && $object->element == 'facture' && $object->type == Facture::TYPE_SITUATION)
1918 2043
 								{
1919 2044
 									echo '<label for="subtotal_progress">'.$langs->trans('subtotal_apply_progress').'</label> <input id="subtotal_progress" name="subtotal_progress" value="" size="1" />%';
1920 2045
 								}
2046
+							} else if ($isFreeText) {
2047
+								echo TSubtotal::getFreeTextHtml($line, (bool) $readonlyForSituation);
1921 2048
 							}
1922
-							else if ($isFreeText) echo TSubtotal::getFreeTextHtml($line, (bool) $readonlyForSituation);
1923 2049
 						echo '</div>';
1924 2050
 
1925 2051
 						if($line->qty<10) {
@@ -1939,8 +2065,7 @@  discard block
 block discarded – undo
1939 2065
 							$doleditor->Create();
1940 2066
 						}
1941 2067
 						
1942
-					}
1943
-					else {
2068
+					} else {
1944 2069
 
1945 2070
 						 if ($conf->global->SUBTOTAL_USE_NEW_FORMAT)
1946 2071
 						 {
@@ -1948,14 +2073,19 @@  discard block
 block discarded – undo
1948 2073
 							{
1949 2074
 								echo str_repeat('&nbsp;&nbsp;&nbsp;', $line->qty-1);
1950 2075
 								
1951
-								if (TSubtotal::isTitle($line)) print img_picto('', 'subtotal@subtotal').'<span style="font-size:9px;margin-left:-3px;">'.$line->qty.'</span>&nbsp;&nbsp;';
1952
-								else print img_picto('', 'subtotal2@subtotal').'<span style="font-size:9px;margin-left:-1px;">'.(100-$line->qty).'</span>&nbsp;&nbsp;';
2076
+								if (TSubtotal::isTitle($line)) {
2077
+									print img_picto('', 'subtotal@subtotal').'<span style="font-size:9px;margin-left:-3px;">'.$line->qty.'</span>&nbsp;&nbsp;';
2078
+								} else {
2079
+									print img_picto('', 'subtotal2@subtotal').'<span style="font-size:9px;margin-left:-1px;">'.(100-$line->qty).'</span>&nbsp;&nbsp;';
2080
+								}
1953 2081
 							}
1954
-						 }
1955
-						 else 
2082
+						 } else 
1956 2083
 						 {
1957
-							if($line->qty<=1) print img_picto('', 'subtotal@subtotal');
1958
-							else if($line->qty==2) print img_picto('', 'subsubtotal@subtotal').'&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;'; 
2084
+							if($line->qty<=1) {
2085
+								print img_picto('', 'subtotal@subtotal');
2086
+							} else if($line->qty==2) {
2087
+								print img_picto('', 'subsubtotal@subtotal').'&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;';
2088
+							}
1959 2089
 						 }
1960 2090
 						 
1961 2091
 						 
@@ -1965,21 +2095,26 @@  discard block
 block discarded – undo
1965 2095
 						 $titleStyleUnderline =  strpos($conf->global->SUBTOTAL_TITLE_STYLE, 'U') === false ? '' : ' text-decoration: underline;';
1966 2096
 						 
1967 2097
 						 if (empty($line->label)) {
1968
-							if ($line->qty >= 91 && $line->qty <= 99 && $conf->global->SUBTOTAL_USE_NEW_FORMAT) print  $line->description.' '.$this->getTitle($object, $line);
1969
-							else print  $line->description;
1970
-						 } 
1971
-						 else {
2098
+							if ($line->qty >= 91 && $line->qty <= 99 && $conf->global->SUBTOTAL_USE_NEW_FORMAT) {
2099
+								print  $line->description.' '.$this->getTitle($object, $line);
2100
+							} else {
2101
+								print  $line->description;
2102
+							}
2103
+						 } else {
1972 2104
 
1973 2105
 							if (! empty($conf->global->PRODUIT_DESC_IN_FORM) && !empty($line->description)) {
1974 2106
 								print '<span class="subtotal_label" style="'.$titleStyleItalic.$titleStyleBold.$titleStyleUnderline.'" >'.$line->label.'</span><br><div class="subtotal_desc">'.dol_htmlentitiesbr($line->description).'</div>';
1975
-							}
1976
-							else{
2107
+							} else{
1977 2108
 								print '<span class="subtotal_label classfortooltip '.$titleStyleItalic.$titleStyleBold.$titleStyleUnderline.'" title="'.$line->description.'">'.$line->label.'</span>';    
1978 2109
 							}
1979 2110
 
1980 2111
 						 } 
1981
-						if($line->qty>90) print ' : ';
1982
-						if($line->info_bits > 0) echo img_picto($langs->trans('Pagebreak'), 'pagebreak@subtotal');
2112
+						if($line->qty>90) {
2113
+							print ' : ';
2114
+						}
2115
+						if($line->info_bits > 0) {
2116
+							echo img_picto($langs->trans('Pagebreak'), 'pagebreak@subtotal');
2117
+						}
1983 2118
 
1984 2119
 						 
1985 2120
 
@@ -2016,11 +2151,12 @@  discard block
 block discarded – undo
2016 2151
 						</script>
2017 2152
 						<?php
2018 2153
 						
2019
-					}
2020
-					else{
2154
+					} else{
2021 2155
 						if ($object->statut == 0  && $createRight && !empty($conf->global->SUBTOTAL_ALLOW_DUPLICATE_BLOCK) && $object->element !== 'invoice_supplier')
2022 2156
 						{
2023
-							if(TSubtotal::isTitle($line) && ($object->situation_counter == 1 || !$object->situation_cycle_ref) ) echo '<a href="'.$_SERVER['PHP_SELF'].'?'.$idvar.'='.$object->id.'&action=duplicate&lineid='.$line->id.'">'. img_picto($langs->trans('Duplicate'), 'duplicate@subtotal').'</a>';
2157
+							if(TSubtotal::isTitle($line) && ($object->situation_counter == 1 || !$object->situation_cycle_ref) ) {
2158
+								echo '<a href="'.$_SERVER['PHP_SELF'].'?'.$idvar.'='.$object->id.'&action=duplicate&lineid='.$line->id.'">'. img_picto($langs->trans('Duplicate'), 'duplicate@subtotal').'</a>';
2159
+							}
2024 2160
 						}
2025 2161
 
2026 2162
 						if ($object->statut == 0  && $createRight && !empty($conf->global->SUBTOTAL_ALLOW_EDIT_BLOCK)) 
@@ -2089,7 +2225,9 @@  discard block
 block discarded – undo
2089 2225
 				$extralabelsline = $extrafieldsline->fetch_name_optionals_label($object->table_element_line);
2090 2226
 				
2091 2227
 				$colspan+=3; $mode = 'view';
2092
-				if($action === 'editline' && $line->rowid == GETPOST('lineid')) $mode = 'edit';
2228
+				if($action === 'editline' && $line->rowid == GETPOST('lineid')) {
2229
+					$mode = 'edit';
2230
+				}
2093 2231
 				
2094 2232
 				$ex_element = $line->element;
2095 2233
 				$line->element = 'tr_extrafield_title '.$line->element; // Pour pouvoir manipuler ces tr
@@ -2271,10 +2409,9 @@  discard block
 block discarded – undo
2271 2409
 	    
2272 2410
 	    if(TSubtotal::isTitle($line)){
2273 2411
 	        $ThtmlData['data-issubtotal'] = 'title';
2274
-	    }elseif(TSubtotal::isSubtotal($line)){
2412
+	    } elseif(TSubtotal::isSubtotal($line)){
2275 2413
 	        $ThtmlData['data-issubtotal'] = 'subtotal';
2276
-	    }
2277
-	    else{
2414
+	    } else{
2278 2415
 	        $ThtmlData['data-issubtotal'] = 'freetext';
2279 2416
 	    }
2280 2417
 	    
@@ -2284,7 +2421,9 @@  discard block
 block discarded – undo
2284 2421
 	    
2285 2422
 	    // hook 
2286 2423
 	    $reshook = $hookmanager->executeHooks('subtotalLineHtmlData',$parameters,$object,$action); // Note that $action and $object may have been modified by hook
2287
-	    if ($reshook < 0) setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
2424
+	    if ($reshook < 0) {
2425
+	    	setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
2426
+	    }
2288 2427
 	    if ($reshook>0)
2289 2428
 	    {
2290 2429
 	        $ThtmlData = $hookmanager->resArray;
Please login to merge, or discard this patch.