ActionsSubtotal::pdf_writelinedesc()

Complexity

Conditions	14
Paths	196

Size

Total Lines	88
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	18
Bugs	1	Features	0

<?php
	function pdf_writelinedesc($parameters=array(), &$object, &$action)

It is generally recommended to explicitly declare the visibility for methods.

The parameter $action is not used and could be removed.

	{
		/**
		 * @var $pdf    TCPDF
		 */
		global $pdf,$conf;

		foreach($parameters as $key=>$value) {
			${$key} = $value;
		}
		
		$hideInnerLines = (int)GETPOST('hideInnerLines');

The assignment to $hideInnerLines is dead and can be removed.

The function GETPOST was not found. Maybe you did not declare it correctly or list all dependencies?

		$hidedetails = (int)GETPOST('hidedetails');

The assignment to $hidedetails is dead and can be removed.

		
		if($this->isModSubtotalLine($parameters,$object) ){			
		
				global $hideprices;
				
				if(!empty($hideprices)) {
					foreach($object->lines as &$line) {
						if($line->fk_product_type!=9) $line->fk_parent_line = -1;	
					}
				}
			
				$line = &$object->lines[$i];

The variable $i seems to be never defined.

				
				if($line->info_bits>0) { // PAGE BREAK
					$pdf->addPage();
					$posy = $pdf->GetY();
				}
				
				$label = $line->label;
				$description= !empty($line->desc) ? $outputlangs->convToOutputCharset($line->desc) : $outputlangs->convToOutputCharset($line->description);

The variable $outputlangs seems to be never defined.

				
				if(empty($label)) {
					$label = $description;
					$description='';
				}
				
				if($line->qty>90) {
					
					if ($conf->global->SUBTOTAL_USE_NEW_FORMAT)	$label .= ' '.$this->getTitle($object, $line);
					
					$pageBefore = $pdf->getPage();
					$this->pdf_add_total($pdf,$object, $line, $label, $description,$posx, $posy, $w, $h);

The variable $w seems to be never defined.

The variable $posy does not seem to be defined for all execution paths leading up to this point.

The variable $h seems to be never defined.

The variable $posx seems to be never defined.

					$pageAfter = $pdf->getPage();	

					if($pageAfter>$pageBefore) {
						//print "ST $pageAfter>$pageBefore<br>";
						$pdf->rollbackTransaction(true);	
						$pdf->addPage('','', true);
						$posy = $pdf->GetY();
						$this->pdf_add_total($pdf,$object, $line, $label, $description,$posx, $posy, $w, $h);
						$posy = $pdf->GetY();

The assignment to $posy is dead and can be removed.

						//print 'add ST'.$pdf->getPage().'<br />';
					}
				
					$posy = $pdf->GetY();
					return 1;
				}	
				else if ($line->qty < 10) {
					$pageBefore = $pdf->getPage();

The assignment to $pageBefore is dead and can be removed.

					$this->pdf_add_title($pdf,$object, $line, $label, $description,$posx, $posy, $w, $h); 
					$pageAfter = $pdf->getPage();	

The assignment to $pageAfter is dead and can be removed.

					
					/*if($pageAfter>$pageBefore) {
						print "T $pageAfter>$pageBefore<br>";
						$pdf->rollbackTransaction(true);
						$pdf->addPage('','', true);
						print 'add T'.$pdf->getPage().' '.$line->rowid.' '.$pdf->GetY().' '.$posy.'<br />';
						
						$posy = $pdf->GetY();
						$this->pdf_add_title($pdf,$object, $line, $label, $description,$posx, $posy, $w, $h);
						$posy = $pdf->GetY();
					}
				*/
					$posy = $pdf->GetY();
					return 1;
				}
//	if($line->rowid==47) exit;
			
			return 0;
		}
		elseif (empty($object->lines[$parameters['i']]))
		{
			$this->resprints = -1;

The property resprints does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		}