ActionsSubtotal::pdf_getlinetotalexcltax()

Complexity

Conditions	19
Paths	88

Size

Total Lines	76
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	16
Bugs	3	Features	0

<?php
	function pdf_getlinetotalexcltax($parameters=array(), &$object, &$action='') {

It is generally recommended to explicitly declare the visibility for methods.

	    global $conf, $hideprices, $hookmanager;
		
		if(is_array($parameters)) $i = & $parameters['i'];
		else $i = (int)$parameters;
			
		if($this->isModSubtotalLine($parameters,$object) ){
			
			$this->resprints = ' ';

The property resprints does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

			
			if((float)DOL_VERSION<=3.6) {

The constant DOL_VERSION was not found. Maybe you did not declare it correctly or list all dependencies?

				return '';
			}
			else if((float)DOL_VERSION>=3.8) {
				return 1;
			}
			
		}
		elseif (!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS))
		{
			if (!in_array(__FUNCTION__, explode(',', $conf->global->SUBTOTAL_TFIELD_TO_KEEP_WITH_NC)))
			{
				if (!empty($object->lines[$i]->array_options['options_subtotal_nc'])) 
				{
					$this->resprints = ' ';
					return 1;
				}

				$TTitle = TSubtotal::getAllTitleFromLine($object->lines[$i]);
				foreach ($TTitle as &$line_title)
				{
					if (!empty($line_title->array_options['options_subtotal_nc']))
					{
						$this->resprints = ' ';
						return 1;
					}
				}
			}
		}
		if ((int)GETPOST('hideInnerLines') && !empty($conf->global->SUBTOTAL_REPLACE_WITH_VAT_IF_HIDE_INNERLINES)){

The function GETPOST was not found. Maybe you did not declare it correctly or list all dependencies?

		    $this->resprints = price($object->lines[$i]->total_ht);

The function price was not found. Maybe you did not declare it correctly or list all dependencies?

		}
		
		// Si la gestion C/NC est active et que je suis sur un ligne dont l'extrafield est coché
		if ( 
			!empty($conf->global->SUBTOTAL_MANAGE_COMPRIS_NONCOMPRIS) && 
			(!empty($object->lines[$i]->array_options['options_subtotal_nc']) || TSubtotal::hasNcTitle($object->lines[$i])) 
		)
		{
			// alors je dois vérifier si la méthode fait partie de la conf qui l'exclue
			if (!in_array(__FUNCTION__, explode(',', $conf->global->SUBTOTAL_TFIELD_TO_KEEP_WITH_NC)))
			{
				$this->resprints = ' ';
				
				// currentcontext à modifier celon l'appel
				$params = array('parameters' => $parameters, 'currentmethod' => 'pdf_getlinetotalexcltax', 'currentcontext'=>'subtotal_hide_nc', 'i' => $i);
				return $this->callHook($object, $hookmanager, $action, $params); // return 1 (qui est la valeur par défaut) OU -1 si erreur OU overrideReturn (contient -1 ou 0 ou 1)
			}
		}
		// Cache le prix pour les lignes standards dolibarr qui sont dans un ensemble
		else if (!empty($hideprices))
		{
			// Check if a title exist for this line && if the title have subtotal
			$lineTitle = TSubtotal::getParentTitleOfLine($object, $i);
			if(TSubtotal::getParentTitleOfLine($object, $i) && TSubtotal::titleHasTotalLine($object, $lineTitle, true))

It seems like $lineTitle can also be of type false; however, parameter $title_line of TSubtotal::titleHasTotalLine() does only seem to accept OrderLine|PropaleLigne|FactureLigne, maybe add an additional type check?

			{

				$this->resprints = ' ';
				
				// currentcontext à modifier celon l'appel
				$params = array('parameters' => $parameters, 'currentmethod' => 'pdf_getlinetotalexcltax', 'currentcontext'=>'subtotal_hideprices', 'i' => $i);
				return $this->callHook($object, $hookmanager, $action, $params); // return 1 (qui est la valeur par défaut) OU -1 si erreur OU overrideReturn (contient -1 ou 0 ou 1)
			}
		}
        
		return 0;
	}