DateField::__construct() - Code Metrics - Inspection of "final" - ARTACK/delivery-status-notification - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6fa888...1dfddd )

by Patrick

created 2019-03-25 11:57 UTC

DateField::__construct() A

↳ Parent: DateField

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
eloc	2
dl	0
loc	5
rs	10
c	0
b	0
f	0
ccs	3
cts	3
cp	1
cc	1
nc	1
nop	2
crap	1

<?php

declare(strict_types=1);

namespace Artack\Dsn\Field;

class DateField extends AbstractField
{
    private $dateTime;

    public function __construct(string $name, \DateTimeInterface $date)
    {
        parent::__construct($name, null);

        $this->setDateTime($date);
    }

    public function getDateTime(): \DateTimeImmutable
    {
        return $this->dateTime;

    }

    /**
     * If a DateTime instance is provided, it is converted to DateTimeImmutable.
     */
    public function setDateTime(\DateTimeInterface $dateTime): void
    {
        if ($dateTime instanceof \DateTime) {
            $immutable = new \DateTimeImmutable('@'.$dateTime->getTimestamp());
            $dateTime = $immutable->setTimezone($dateTime->getTimezone());
        }
        $this->dateTime = $dateTime;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Artack\Dsn\Field;
6
7		class DateField extends AbstractField
8		{
9		private $dateTime;
10
11	8	public function __construct(string $name, \DateTimeInterface $date)
12		{
13	8	parent::__construct($name, null);
14
15	8	$this->setDateTime($date);
16	8	}
17
18	6	public function getDateTime(): \DateTimeImmutable
19		{
20	6	return $this->dateTime;
		1 ignored issue – show Bug Best Practice introduced 2019-03-25 12:00 UTC by Report Bug Copy Issue Report The expression `return $this->dateTime` could return the type `boolean` which is incompatible with the type-hinted return `DateTimeImmutable`. Consider adding an additional type-check to rule them out. Loading history...
21		}
22
23		/**
24		* If a DateTime instance is provided, it is converted to DateTimeImmutable.
25		*/
26	8	public function setDateTime(\DateTimeInterface $dateTime): void
27		{
28	8	if ($dateTime instanceof \DateTime) {
29	2	$immutable = new \DateTimeImmutable('@'.$dateTime->getTimestamp());
30	2	$dateTime = $immutable->setTimezone($dateTime->getTimezone());
31		}
32	8	$this->dateTime = $dateTime;
33	8	}
34		}
35

ARTACK / delivery-status-notification

Push — master ( 6fa888...1dfddd )

DateField::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like