Artack\Color\Converter\HEXToRGBConverter::convert()

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function convert(Color $color): Color
    {
        /* @var HEX $color */
        Assert::isInstanceOf($color, HEX::class, sprintf('color should be an instance of [%s]', HEX::class));

        $red = hexdec($color->getRed());
        $green = hexdec($color->getGreen());
        $blue = hexdec($color->getBlue());

        return new RGB($red, $green, $blue);

It seems like $red can also be of type double; however, parameter $red of Artack\Color\Color\RGB::__construct() does only seem to accept integer, maybe add an additional type check?

It seems like $green can also be of type double; however, parameter $green of Artack\Color\Color\RGB::__construct() does only seem to accept integer, maybe add an additional type check?

It seems like $blue can also be of type double; however, parameter $blue of Artack\Color\Color\RGB::__construct() does only seem to accept integer, maybe add an additional type check?

    }