VisitorPresenter::getUsernameAttribute() - Code Metrics - Inspection of "Updating the package" - ARCANESOFT/Tracker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c9c930...c56e16 )

by ARCANEDEV

created 2016-12-21 19:12 UTC

VisitorPresenter::getUsernameAttribute() A

↳ Parent: VisitorPresenter

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
cc	2
eloc	2
nc	2
nop	0
crap	6

<?php namespace Arcanesoft\Tracker\Models\Presenters;

/**
 * Trait     VisitorPresenter
 *
 * @package  Arcanesoft\Tracker\Models\Presenters
 * @author   ARCANEDEV <[email protected]>
 *
 * @property  \Arcanesoft\Auth\Models\User        user
 * @property  \Arcanesoft\Tracker\Models\Referer  referer
 */
trait VisitorPresenter
{
    /* ------------------------------------------------------------------------------------------------
     |  Getters & Setters
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Get the `username` attribute.
     *
     * @return string
     */
    public function getUsernameAttribute()
    {
        return $this->hasUser() ? $this->user->full_name : trans('tracker::users.guest');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get the `referer_host` attribute.
     *
     * @return string
     */
    public function getRefererHostAttribute()
    {
        return $this->hasReferer() ? $this->referer->host : trans('tracker::referers.undefined');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php namespace Arcanesoft\Tracker\Models\Presenters;
2
3			/**
4			* Trait VisitorPresenter
5			*
6			* @package Arcanesoft\Tracker\Models\Presenters
7			* @author ARCANEDEV <[email protected]>
8			*
9			* @property \Arcanesoft\Auth\Models\User user
10			* @property \Arcanesoft\Tracker\Models\Referer referer
11			*/
12			trait VisitorPresenter
13			{
14			/* ------------------------------------------------------------------------------------------------
15			\| Getters & Setters
16			\| ------------------------------------------------------------------------------------------------
17			*/
18			/**
19			* Get the `username` attribute.
20			*
21			* @return string
22			*/
23			public function getUsernameAttribute()
24			{
25			return $this->hasUser() ? $this->user->full_name : trans('tracker::users.guest');
			0 ignored issues – show Bug introduced 2016-12-13 15:06 UTC by Report Bug Copy Issue Report It seems like `hasUser()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26			}
27
28			/**
29			* Get the `referer_host` attribute.
30			*
31			* @return string
32			*/
33			public function getRefererHostAttribute()
34			{
35			return $this->hasReferer() ? $this->referer->host : trans('tracker::referers.undefined');
			0 ignored issues – show Bug introduced 2016-12-16 16:58 UTC by Report Bug Copy Issue Report It seems like `hasReferer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36			}
37			}
38

ARCANESOFT / Tracker

Push — master ( c9c930...c56e16 )

VisitorPresenter::getUsernameAttribute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like