FootersController::show() - Code Metrics - ARCANESOFT/SEO - Measure and Improve Code Quality continuously with Scrutinizer

FootersController::show() A
last analyzed 2017-09-08 15:51 UTC

↳ Parent: FootersController

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	0
cts	8
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	1
crap	2

<?php namespace Arcanesoft\Seo\Http\Controllers\Admin;

use Arcanesoft\Seo\Entities\Locales;
use Arcanesoft\Seo\Http\Requests\Admin\Footers\CreateFooterRequest;
use Arcanesoft\Seo\Http\Requests\Admin\Footers\UpdateFooterRequest;
use Arcanesoft\Seo\Models\Footer;
use Arcanesoft\Seo\Models\Page;
use Arcanesoft\Seo\Policies;
use Illuminate\Support\Facades\Log;

/**
 * Class     FootersController
 *
 * @package  Arcanesoft\Seo\Http\Controllers\Admin
 * @author   ARCANEDEV <[email protected]>
 */
class FootersController extends Controller
{
    /* -----------------------------------------------------------------
     |  Constructor
     | -----------------------------------------------------------------
     */

    /**
     * FootersController constructor.
     */
    public function __construct()
    {
        parent::__construct();

        $this->setCurrentPage('seo-footers');
        $this->addBreadcrumbRoute(trans('seo::footers.titles.footers'), 'admin::seo.footers.index');
    }

    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    public function index()
    {
        $this->authorize(Policies\FootersPolicy::PERMISSION_LIST);

        $footers = Footer::with(['page', 'seo'])->paginate(50);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->setTitle($title = trans('seo::footers.titles.footers-list'));
        $this->addBreadcrumb($title);

        return $this->view('admin.footers.index', compact('footers'));
    }

    public function create()
    {
        $this->authorize(Policies\FootersPolicy::PERMISSION_CREATE);

        $pages   = Page::getSelectData();
        $locales = Locales::all();

        $this->setTitle($title = trans('seo::footers.titles.new-footer'));
        $this->addBreadcrumb($title);

        return $this->view('admin.footers.create', compact('pages', 'locales'));
    }

    public function store(CreateFooterRequest $request)
    {
        $this->authorize(Policies\FootersPolicy::PERMISSION_CREATE);

        $footer = Footer::createOne(
            $request->getValidatedData()
        );

        $this->transNotification('created', ['name' => $footer->name], $footer->toArray());

        return redirect()->route('admin::seo.footers.show', [$footer]);
    }

    public function show(Footer $footer)
    {
        $this->authorize(Policies\FootersPolicy::PERMISSION_SHOW);

        $footer->load(['page', 'seo']);

        $this->setTitle($title = trans('seo::footers.titles.footer-details'));
        $this->addBreadcrumb($title);

        return $this->view('admin.footers.show', compact('footer'));
    }

    public function edit(Footer $footer)
    {
        $this->authorize(Policies\FootersPolicy::PERMISSION_UPDATE);

        $footer->load(['page', 'seo']);

        $pages   = Page::getSelectData();
        $locales = Locales::all();

        $this->setTitle($title = trans('seo::footers.titles.edit-footer'));
        $this->addBreadcrumb($title);

        return $this->view('admin.footers.edit', compact('footer', 'pages', 'locales'));
    }

    public function update(Footer $footer, UpdateFooterRequest $request)
    {
        $this->authorize(Policies\FootersPolicy::PERMISSION_UPDATE);

        $footer->updateOne(
            $request->getValidatedData()
        );

        $this->transNotification('updated', ['name' => $footer->name], $footer->toArray());

        return redirect()->route('admin::seo.footers.show', [$footer]);
    }

    public function delete(Footer $footer)
    {
        $this->authorize(Policies\FootersPolicy::PERMISSION_DELETE);

        $footer->delete();

        return $this->jsonResponseSuccess([
            'message' => $this->transNotification('deleted', ['name' => $footer->name], $footer->toArray())
        ]);
    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */

    /**
     * Notify with translation.
     *
     * @todo: Refactor this method to the core package ?
     *
     * @param  string  $action
     * @param  array   $replace
     * @param  array   $context
     *
     * @return string
     */
    protected function transNotification($action, array $replace = [], array $context = [])
    {
        $title   = trans("seo::footers.messages.{$action}.title");
        $message = trans("seo::footers.messages.{$action}.message", $replace);

        Log::info($message, $context);
        $this->notifySuccess($message, $title);

        return $message;
    }
}


1			<?php namespace Arcanesoft\Seo\Http\Controllers\Admin;
2
3			use Arcanesoft\Seo\Entities\Locales;
4			use Arcanesoft\Seo\Http\Requests\Admin\Footers\CreateFooterRequest;
5			use Arcanesoft\Seo\Http\Requests\Admin\Footers\UpdateFooterRequest;
6			use Arcanesoft\Seo\Models\Footer;
7			use Arcanesoft\Seo\Models\Page;
8			use Arcanesoft\Seo\Policies;
9			use Illuminate\Support\Facades\Log;
10
11			/**
12			* Class FootersController
13			*
14			* @package Arcanesoft\Seo\Http\Controllers\Admin
15			* @author ARCANEDEV <[email protected]>
16			*/
17			class FootersController extends Controller
18			{
19			/* -----------------------------------------------------------------
20			\| Constructor
21			\| -----------------------------------------------------------------
22			*/
23
24			/**
25			* FootersController constructor.
26			*/
27			public function __construct()
28			{
29			parent::__construct();
30
31			$this->setCurrentPage('seo-footers');
32			$this->addBreadcrumbRoute(trans('seo::footers.titles.footers'), 'admin::seo.footers.index');
33			}
34
35			/* -----------------------------------------------------------------
36			\| Main Methods
37			\| -----------------------------------------------------------------
38			*/
39
40			public function index()
41			{
42			$this->authorize(Policies\FootersPolicy::PERMISSION_LIST);
43
44			$footers = Footer::with(['page', 'seo'])->paginate(50);
			0 ignored issues – show Bug introduced 2017-09-08 15:25 UTC by Report Bug Copy Issue Report The method `paginate` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
45
46			$this->setTitle($title = trans('seo::footers.titles.footers-list'));
47			$this->addBreadcrumb($title);
48
49			return $this->view('admin.footers.index', compact('footers'));
50			}
51
52			public function create()
53			{
54			$this->authorize(Policies\FootersPolicy::PERMISSION_CREATE);
55
56			$pages = Page::getSelectData();
57			$locales = Locales::all();
58
59			$this->setTitle($title = trans('seo::footers.titles.new-footer'));
60			$this->addBreadcrumb($title);
61
62			return $this->view('admin.footers.create', compact('pages', 'locales'));
63			}
64
65			public function store(CreateFooterRequest $request)
66			{
67			$this->authorize(Policies\FootersPolicy::PERMISSION_CREATE);
68
69			$footer = Footer::createOne(
70			$request->getValidatedData()
71			);
72
73			$this->transNotification('created', ['name' => $footer->name], $footer->toArray());
74
75			return redirect()->route('admin::seo.footers.show', [$footer]);
76			}
77
78			public function show(Footer $footer)
79			{
80			$this->authorize(Policies\FootersPolicy::PERMISSION_SHOW);
81
82			$footer->load(['page', 'seo']);
83
84			$this->setTitle($title = trans('seo::footers.titles.footer-details'));
85			$this->addBreadcrumb($title);
86
87			return $this->view('admin.footers.show', compact('footer'));
88			}
89
90			public function edit(Footer $footer)
91			{
92			$this->authorize(Policies\FootersPolicy::PERMISSION_UPDATE);
93
94			$footer->load(['page', 'seo']);
95
96			$pages = Page::getSelectData();
97			$locales = Locales::all();
98
99			$this->setTitle($title = trans('seo::footers.titles.edit-footer'));
100			$this->addBreadcrumb($title);
101
102			return $this->view('admin.footers.edit', compact('footer', 'pages', 'locales'));
103			}
104
105			public function update(Footer $footer, UpdateFooterRequest $request)
106			{
107			$this->authorize(Policies\FootersPolicy::PERMISSION_UPDATE);
108
109			$footer->updateOne(
110			$request->getValidatedData()
111			);
112
113			$this->transNotification('updated', ['name' => $footer->name], $footer->toArray());
114
115			return redirect()->route('admin::seo.footers.show', [$footer]);
116			}
117
118			public function delete(Footer $footer)
119			{
120			$this->authorize(Policies\FootersPolicy::PERMISSION_DELETE);
121
122			$footer->delete();
123
124			return $this->jsonResponseSuccess([
125			'message' => $this->transNotification('deleted', ['name' => $footer->name], $footer->toArray())
126			]);
127			}
128
129			/* -----------------------------------------------------------------
130			\| Other Methods
131			\| -----------------------------------------------------------------
132			*/
133
134			/**
135			* Notify with translation.
136			*
137			* @todo: Refactor this method to the core package ?
138			*
139			* @param string $action
140			* @param array $replace
141			* @param array $context
142			*
143			* @return string
144			*/
145			protected function transNotification($action, array $replace = [], array $context = [])
146			{
147			$title = trans("seo::footers.messages.{$action}.title");
148			$message = trans("seo::footers.messages.{$action}.message", $replace);
149
150			Log::info($message, $context);
151			$this->notifySuccess($message, $title);
152
153			return $message;
154			}
155			}
156

ARCANESOFT / SEO

FootersController::show() A last analyzed 2017-09-08 15:51 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

FootersController::show() A
last analyzed 2017-09-08 15:51 UTC