ServerRequirementsComposer::checkPhpRequirements() - Code Metrics - Inspection of "Bump version" - ARCANESOFT/Foundation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 051e1f...fb5ddd )

by ARCANEDEV

created 2017-04-03 16:26 UTC

ServerRequirementsComposer::checkPhpRequirements() A

↳ Parent: ServerRequirementsComposer

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	4
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	8
ccs	0
cts	3
cp	0
crap	2
rs	9.4285

<?php namespace Arcanesoft\Foundation\ViewComposers\System;

use Illuminate\View\View;

/**
 * Class     ServerRequirementsComposer
 *
 * @package  Arcanesoft\Foundation\ViewComposers\System
 * @author   ARCANEDEV <[email protected]>
 */
class ServerRequirementsComposer
{
    /* -----------------------------------------------------------------
     |  Constants
     | -----------------------------------------------------------------
     */
    const VIEW = 'foundation::admin.system.information._includes.server-requirements';

    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */
    /**
     * Compose the view.
     *
     * @param  \Illuminate\View\View  $view
     */
    public function compose(View $view)
    {
        $requirements['server']['ssl']     = $this->checkSslInstalled();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $requirements['server']['modules'] = $this->getServerModules([
            'mod_rewrite',
        ]);

        $view->with('requirements', $requirements);
    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */
    /**
     * Check if SSL is installed.
     *
     * @return bool
     */
    private function checkSslInstalled()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return (!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off') ? true : false;
    }

    /**
     * Check the APACHE requirements.
     *
     * @param  array  $requirements
     *
     * @return \Illuminate\Support\Collection
     */
    private function getServerModules(array $requirements)
    {
        if ( ! function_exists('apache_get_modules')) {
            return collect([]);
        }

        $modules      = apache_get_modules();
        $requirements = array_combine($requirements, $requirements);

        return collect($requirements)->transform(function ($requirement) use ($modules) {
            return in_array($requirement, $modules);
        });
    }
}


1			<?php namespace Arcanesoft\Foundation\ViewComposers\System;
2
3			use Illuminate\View\View;
4
5			/**
6			* Class ServerRequirementsComposer
7			*
8			* @package Arcanesoft\Foundation\ViewComposers\System
9			* @author ARCANEDEV <[email protected]>
10			*/
11			class ServerRequirementsComposer
12			{
13			/* -----------------------------------------------------------------
14			\| Constants
15			\| -----------------------------------------------------------------
16			*/
17			const VIEW = 'foundation::admin.system.information._includes.server-requirements';
18
19			/* -----------------------------------------------------------------
20			\| Main Methods
21			\| -----------------------------------------------------------------
22			*/
23			/**
24			* Compose the view.
25			*
26			* @param \Illuminate\View\View $view
27			*/
28			public function compose(View $view)
29			{
30			$requirements['server']['ssl'] = $this->checkSslInstalled();
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-29 14:13 UTC by Report Bug Copy Issue Report `$requirements` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$requirements = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
31			$requirements['server']['modules'] = $this->getServerModules([
32			'mod_rewrite',
33			]);
34
35			$view->with('requirements', $requirements);
36			}
37
38			/* -----------------------------------------------------------------
39			\| Other Methods
40			\| -----------------------------------------------------------------
41			*/
42			/**
43			* Check if SSL is installed.
44			*
45			* @return bool
46			*/
47			private function checkSslInstalled()
			0 ignored issues – show Coding Style introduced 2017-03-31 19:26 UTC by Report Bug Copy Issue Report `checkSslInstalled` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
48			{
49			return (!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off') ? true : false;
50			}
51
52			/**
53			* Check the APACHE requirements.
54			*
55			* @param array $requirements
56			*
57			* @return \Illuminate\Support\Collection
58			*/
59			private function getServerModules(array $requirements)
60			{
61			if ( ! function_exists('apache_get_modules')) {
62			return collect([]);
63			}
64
65			$modules = apache_get_modules();
66			$requirements = array_combine($requirements, $requirements);
67
68			return collect($requirements)->transform(function ($requirement) use ($modules) {
69			return in_array($requirement, $modules);
70			});
71			}
72			}
73

ARCANESOFT / Foundation

Push — master ( 051e1f...fb5ddd )

ServerRequirementsComposer::checkPhpRequirements() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like