RouteServiceProvider::getFoundationRouteGroup() - Code Metrics - Inspection of "Updating RouteServiceProvider" - ARCANESOFT/Foundation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b52d53...c245d9 )

by ARCANEDEV

created 2015-12-01 16:42 UTC

RouteServiceProvider::getFoundationRouteGroup() A

↳ Parent: RouteServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php namespace Arcanesoft\Foundation\Providers;

use Arcanedev\Support\Providers\RouteServiceProvider as ServiceProvider;
use Arcanesoft\Foundation\Http\Middleware;
use Arcanesoft\Foundation\Http\Routes;
use Illuminate\Routing\Router;

/**
 * Class     RouteServiceProvider
 *
 * @package  Arcanesoft\Foundation\Providers
 * @author   ARCANEDEV <[email protected]>
 */
class RouteServiceProvider extends ServiceProvider
{
    /* ------------------------------------------------------------------------------------------------
     |  Getters & Setters
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Get the routes namespace
     *
     * @return string
     */
    protected function getRouteNamespace()
    {
        return 'Arcanesoft\\Foundation\\Http\\Routes';
    }

    /**
     * Get Foundation route group.
     *
     * @return array
     */
    protected function getFoundationRouteGroup()
    {
        return config('arcanesoft.foundation.route', []);
    }

    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Define the routes for the application.
     *
     * @param  Router $router
     */
    public function map(Router $router)
    {
        $this->middleware('admin', Middleware\AdminMiddleware::class);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $router->group($this->getFoundationRouteGroup(), function (Router $router) {
            (new Routes\DashboardRoute())->map($router);
        });
    }
}


1		<?php namespace Arcanesoft\Foundation\Providers;
2
3		use Arcanedev\Support\Providers\RouteServiceProvider as ServiceProvider;
4		use Arcanesoft\Foundation\Http\Middleware;
5		use Arcanesoft\Foundation\Http\Routes;
6		use Illuminate\Routing\Router;
7
8		/**
9		* Class RouteServiceProvider
10		*
11		* @package Arcanesoft\Foundation\Providers
12		* @author ARCANEDEV <[email protected]>
13		*/
14		class RouteServiceProvider extends ServiceProvider
15		{
16		/* ------------------------------------------------------------------------------------------------
17		\| Getters & Setters
18		\| ------------------------------------------------------------------------------------------------
19		*/
20		/**
21		* Get the routes namespace
22		*
23		* @return string
24		*/
25		protected function getRouteNamespace()
26		{
27		return 'Arcanesoft\\Foundation\\Http\\Routes';
28		}
29
30		/**
31		* Get Foundation route group.
32		*
33		* @return array
34		*/
35	18	protected function getFoundationRouteGroup()
36		{
37	18	return config('arcanesoft.foundation.route', []);
38		}
39
40		/* ------------------------------------------------------------------------------------------------
41		\| Main Functions
42		\| ------------------------------------------------------------------------------------------------
43		*/
44		/**
45		* Define the routes for the application.
46		*
47		* @param Router $router
48		*/
49	18	public function map(Router $router)
50		{
51	18	$this->middleware('admin', Middleware\AdminMiddleware::class);
		0 ignored issues – show Documentation introduced 2015-12-01 16:46 UTC by Report Bug Copy Issue Report `'admin'` is of type `string`, but the function expects a `object<string>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52
53	18	$router->group($this->getFoundationRouteGroup(), function (Router $router) {
54	18	(new Routes\DashboardRoute())->map($router);
55	18	});
56	18	}
57		}
58

ARCANESOFT / Foundation

Push — master ( b52d53...c245d9 )

RouteServiceProvider::getFoundationRouteGroup() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like