CheckAdministrators::handle() - Code Metrics - Inspection of "Updating sidebar auth visibility and other auth st..." - ARCANESOFT/Core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by ARCANEDEV

created 2016-09-24 22:46 UTC

CheckAdministrators::handle() A

↳ Parent: CheckAdministrators

Complexity

Conditions	3
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	3
eloc	5
nc	2
nop	2
dl	0
loc	11
ccs	0
cts	8
cp	0
crap	12
rs	9.4285
c	2
b	0
f	0

<?php namespace Arcanesoft\Core\Http\Middleware;

use Closure;
use Illuminate\Http\Request;

/**
 * Class     AdminMiddleware
 *
 * @package  Arcanesoft\Foundation\Http\Middleware
 * @author   ARCANEDEV <[email protected]>
 */
class CheckAdministrators
{
    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Run the request filter.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure                  $next
     *
     * @return mixed
     */
    public function handle(Request $request, Closure $next)
    {
        /** @var  \Arcanesoft\Contracts\Auth\Models\User  $user */
        $user = auth()->user();

        if (is_null($user) || ! $this->isAllowed($user)) {
            abort(404, "You're not allowed !");
        }

        return $next($request);
    }

    /* ------------------------------------------------------------------------------------------------
     |  Other Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Check if the user is allowed.
     *
     * @param  \Arcanesoft\Contracts\Auth\Models\User  $user
     *
     * @return bool
     */
    private function isAllowed($user)
    {
        return $user->isAdmin() || $user->isModerator();

    }
}


1			<?php namespace Arcanesoft\Core\Http\Middleware;
2
3			use Closure;
4			use Illuminate\Http\Request;
5
6			/**
7			* Class AdminMiddleware
8			*
9			* @package Arcanesoft\Foundation\Http\Middleware
10			* @author ARCANEDEV <[email protected]>
11			*/
12			class CheckAdministrators
13			{
14			/* ------------------------------------------------------------------------------------------------
15			\| Main Functions
16			\| ------------------------------------------------------------------------------------------------
17			*/
18			/**
19			* Run the request filter.
20			*
21			* @param \Illuminate\Http\Request $request
22			* @param \Closure $next
23			*
24			* @return mixed
25			*/
26			public function handle(Request $request, Closure $next)
27			{
28			/** @var \Arcanesoft\Contracts\Auth\Models\User $user */
29			$user = auth()->user();
30
31			if (is_null($user) \|\| ! $this->isAllowed($user)) {
32			abort(404, "You're not allowed !");
33			}
34
35			return $next($request);
36			}
37
38			/* ------------------------------------------------------------------------------------------------
39			\| Other Functions
40			\| ------------------------------------------------------------------------------------------------
41			*/
42			/**
43			* Check if the user is allowed.
44			*
45			* @param \Arcanesoft\Contracts\Auth\Models\User $user
46			*
47			* @return bool
48			*/
49			private function isAllowed($user)
50			{
51			return $user->isAdmin() \|\| $user->isModerator();
			0 ignored issues – show Bug introduced 2016-09-24 22:48 UTC by Report Bug Copy Issue Report The method `isModerator()` does not seem to exist on `object<Arcanesoft\Contracts\Auth\Models\User>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
52			}
53			}
54

ARCANESOFT / Core

Pull Request — master (#2)

CheckAdministrators::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like