YesOrNo - Code Metrics - Inspection of "Updating the package" - ARCANESOFT/Core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

by ARCANEDEV

created 2017-11-01 14:40 UTC

YesOrNo A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	67
ccs	9
cts	9
cp	1
rs	10
wmc	6
lcom	1
cbo	1

4 Methods

Rating	Name	Size	Complexity
A	all()	6	1
A	keys()	4	1
A	get()	4	1
A	parseKey()	4	3

<?php namespace Arcanesoft\Core\Entities;

/**
 * Class     YesOrNo
 *
 * @package  Arcanesoft\Core\Entities
 * @author   ARCANEDEV <[email protected]>
 */
class YesOrNo
{
    /* -----------------------------------------------------------------
     |  Constants
     | -----------------------------------------------------------------
     */

    const YES = 'yes';
    const NO  = 'no';

    /* -----------------------------------------------------------------
     |  All
     | -----------------------------------------------------------------
     */

    /**
     * Get all.
     *
     * @return \Illuminate\Support\Collection
     */
    public static function all()
    {
        return static::keys()->mapWithKeys(function ($status) {
            return [$status => trans("core::statuses.{$status}")];
        });
    }

    /**
     * Get all keys.
     *
     * @return \Illuminate\Support\Collection
     */
    public static function keys()
    {
        return collect([static::YES, static::NO]);
    }

    /**
     * Get a translated YoN status.
     *
     * @param  string|boolean  $key
     * @param  null            $default
     *
     * @return string|null
     */
    public static function get($key, $default = null)
    {
        return static::all()->get(static::parseKey($key), $default);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */

    /**
     * Parse the key.
     *
     * @param  string|boolean  $key
     *
     * @return string
     */
    private static function parseKey($key)
    {
        return is_bool($key) ? ($key ? static::YES : static::NO) : $key;
    }
}


1		<?php namespace Arcanesoft\Core\Entities;
2
3		/**
4		* Class YesOrNo
5		*
6		* @package Arcanesoft\Core\Entities
7		* @author ARCANEDEV <[email protected]>
8		*/
9		class YesOrNo
10		{
11		/* -----------------------------------------------------------------
12		\| Constants
13		\| -----------------------------------------------------------------
14		*/
15
16		const YES = 'yes';
17		const NO = 'no';
18
19		/* -----------------------------------------------------------------
20		\| All
21		\| -----------------------------------------------------------------
22		*/
23
24		/**
25		* Get all.
26		*
27		* @return \Illuminate\Support\Collection
28		*/
29		public static function all()
30		{
31	6	return static::keys()->mapWithKeys(function ($status) {
32	6	return [$status => trans("core::statuses.{$status}")];
33	6	});
34		}
35
36		/**
37		* Get all keys.
38		*
39		* @return \Illuminate\Support\Collection
40		*/
41	8	public static function keys()
42		{
43	8	return collect([static::YES, static::NO]);
44		}
45
46		/**
47		* Get a translated YoN status.
48		*
49		* @param string\|boolean $key
50		* @param null $default
51		*
52		* @return string\|null
53		*/
54	4	public static function get($key, $default = null)
55		{
56	4	return static::all()->get(static::parseKey($key), $default);
		0 ignored issues – show Bug introduced 2017-05-17 12:19 UTC by Report Bug Copy Issue Report Since `parseKey()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `parseKey()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
57		}
58
59		/* -----------------------------------------------------------------
60		\| Other Methods
61		\| -----------------------------------------------------------------
62		*/
63
64		/**
65		* Parse the key.
66		*
67		* @param string\|boolean $key
68		*
69		* @return string
70		*/
71	4	private static function parseKey($key)
72		{
73	4	return is_bool($key) ? ($key ? static::YES : static::NO) : $key;
74		}
75		}
76

ARCANESOFT / Core

Pull Request — master (#8)

YesOrNo A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like