CreatePostRequest - Code Metrics - Inspection of "Updating the package" - ARCANESOFT/Blog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 20b252...4d5a46 )

by ARCANEDEV

created 2016-12-28 17:46 UTC

CreatePostRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	4
lcom	0
cbo	2
dl	0
loc	40
rs	10
c	0
b	0
f	0
ccs	0
cts	15
cp	0

3 Methods

Rating	Name	Size	Complexity
A	authorize()	4	1
A	rules()	6	1
A	sanitize()	6	2

<?php namespace Arcanesoft\Blog\Http\Requests\Admin\Posts;

use Illuminate\Support\Str;
use Illuminate\Validation\Rule;

/**
 * Class     CreatePostRequest
 *
 * @package  Arcanesoft\Blog\Http\Requests\Admin\Posts
 * @author   ARCANEDEV <[email protected]>
 */
class CreatePostRequest extends PostRequest
{
    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return parent::rules() + [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'slug' => ['required', $this->getSlugRule()],
        ];
    }

    /**
     * Sanitize the inputs.
     *
     * @return array
     */
    protected function sanitize()
    {
        $slug = Str::slug($this->get($this->has('slug') ? 'slug' : 'title', ''));

        return compact('slug');
    }
}


1			<?php namespace Arcanesoft\Blog\Http\Requests\Admin\Posts;
2
3			use Illuminate\Support\Str;
4			use Illuminate\Validation\Rule;
5
6			/**
7			* Class CreatePostRequest
8			*
9			* @package Arcanesoft\Blog\Http\Requests\Admin\Posts
10			* @author ARCANEDEV <[email protected]>
11			*/
12			class CreatePostRequest extends PostRequest
13			{
14			/* ------------------------------------------------------------------------------------------------
15			\| Main Functions
16			\| ------------------------------------------------------------------------------------------------
17			*/
18			/**
19			* Determine if the user is authorized to make this request.
20			*
21			* @return bool
22			*/
23			public function authorize()
24			{
25			return true;
26			}
27
28			/**
29			* Get the validation rules that apply to the request.
30			*
31			* @return array
32			*/
33			public function rules()
34			{
35			return parent::rules() + [
			0 ignored issues – show Best Practice introduced 2016-12-28 17:51 UTC by Report Bug Copy Issue Report The expression `return parent::rules() +...$this->getSlugRule()));` seems to be an `array`, but some of its elements' types (`array<string\|Illuminate\Validation\Rules\Unique>`) are incompatible with the return type of the parent method `Arcanesoft\Blog\Http\Req...osts\PostRequest::rules` of type `array<string,string>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
36			'slug' => ['required', $this->getSlugRule()],
37			];
38			}
39
40			/**
41			* Sanitize the inputs.
42			*
43			* @return array
44			*/
45			protected function sanitize()
46			{
47			$slug = Str::slug($this->get($this->has('slug') ? 'slug' : 'title', ''));
48
49			return compact('slug');
50			}
51			}
52

ARCANESOFT / Blog

Push — master ( 20b252...4d5a46 )

CreatePostRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like