UpdateUserRequest::all() - Code Metrics - Inspection of "Refactoring the User Form Requests" - ARCANESOFT/Auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

by ARCANEDEV

created 2016-09-18 17:17 UTC

UpdateUserRequest::all() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
ccs	0
cts	6
cp	0
rs	9.4285
cc	1
eloc	3
nc	1
nop	0
crap	2

<?php namespace Arcanesoft\Auth\Http\Requests\Backend\Users;

/**
 * Class     UpdateUserRequest
 *
 * @package  Arcanesoft\Auth\Http\Requests\Backend\Users
 * @author   ARCANEDEV <[email protected]>
 */
class UpdateUserRequest extends UserRequest
{
    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        /** @var \Arcanesoft\Contracts\Auth\Models\User  $user */
        $user = $this->route('user_id');

        return [
            'username'              => "required|min:3|unique:users,username,{$user->id}",
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'email'                 => "required|email|unique:users,email,{$user->id}",
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'first_name'            => 'required|min:2',
            'last_name'             => 'required|min:2',
            'password'              => 'required_with:password_confirmation|min:8|confirmed',
            'password_confirmation' => 'required_with:password|min:8',
            'roles'                 => $this->getRolesRule(),
        ];
    }
}


Pull Request — master (#8)

UpdateUserRequest::all() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1			<?php namespace Arcanesoft\Auth\Http\Requests\Backend\Users;
2
3			/**
4			* Class UpdateUserRequest
5			*
6			* @package Arcanesoft\Auth\Http\Requests\Backend\Users
7			* @author ARCANEDEV <[email protected]>
8			*/
9			class UpdateUserRequest extends UserRequest
10			{
11			/* ------------------------------------------------------------------------------------------------
12			\| Main Functions
13			\| ------------------------------------------------------------------------------------------------
14			*/
15			/**
16			* Determine if the user is authorized to make this request.
17			*
18			* @return bool
19			*/
20			public function authorize()
21			{
22			return true;
23			}
24
25			/**
26			* Get the validation rules that apply to the request.
27			*
28			* @return array
29			*/
30			public function rules()
31			{
32			/** @var \Arcanesoft\Contracts\Auth\Models\User $user */
33			$user = $this->route('user_id');
34
35			return [
36			'username' => "required\|min:3\|unique:users,username,{$user->id}",
			0 ignored issues – show Bug introduced 2016-09-18 17:24 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Arcanesoft\Contracts\Auth\Models\User` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
37			'email' => "required\|email\|unique:users,email,{$user->id}",
			0 ignored issues – show Bug introduced 2016-09-18 17:24 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Arcanesoft\Contracts\Auth\Models\User` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
38			'first_name' => 'required\|min:2',
39			'last_name' => 'required\|min:2',
40			'password' => 'required_with:password_confirmation\|min:8\|confirmed',
41			'password_confirmation' => 'required_with:password\|min:8',
42			'roles' => $this->getRolesRule(),
43			];
44			}
45			}
46

ARCANESOFT / Auth

Pull Request — master (#8)

UpdateUserRequest::all() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like