RolesController::show() - Code Metrics - Inspection of "Merge pull request #3 from ARCANESOFT/patch-1" - ARCANESOFT/Auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cb5a9c...81e444 )

by ARCANEDEV

created 2015-12-24 15:26 UTC

RolesController::show() A

↳ Parent: RolesController

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	10
ccs	0
cts	8
cp	0
rs	9.4286
cc	1
eloc	6
nc	1
nop	1
crap	2

<?php namespace Arcanesoft\Auth\Http\Controllers\Foundation;

use Arcanesoft\Auth\Bases\FoundationController;
use Arcanesoft\Auth\Http\Requests\Backend\Roles\CreateRoleRequest;
use Arcanesoft\Auth\Http\Requests\Backend\Roles\UpdateRoleRequest;
use Arcanesoft\Auth\Models\Role;
use Illuminate\Support\Facades\Log;

/**
 * Class     RolesController
 *
 * @package  Arcanesoft\Auth\Http\Controllers\Foundation
 * @author   ARCANEDEV <[email protected]>
 */
class RolesController extends FoundationController
{
    /* ------------------------------------------------------------------------------------------------
     |  Constructor
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Instantiate the controller.
     */
    public function __construct()
    {
        parent::__construct();

        $this->setCurrentPage('auth-roles');
        $this->addBreadcrumbRoute('Roles', 'auth::foundation.roles.index');
    }

    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    public function index()
    {
        $roles = Role::with('users', 'permissions')->paginate(30);

        $title = 'List of roles';
        $this->setTitle($title);
        $this->addBreadcrumb($title);

        return $this->view('foundation.roles.list', compact('roles'));
    }

    public function create()
    {
        $title = 'Create a role';
        $this->setTitle($title);
        $this->addBreadcrumb($title);

        return $this->view('foundation.roles.create');
    }

    public function store(CreateRoleRequest $request, Role $role)
    {
        $role->fill($request->only('name', 'slug', 'description'));
        $role->save();
        $role->permissions()->attach($request->get('permissions'));

        $message = 'The new role was successfully created !';

        Log::info($message, $role->toArray());

        return redirect()
            ->route('auth::foundation.roles.index')
            ->with('success', $message);
    }

    public function show(Role $role)
    {
        $role->load(['users', 'permissions', 'permissions.group']);

        $title = 'Role details';
        $this->setTitle($title);
        $this->addBreadcrumb($title);

        return $this->view('foundation.roles.show', compact('role'));
    }

    public function edit(Role $role)
    {
        $role->load(['users', 'permissions']);

        $title = 'Edit Role';
        $this->setTitle($title);
        $this->addBreadcrumb($title);

        return $this->view('foundation.roles.edit', compact('role'));
    }

    public function update(UpdateRoleRequest $request, Role $role)
    {
        $role->fill($request->only('name', 'slug', 'description'));
        $role->save();
        $role->permissions()->sync($request->get('permissions'));

        $message = 'The role was successfully updated !';

        Log::info($message, $role->toArray());

        return redirect()
            ->route('auth::foundation.roles.show', [$role->hashed_id])
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->with('success', $message);
    }

    public function delete(Role $role)
    {
        self::onlyAjax();

        try {
            $role->delete();

            $message = "The role {$role->name} has been successfully deleted.";
            Log::info($message, $role->toArray());

            $ajax = [
                'status'  => 'success',
                'message' => $message,
            ];
        }
        catch(\Exception $e) {
            $ajax = [
                'status'  => 'error',
                'message' => $e->getMessage(),
            ];
        }

        return response()->json($ajax);
    }
}


1			<?php namespace Arcanesoft\Auth\Http\Controllers\Foundation;
2
3			use Arcanesoft\Auth\Bases\FoundationController;
4			use Arcanesoft\Auth\Http\Requests\Backend\Roles\CreateRoleRequest;
5			use Arcanesoft\Auth\Http\Requests\Backend\Roles\UpdateRoleRequest;
6			use Arcanesoft\Auth\Models\Role;
7			use Illuminate\Support\Facades\Log;
8
9			/**
10			* Class RolesController
11			*
12			* @package Arcanesoft\Auth\Http\Controllers\Foundation
13			* @author ARCANEDEV <[email protected]>
14			*/
15			class RolesController extends FoundationController
16			{
17			/* ------------------------------------------------------------------------------------------------
18			\| Constructor
19			\| ------------------------------------------------------------------------------------------------
20			*/
21			/**
22			* Instantiate the controller.
23			*/
24			public function __construct()
25			{
26			parent::__construct();
27
28			$this->setCurrentPage('auth-roles');
29			$this->addBreadcrumbRoute('Roles', 'auth::foundation.roles.index');
30			}
31
32			/* ------------------------------------------------------------------------------------------------
33			\| Main Functions
34			\| ------------------------------------------------------------------------------------------------
35			*/
36			public function index()
37			{
38			$roles = Role::with('users', 'permissions')->paginate(30);
39
40			$title = 'List of roles';
41			$this->setTitle($title);
42			$this->addBreadcrumb($title);
43
44			return $this->view('foundation.roles.list', compact('roles'));
45			}
46
47			public function create()
48			{
49			$title = 'Create a role';
50			$this->setTitle($title);
51			$this->addBreadcrumb($title);
52
53			return $this->view('foundation.roles.create');
54			}
55
56			public function store(CreateRoleRequest $request, Role $role)
57			{
58			$role->fill($request->only('name', 'slug', 'description'));
59			$role->save();
60			$role->permissions()->attach($request->get('permissions'));
61
62			$message = 'The new role was successfully created !';
63
64			Log::info($message, $role->toArray());
65
66			return redirect()
67			->route('auth::foundation.roles.index')
68			->with('success', $message);
69			}
70
71			public function show(Role $role)
72			{
73			$role->load(['users', 'permissions', 'permissions.group']);
74
75			$title = 'Role details';
76			$this->setTitle($title);
77			$this->addBreadcrumb($title);
78
79			return $this->view('foundation.roles.show', compact('role'));
80			}
81
82			public function edit(Role $role)
83			{
84			$role->load(['users', 'permissions']);
85
86			$title = 'Edit Role';
87			$this->setTitle($title);
88			$this->addBreadcrumb($title);
89
90			return $this->view('foundation.roles.edit', compact('role'));
91			}
92
93			public function update(UpdateRoleRequest $request, Role $role)
94			{
95			$role->fill($request->only('name', 'slug', 'description'));
96			$role->save();
97			$role->permissions()->sync($request->get('permissions'));
98
99			$message = 'The role was successfully updated !';
100
101			Log::info($message, $role->toArray());
102
103			return redirect()
104			->route('auth::foundation.roles.show', [$role->hashed_id])
			0 ignored issues – show Documentation introduced 2015-12-18 20:55 UTC by Report Bug Copy Issue Report The property `hashed_id` does not exist on `object<Arcanesoft\Auth\Models\Role>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
105			->with('success', $message);
106			}
107
108			public function delete(Role $role)
109			{
110			self::onlyAjax();
111
112			try {
113			$role->delete();
114
115			$message = "The role {$role->name} has been successfully deleted.";
116			Log::info($message, $role->toArray());
117
118			$ajax = [
119			'status' => 'success',
120			'message' => $message,
121			];
122			}
123			catch(\Exception $e) {
124			$ajax = [
125			'status' => 'error',
126			'message' => $e->getMessage(),
127			];
128			}
129
130			return response()->json($ajax);
131			}
132			}
133

ARCANESOFT / Auth

Push — master ( cb5a9c...81e444 )

RolesController::show() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like