PermissionsController::getGroupsFilters() - Code Metrics - Inspection of "Adding Permission's Groups" - ARCANESOFT/Auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by ARCANEDEV

created 2015-12-20 21:31 UTC

PermissionsController::getGroupsFilters() A

↳ Parent: PermissionsController

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
ccs	0
cts	10
cp	0
rs	9.4286
cc	2
eloc	7
nc	2
nop	0
crap	6

<?php namespace Arcanesoft\Auth\Http\Controllers\Foundation;

use Arcanesoft\Auth\Bases\FoundationController;
use Arcanesoft\Auth\Models\Permission;
use Arcanesoft\Auth\Models\PermissionsGroup;

/**
 * Class     PermissionsController
 *
 * @package  Arcanesoft\Auth\Http\Controllers\Foundation
 * @author   ARCANEDEV <[email protected]>
 */
class PermissionsController extends FoundationController
{
    /* ------------------------------------------------------------------------------------------------
     |  Constructor
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Instantiate the controller.
     */
    public function __construct()
    {
        parent::__construct();

        $this->setCurrentPage('auth-permissions');
        $this->addBreadcrumbRoute('Permissions', 'auth::foundation.permissions.index');
    }

    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    public function index(Permission $permission)
    {
        $permissions = $permission->with('group', 'roles')
            ->orderBy('group_id')
            ->paginate(30);

        $groupsLinks = $this->getGroupsFilters();

        $title = 'List of permissions';
        $this->setTitle($title);
        $this->addBreadcrumb($title);

        return $this->view('foundation.permissions.list', compact('permissions', 'groupsLinks'));
    }

    public function group(Permission $permission, PermissionsGroup $group)
    {
        $groupId = $group->id ? $group->id : 0;

        $permissions = $permission->where('group_id', $groupId)
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ->with('group', 'roles')
            ->paginate(30);

        $groupsLinks = $this->getGroupsFilters();

        $this->addBreadcrumbRoute('List of permissions', 'auth::foundation.permissions.index');

        $groupName = $groupId == 0 ? 'Custom' : $group->name;
        $title     = "List of permissions - $groupName";
        $this->setTitle($title);
        $this->addBreadcrumb($groupName);

        return $this->view('foundation.permissions.list', compact('permissions', 'groupsLinks'));
    }

    public function show(Permission $permission)
    {
        $permission->load(['roles', 'roles.users']);

        $groupsLinks = $this->getGroupsFilters();

        $title = 'Permission details';
        $this->setTitle($title);
        $this->addBreadcrumb($title);

        return $this->view('foundation.permissions.show', compact('permission', 'groupsLinks'));
    }

    /* ------------------------------------------------------------------------------------------------
     |  Other Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Get the groups filters links.
     *
     * @return array
     */
    protected function getGroupsFilters()
    {
        $filters   = [];
        $filters[] = link_to_route('auth::foundation.permissions.index', 'All');

        foreach (PermissionsGroup::all() as $group) {
            /** @var  PermissionsGroup  $group */
            $filters[] = link_to_route('auth::foundation.permissions.group', $group->name, [$group->hashed_id]);
        }

        $filters[] = link_to_route('auth::foundation.permissions.group', 'Custom', [hasher()->encode(0)]);

        return $filters;
    }
}


1			<?php namespace Arcanesoft\Auth\Http\Controllers\Foundation;
2
3			use Arcanesoft\Auth\Bases\FoundationController;
4			use Arcanesoft\Auth\Models\Permission;
5			use Arcanesoft\Auth\Models\PermissionsGroup;
6
7			/**
8			* Class PermissionsController
9			*
10			* @package Arcanesoft\Auth\Http\Controllers\Foundation
11			* @author ARCANEDEV <[email protected]>
12			*/
13			class PermissionsController extends FoundationController
14			{
15			/* ------------------------------------------------------------------------------------------------
16			\| Constructor
17			\| ------------------------------------------------------------------------------------------------
18			*/
19			/**
20			* Instantiate the controller.
21			*/
22			public function __construct()
23			{
24			parent::__construct();
25
26			$this->setCurrentPage('auth-permissions');
27			$this->addBreadcrumbRoute('Permissions', 'auth::foundation.permissions.index');
28			}
29
30			/* ------------------------------------------------------------------------------------------------
31			\| Main Functions
32			\| ------------------------------------------------------------------------------------------------
33			*/
34			public function index(Permission $permission)
35			{
36			$permissions = $permission->with('group', 'roles')
37			->orderBy('group_id')
38			->paginate(30);
39
40			$groupsLinks = $this->getGroupsFilters();
41
42			$title = 'List of permissions';
43			$this->setTitle($title);
44			$this->addBreadcrumb($title);
45
46			return $this->view('foundation.permissions.list', compact('permissions', 'groupsLinks'));
47			}
48
49			public function group(Permission $permission, PermissionsGroup $group)
50			{
51			$groupId = $group->id ? $group->id : 0;
52
53			$permissions = $permission->where('group_id', $groupId)
			0 ignored issues – show Documentation Bug introduced 2015-12-20 21:34 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<Arcanesoft\Auth\Models\Permission>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
54			->with('group', 'roles')
55			->paginate(30);
56
57			$groupsLinks = $this->getGroupsFilters();
58
59			$this->addBreadcrumbRoute('List of permissions', 'auth::foundation.permissions.index');
60
61			$groupName = $groupId == 0 ? 'Custom' : $group->name;
62			$title = "List of permissions - $groupName";
63			$this->setTitle($title);
64			$this->addBreadcrumb($groupName);
65
66			return $this->view('foundation.permissions.list', compact('permissions', 'groupsLinks'));
67			}
68
69			public function show(Permission $permission)
70			{
71			$permission->load(['roles', 'roles.users']);
72
73			$groupsLinks = $this->getGroupsFilters();
74
75			$title = 'Permission details';
76			$this->setTitle($title);
77			$this->addBreadcrumb($title);
78
79			return $this->view('foundation.permissions.show', compact('permission', 'groupsLinks'));
80			}
81
82			/* ------------------------------------------------------------------------------------------------
83			\| Other Functions
84			\| ------------------------------------------------------------------------------------------------
85			*/
86			/**
87			* Get the groups filters links.
88			*
89			* @return array
90			*/
91			protected function getGroupsFilters()
92			{
93			$filters = [];
94			$filters[] = link_to_route('auth::foundation.permissions.index', 'All');
95
96			foreach (PermissionsGroup::all() as $group) {
97			/** @var PermissionsGroup $group */
98			$filters[] = link_to_route('auth::foundation.permissions.group', $group->name, [$group->hashed_id]);
99			}
100
101			$filters[] = link_to_route('auth::foundation.permissions.group', 'Custom', [hasher()->encode(0)]);
102
103			return $filters;
104			}
105			}
106

ARCANESOFT / Auth

Pull Request — master (#2)

PermissionsController::getGroupsFilters() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like